Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2225979/?format=api
{ "id": 2225979, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2225979/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260421234022.4144209-1-michael.bommarito@gmail.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.1/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260421234022.4144209-1-michael.bommarito@gmail.com>", "date": "2026-04-21T23:40:22", "name": "smb: client: scope end_of_dacl to CIFS_DEBUG2 use in parse_dacl", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "20cb84a06521aa3b88d5e14f9cb236991cce1659", "submitter": { "id": 93078, "url": "http://patchwork.ozlabs.org/api/1.1/people/93078/?format=api", "name": "Michael Bommarito", "email": "michael.bommarito@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260421234022.4144209-1-michael.bommarito@gmail.com/mbox/", "series": [ { "id": 500903, "url": "http://patchwork.ozlabs.org/api/1.1/series/500903/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500903", "date": "2026-04-21T23:40:22", "name": "smb: client: scope end_of_dacl to CIFS_DEBUG2 use in parse_dacl", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500903/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225979/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225979/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-10990-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=E/KYD38C;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10990-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"E/KYD38C\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.219.50", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0f4w2BVSz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 09:41:20 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CCD3C3027115\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 23:40:33 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 658EC39DBF0;\n\tTue, 21 Apr 2026 23:40:33 +0000 (UTC)", "from mail-qv1-f50.google.com (mail-qv1-f50.google.com\n [209.85.219.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B5DD3806DD\n\tfor <linux-cifs@vger.kernel.org>; Tue, 21 Apr 2026 23:40:31 +0000 (UTC)", "by mail-qv1-f50.google.com with SMTP id\n 6a1803df08f44-8b038a00370so34899836d6.1\n for <linux-cifs@vger.kernel.org>;\n Tue, 21 Apr 2026 16:40:31 -0700 (PDT)", "from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b02ae86947sm152590596d6.37.2026.04.21.16.40.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 16:40:30 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776814833; cv=none;\n b=ZP+IcEusESjvkCJNSdbDlDKcFhtVWMJLNsFnWpX1YuLGYXzeCU+PeiJJ2d/sqj3ajxx4ltsV+x+apfvla92XuP6YDKeP5wGTm96n54R1ILMC+Fo7R8CcbwEWALYgDxltyBC09HUNMd+Go9qAHx/qgw9bpvb6CsluQ25+0LLp3XE=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776814833; c=relaxed/simple;\n\tbh=FAjd0SGYlTGbrBuZkkUHlFzHmjvnupkiWc5/sWK4Frc=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=SifaiU5rHPbURed//HuafqN5bYkEx5sd6oBsenNABiTgql3vT9kxF7oq4eeytK0PMoRmYEj+EQhwRL6ZIsuARi9npwajN/n7x6mJBy5Lt5WSQGGKlhXiwu/VjCzMtBa/J0PDCkONBlq2AVnV9j94208QJoXdv99E0GWZ+QfoNI8=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=E/KYD38C; arc=none smtp.client-ip=209.85.219.50", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776814831; x=1777419631;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WHYPowIO/Ty/lLtBU9hns/rmbNm5oK+oGzhuJOxaFBs=;\n b=E/KYD38CDdCa0WDj2RnqfZ0gy0G5TYbjL4OQ8UrFBMedffCPEg9BrhMXWeaLh4XdKh\n uV48BmGHysY3wOsgTky57ggCu6VaBU0Tdqx6bP7XNedOQ0qEihQRm8Bi8cRoJQWS6efv\n Jgl9s74VpVQfkxliYxhXZs3aAs64VPPU6hgWvvGZ8Gg6bz8CkEfN0xP6QxDWscuMUYJM\n HVlJTywkRjPdj5eepDrOgyu75SQgTJPCzN+WUo5G6Nq1MpdbqiPipD/XAfrMupzSP/iR\n cOKPXPzQjTOirg89GrhCx0FnoaGDnx8VOI+AdCgMd6HDwSkYdHezR4gvEPGxMk3SrP7Z\n 99zg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776814831; x=1777419631;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=WHYPowIO/Ty/lLtBU9hns/rmbNm5oK+oGzhuJOxaFBs=;\n b=dRdzwDbMCi6wf3ouIfgK//vX+j24rzaOKXYQyjQSPQ+8s2FcMBxLuZueNFuHvRYJTW\n NcSoTeNxHphlwbilnfgjn/O+2sjSuUxMnrtiOITd2thjotSY3P6revzVBvihf3RyE/6s\n diEb9TQzUuBMd2uOg5joRau/QgXs6QjxQsaNF1wHmm6HgItV3qC419sA17Sa6sobQbYD\n B8Ie9eXmKIl3T6nDCpbwsK5w+XFgcFOS8D7AUQv09LKTPknb/Aviz1XIxC5PfOVRnI3a\n EoWG8EzxqcTpTaPOfPvdXLQPvV3CGyFfaWssQS8pXrDldiWy8PG1x+SwgniOce9GIeNj\n ulkg==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ+aAPZH2Bvz1yuYJ0D19xwFxQ21bZg3WE7XzjwPIEHGHKqZwRNO3wMc9XFmINseD+fRSLO2IBqotHPL@vger.kernel.org", "X-Gm-Message-State": "AOJu0YyNGBOKHDPLNCAiRA0KdoXesqNu/kTnHx5sFtc2cAexR/+sjT/B\n\ttwmLN9MRL5y5ASoeZZTHaUtLFGYUEElS1CoJaY/twshjomn5xlHRht50BZQ1gzEJ", "X-Gm-Gg": "AeBDieuMpFt7rinbM2Q6xpj4NZ54c/eSgU6Syiya2pyMdfUYC/dmSaL5Ww4E+jfonkC\n\t/EoFG0RTpkzjoOCz4gZf+uUrfL6SEMfN9a7R1/P1O6Wv0v2RWQR6RRaU+zzKeNWtCjiJomWsyP2\n\t3t5oe0SRzm0Kdp+ix7IxTcRUwg44VGij9soUoBee66q1Hk9Aky7d7PjB3mrFWEDI9HN3hl+Gjv0\n\toTXvWR5fYzGigOjWizZFhtlOeZJMzGddlV3AbFt4pkE+mOubxEwI3QM6uWNFmxieTQOWchNsel5\n\tw/Oq1xRuGflqT8bv8CsGFQd/YRolKEbX2knMU1XEOd9K6uJH5Ac7MMrmMdlLAKLt3X1UVz/SSYj\n\t64xvKv4yvR6JsIoW4N6DtptVQas3eYQXvXInS4IL+h83WZQWO7nUbyqdRUxwQi2C5a7JmqNNsxh\n\t7KwdkM7FAhS3v7a4VxTWwlsZ61txtd8pFAnpIr10mgK0O7QGlZfpfRfH1y0VAZg34EUhp1RTkH0\n\tc6n3ayvLfoeeqUoyXf0LWAKoOg80xo=", "X-Received": "by 2002:a05:6214:2f03:b0:8ac:af0d:c101 with SMTP id\n 6a1803df08f44-8b027fd9d3fmr313865016d6.10.1776814831016;\n Tue, 21 Apr 2026 16:40:31 -0700 (PDT)", "From": "Michael Bommarito <michael.bommarito@gmail.com>", "To": "Steve French <sfrench@samba.org>", "Cc": "Steve French <stfrench@microsoft.com>,\n\tPaulo Alcantara <pc@manguebit.org>,\n\tRonnie Sahlberg <ronniesahlberg@gmail.com>,\n\tShyam Prasad N <sprasad@microsoft.com>,\n\tTom Talpey <tom@talpey.com>,\n\tBharath SM <bharathsm@microsoft.com>,\n\tlinux-cifs@vger.kernel.org,\n\tsamba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org,\n\tkernel test robot <lkp@intel.com>,\n\toe-kbuild-all@lists.linux.dev", "Subject": "[PATCH] smb: client: scope end_of_dacl to CIFS_DEBUG2 use in\n parse_dacl", "Date": "Tue, 21 Apr 2026 19:40:22 -0400", "Message-ID": "<20260421234022.4144209-1-michael.bommarito@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<202604220046.tGkRxVtS-lkp@intel.com>", "References": "<202604220046.tGkRxVtS-lkp@intel.com>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "After validate_dacl() was factored out in commit 149822e5541c, the\nlocal end_of_dacl in parse_dacl() is only read by the dump_ace()\ncall under #ifdef CONFIG_CIFS_DEBUG2. With CIFS_DEBUG2 off the\nvariable is assigned but never used, which gcc -W=1 flags as\n-Wunused-but-set-variable.\n\nRemove the local and compute the end-of-dacl pointer inline at the\nsingle call site inside the existing CIFS_DEBUG2 guard. No\nfunctional change: when CIFS_DEBUG2 is enabled the argument value\nis identical to what the removed local carried; when CIFS_DEBUG2\nis disabled the code was already dead.\n\nReported-by: kernel test robot <lkp@intel.com>\nCloses: https://lore.kernel.org/oe-kbuild-all/202604220046.tGkRxVtS-lkp@intel.com/\nFixes: 149822e5541c (\"smb: client: validate the whole DACL before rewriting it in cifsacl\")\nSigned-off-by: Michael Bommarito <michael.bommarito@gmail.com>\nAssisted-by: Claude:claude-opus-4-7\n---\n fs/smb/client/cifsacl.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c\nindex 4ec204d2c774..ec5d47779304 100644\n--- a/fs/smb/client/cifsacl.c\n+++ b/fs/smb/client/cifsacl.c\n@@ -836,7 +836,7 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,\n \tint i;\n \tu16 num_aces = 0;\n \tint acl_size;\n-\tchar *acl_base, *end_of_dacl;\n+\tchar *acl_base;\n \tstruct smb_ace **ppace;\n \n \t/* BB need to add parm so we can store the SID BB */\n@@ -860,7 +860,6 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,\n \t user/group/other have no permissions */\n \tfattr->cf_mode &= ~(0777);\n \n-\tend_of_dacl = (char *)pdacl + le16_to_cpu(pdacl->size);\n \tacl_base = (char *)pdacl;\n \tacl_size = sizeof(struct smb_acl);\n \n@@ -876,7 +875,8 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,\n \t\t\tppace[i] = (struct smb_ace *) (acl_base + acl_size);\n \n #ifdef CONFIG_CIFS_DEBUG2\n-\t\t\tdump_ace(ppace[i], end_of_dacl);\n+\t\t\tdump_ace(ppace[i],\n+\t\t\t\t (char *)pdacl + le16_to_cpu(pdacl->size));\n #endif\n \t\t\tif (mode_from_special_sid &&\n \t\t\t ppace[i]->sid.num_subauth >= 3 &&\n", "prefixes": [] }