[{"id":3680142,"web_url":"http://patchwork.ozlabs.org/comment/3680142/","msgid":"","list_archive_url":null,"date":"2026-04-21T23:58:33","subject":"Re: [PATCH] smb: client: scope end_of_dacl to CIFS_DEBUG2 use in\n parse_dacl","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"merged into cifs-2.6.git for-next\n\nOn Tue, Apr 21, 2026 at 6:40 PM Michael Bommarito\n wrote:\n>\n> After validate_dacl() was factored out in commit 149822e5541c, the\n> local end_of_dacl in parse_dacl() is only read by the dump_ace()\n> call under #ifdef CONFIG_CIFS_DEBUG2. With CIFS_DEBUG2 off the\n> variable is assigned but never used, which gcc -W=1 flags as\n> -Wunused-but-set-variable.\n>\n> Remove the local and compute the end-of-dacl pointer inline at the\n> single call site inside the existing CIFS_DEBUG2 guard. No\n> functional change: when CIFS_DEBUG2 is enabled the argument value\n> is identical to what the removed local carried; when CIFS_DEBUG2\n> is disabled the code was already dead.\n>\n> Reported-by: kernel test robot \n> Closes: https://lore.kernel.org/oe-kbuild-all/202604220046.tGkRxVtS-lkp@intel.com/\n> Fixes: 149822e5541c (\"smb: client: validate the whole DACL before rewriting it in cifsacl\")\n> Signed-off-by: Michael Bommarito \n> Assisted-by: Claude:claude-opus-4-7\n> ---\n> fs/smb/client/cifsacl.c | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c\n> index 4ec204d2c774..ec5d47779304 100644\n> --- a/fs/smb/client/cifsacl.c\n> +++ b/fs/smb/client/cifsacl.c\n> @@ -836,7 +836,7 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,\n> int i;\n> u16 num_aces = 0;\n> int acl_size;\n> - char *acl_base, *end_of_dacl;\n> + char *acl_base;\n> struct smb_ace **ppace;\n>\n> /* BB need to add parm so we can store the SID BB */\n> @@ -860,7 +860,6 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,\n> user/group/other have no permissions */\n> fattr->cf_mode &= ~(0777);\n>\n> - end_of_dacl = (char *)pdacl + le16_to_cpu(pdacl->size);\n> acl_base = (char *)pdacl;\n> acl_size = sizeof(struct smb_acl);\n>\n> @@ -876,7 +875,8 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,\n> ppace[i] = (struct smb_ace *) (acl_base + acl_size);\n>\n> #ifdef CONFIG_CIFS_DEBUG2\n> - dump_ace(ppace[i], end_of_dacl);\n> + dump_ace(ppace[i],\n> + (char *)pdacl + le16_to_cpu(pdacl->size));\n> #endif\n> if (mode_from_special_sid &&\n> ppace[i]->sid.num_subauth >= 3 &&\n> --\n> 2.53.0\n>\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=tDdK2NC4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10992-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"tDdK2NC4\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.219.41","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0fT94x1hz1yGs\n\tfor ; Wed, 22 Apr 2026 09:58:53 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 3A9DB3030980\n\tfor ; Tue, 21 Apr 2026 23:58:50 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 57ECF3A63E6;\n\tTue, 21 Apr 2026 23:58:48 +0000 (UTC)","from mail-qv1-f41.google.com (mail-qv1-f41.google.com\n [209.85.219.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E32EB36167B\n\tfor ; Tue, 21 Apr 2026 23:58:46 +0000 (UTC)","by mail-qv1-f41.google.com with SMTP id\n 6a1803df08f44-8a151012558so53083766d6.3\n for ;\n Tue, 21 Apr 2026 16:58:46 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776815928; cv=pass;\n b=oC2QTfzAA9TN4ByAfSQPWFmHXJRqp+u1KOuaKxzsedDMFDRsDX3cm5UY/dJr4vakDTx+sUbccX7F2bj48O2wBAAfwF2Dg3UslFdw08tMtroG580G+RIQBXtVfXpuwAzZBj2Cnb7ziHCR3PIJjjR+0E+Z+uMVIKZ5Ki8XO8TNc3c=","i=1; a=rsa-sha256; t=1776815926; cv=none;\n d=google.com; s=arc-20240605;\n b=MuAQx/4DWKcMXnszsx4R3GUPFG1utvosXNxA1Jvb9M0OOZuHte49vEoj25F5HAjRCl\n qhRV1wuCI14hcxeWSC+aHuaQY4CoKHbzVXBRdnCiD9WShDZW7J/6CzlxvM/4RRgDsRdU\n mhjv947oAAGS+1rY1H8pi/BCQqTWRuXXaOa2M+Le8Aafzy8BLckOQQFpV29ZKkFce8z7\n 9HBz3JiEQGKTGSj3tolU5+oQhFPK8nBCG7Zm1RSkh8nZyvq4vG309QQUanptaquZg+Wu\n xPCcksVJ5I9vF23yCKFz7YsOuv2EAYBdvwd16Omq26eqcjtSkdWBmahgJaocjSTpbJiS\n KQaQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776815928; c=relaxed/simple;\n\tbh=h6st7tUPmacYRbcbyVHk1J1MmG7oibqwV0YNku9qCTU=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=K7JhVZ3zymPfzUIkNBc9BJWBYbHs9fMAZw+KeZmOnXeThs18BfTx0tR5yORI1+hp32Dqu3uoAepOaiRUHJbEnmuTXn6yfwBOQUISR8ViaPz6f14QON0Lede8ISJ44UqUJA/kRIAE2Y5MEVCi12aJi0s+vcoBPkjK3XBK8U92YsQ=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=1w9xmPIw1s4ACofNeSxjnnwGMUxDSVTPAfVJPCJagLY=;\n fh=LkWR6+ZIjPscXyWh/U6uVaNMTfbqm2hNZabMFStHs60=;\n b=FOMkwwX2ltA0VNNhm8GgTabSnUgaG+AgCSP0mMe1vx8joJ1iy+N1VMt4XUaxGkPMKL\n VSbyMtkS/lyRuEzpVhpupWxsvl7OGJeiX8CcKgZrfilqla/HiZw+LOhme8jV3Ag9H6y1\n fvyn3VUIZVPOnHHnbpGAS7Be6EGsFeVyoXeq85vxtX5W9EjhHSPxHw7NxwGuRi+LxWHB\n TPJ5BjrvzaGvHE5cs0AQhCeWQWjHMBxn/+00CbaL3A17Xwq5HDpTEnQy1I+2mb7VA0dM\n d8yChBl05JhijlzUpF1FKVJoB5C1XmusUhUrsSKeAdPx0/UbsS/9rK0oCaMG6Zu6YzRJ\n FvhQ==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=tDdK2NC4; arc=pass smtp.client-ip=209.85.219.41","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776815926; x=1777420726;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1w9xmPIw1s4ACofNeSxjnnwGMUxDSVTPAfVJPCJagLY=;\n b=tDdK2NC4wPsVyTIH2ZrxLDvVMayZgWpR9xwJDRwW1ZS3jvJndCzmXgibRBDI0D1rF6\n 0iZwsza7a7yRDIVLUyT5WjqvrUA4ITnP6KWFCJImOpWLsn2KkDBP8ThE0pGI5OsxQk/w\n siwIeZN4UpgAACmp74h3nDfkDYy7mXVqtBT1PjE+xTBHzT83/zckTB142ls6yhHPZsMu\n 7mj3WWl77jNBc0QMkOnSnNtimdw1u711V8q5eypEzGdUJejW9+ckwy7kIA1xigrtBo0v\n SKX9odzZskA8BJsk6QUUEc6/3RhEwhUp2UInroOaOmQ5bNJpNzrMxTt4C0kKRWrFvbY5\n JweA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776815926; x=1777420726;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=1w9xmPIw1s4ACofNeSxjnnwGMUxDSVTPAfVJPCJagLY=;\n b=ZH8rAgltXFdxAijBeXE3raHRMZI95tZPzDaBU1ciTkd+Ogkfg2qbbZMy4mL+KKy50q\n ryxkD/lFQYdTHW3Gmd4TtYnohFuIr0VQNyDfno8DPLdztz/DMTwGE5cindBjtHEIMRhh\n Y8arNbkz69VwcdZ2CrUFO5d5iF34QxgPgPcehYQsr3Dcmr/0tWstXqE/SV+gwPJrWx8Q\n xCdZ9o1SuvcrLcmbAL2S0mDXvJkbZ6KcKzpLP6ARGAUZEfaKYziBtWDFM84t74mEin/+\n TrreYj+KR2qBjQPGqD3ztYyrMG2kWpsSIhV69TzY2miYU7gUZbzFeia78fWc6uGcw5rg\n SOyA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9nd+XyxXy8vBtPSYaksy4kuWs/lfF+0V/WZpBrhBeIaj3cCjnCfkOAh0nd+07rf1DexXtFyXdAL/Le@vger.kernel.org","X-Gm-Message-State":"AOJu0YwKxg8o06GZf1DQ5NjsMGi8zl5UobUGuX+jxZZ9fMXa+UX5OpMJ\n\teZblmX0SnfimL70UUdtiuLWsUlTV64RsWCA3fO7fZmTpKkRmfLu8r4TNQA3k7mHCBupCt+Okz0v\n\tF1Qlzo51jOXCDPqoJbDArbJMWlvfysFs=","X-Gm-Gg":"AeBDievyexD1u5rl1YHJcPYKdztDsg9vodWGt2BLWpKJCGB+mARcY1Cz0wDrqaYP6QH\n\t6jFkbfhwVWSKwvmO+OkWer3xbTAUVytZA4+yAwYurrk/NsZSiIQIjLCIWf0ost0EAxjas8vX/fU\n\tfrPDxGZDrjZAVlwlLaXI1Ni/1F58HXhk36fcPoGl9DYOFW1KLdT7QnMCQtZagtHpn6rk8cMCFHK\n\t0LmfLdpT0fZuWyMcpaRpGg65zEtrh9mYvcXNTLUR+02VOqdIWsePksmo+nRapBODHChukacCkCo\n\tJzb9EK2fr82THGLczifeRyCtEv9/Ih+IZAlo65ENWqbxF5umr5wsXwrb+HUHLKo56i/jEAXcHR8\n\tbLOIoJqIax0kEuQ5vgvNG+9JTsOFkuhJIAQ7j4RY+66NfHINnDhAqD25DhY1bpSy4z40OjIR9WA\n\t==","X-Received":"by 2002:a05:6214:5b86:b0:8ac:7d7a:56fb with SMTP id\n 6a1803df08f44-8b027ff9ad8mr334820896d6.5.1776815925829; Tue, 21 Apr 2026\n 16:58:45 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<202604220046.tGkRxVtS-lkp@intel.com>\n <20260421234022.4144209-1-michael.bommarito@gmail.com>","In-Reply-To":"<20260421234022.4144209-1-michael.bommarito@gmail.com>","From":"Steve French ","Date":"Tue, 21 Apr 2026 18:58:33 -0500","X-Gm-Features":"AQROBzCSqxb7UrXES82np52thvNKKuicFFDAsnSczdEkb-GEFf4ev_ygkXuBAAs","Message-ID":"\n ","Subject":"Re: [PATCH] smb: client: scope end_of_dacl to CIFS_DEBUG2 use in\n parse_dacl","To":"Michael Bommarito ","Cc":"Steve French , Steve French ,\n\tPaulo Alcantara ,\n Ronnie Sahlberg ,\n\tShyam Prasad N , Tom Talpey ,\n\tBharath SM , linux-cifs@vger.kernel.org,\n\tsamba-technical@lists.samba.org, linux-kernel@vger.kernel.org,\n\tkernel test robot , oe-kbuild-all@lists.linux.dev","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]