Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2223723/?format=api
{ "id": 2223723, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2223723/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416014928.1279360-10-jamin_lin@aspeedtech.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260416014928.1279360-10-jamin_lin@aspeedtech.com>", "date": "2026-04-16T01:49:47", "name": "[v3,09/17] hw/usb/hcd-ehci: Implement 64-bit QH descriptor addressing", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "879eb41c5fb93fefd0a02d4a4e8349611c963905", "submitter": { "id": 81768, "url": "http://patchwork.ozlabs.org/api/1.1/people/81768/?format=api", "name": "Jamin Lin", "email": "jamin_lin@aspeedtech.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416014928.1279360-10-jamin_lin@aspeedtech.com/mbox/", "series": [ { "id": 500066, "url": "http://patchwork.ozlabs.org/api/1.1/series/500066/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500066", "date": "2026-04-16T01:49:32", "name": "hw/usb/ehci: Add 64-bit descriptor addressing support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/500066/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223723/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223723/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=aBGTts1H;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx1Jr2x14z1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 11:54:04 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDBsQ-0008KB-9G; Wed, 15 Apr 2026 21:50:42 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wDBrr-0007wS-V6; Wed, 15 Apr 2026 21:50:15 -0400", "from mail-japaneastazlp170120005.outbound.protection.outlook.com\n ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wDBro-0007PV-En; Wed, 15 Apr 2026 21:50:07 -0400", "from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by SEYPR06MB6202.apcprd06.prod.outlook.com (2603:1096:101:c7::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Thu, 16 Apr\n 2026 01:49:47 +0000", "from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9818.017; Thu, 16 Apr 2026\n 01:49:47 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=jd7FJQjJsuvLjurSnFOYcFgXbfrdKnmhr6KzuAvUzhZPmnvqzCBn8blNaHw0YngnEWB/+hJQ4qXxj12gZKKgW+1w64k8tIm4afTNCiNhtu9rrUClbdNFk7YCxyDh9uRW32EHGPZ6KcmgPNuAL/L98doET4sAw1uMIXDHYTlPcjjPJLfd1cvMcyXL/LpquzWBVpeMZuQTbgbd6HreEA5GlUzTtjUkHOpSVlyWh8wKmHqjDOXzbats8chajvS1MANv+b/ruGR+EPLGFLsUV1bQMwMqoNiiYJaR6Rj6RHqb+PyoQjR2UkntrMFYLZ9NRox5vfoez6p36QesAvlz2nfnhA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=r4q66hhwagZTZEGQGqaAV0ODyaTqZRm0o8unDJhfnVw=;\n b=vohrSfcEzA2z3opXXxw99gWdYPQ/o5C7G1wlxvQjG56vk39xik/PZf7Z1XQBi0TZ5+gzSt+ms3gJWl/bIzAL1QS7wxIWHqRhBbDf1PZxu+zPOgP8t2K1QmqBHApXonm73vARfBoKWjGoAdPKjukhgCth4/PU8hnl0Z9Sg0kfWCvgDUyW9v+zdznqnMFFpwNfyH2WHjabt+savyrfc/eGw+M1HyqDtQr9ckuwitQrjuwmsoVuFIZtm1ER837mIQ4V8oJWgwFOxAAhGfx0KYoTRPB64GdNtNYJBcVmvORnh9WtXuhyYTW3N93lXcmFPk0W1P4IT/74gGxIowqKiP88aQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=r4q66hhwagZTZEGQGqaAV0ODyaTqZRm0o8unDJhfnVw=;\n b=aBGTts1HzdDNZMVE3W7s9dkvUmj81b+kBfftfPKIm784eRibY/TyTqb+wOqoPV7Kfg9DX7ZrcREsVnBf0EThFzmuChQfe2IGm8KOe8MhxK+8UODJamhOoaC4DLgg4ACmWB7MAGcvJy4BtbJGGNrKgp/u4ZoX2WbkjKZar48XzPPznoHpir5DDkpMCR7OrUgLXW8HVCBxFZD3ZtFkpbZ0lbHZhjNTEURZzUrK30ILZF1LVA+bue+G2dP6qH4cf47M5J+43En6725NPR6iW9rUapCz2n4MN/g5TAPCbDzgynKUHdNrEoPjdNGXcz5PYaRU0xBzRhpdBGlYXMM8a0j9sg==", "From": "Jamin Lin <jamin_lin@aspeedtech.com>", "To": "\"philmd@linaro.org\" <philmd@linaro.org>, =?iso-8859-1?q?C=E9dric_Le_Goat?=\n\t=?iso-8859-1?q?er?= <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Kane Chen <kane_chen@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n \"open list:ASPEED BMCs\" <qemu-arm@nongnu.org>,\n \"open list:All patches CC here\" <qemu-devel@nongnu.org>", "CC": "Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>,\n \"flwu@google.com\" <flwu@google.com>, \"nabihestefan@google.com\"\n <nabihestefan@google.com>", "Subject": "[PATCH v3 09/17] hw/usb/hcd-ehci: Implement 64-bit QH descriptor\n addressing", "Thread-Topic": "[PATCH v3 09/17] hw/usb/hcd-ehci: Implement 64-bit QH descriptor\n addressing", "Thread-Index": "AQHczUNObou9Fmh1/EmYf55F3wvnKQ==", "Date": "Thu, 16 Apr 2026 01:49:47 +0000", "Message-ID": "<20260416014928.1279360-10-jamin_lin@aspeedtech.com>", "References": "<20260416014928.1279360-1-jamin_lin@aspeedtech.com>", "In-Reply-To": "<20260416014928.1279360-1-jamin_lin@aspeedtech.com>", "Accept-Language": "zh-TW, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=aBGTts1H;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "TYPPR06MB8206:EE_|SEYPR06MB6202:EE_", "x-ms-office365-filtering-correlation-id": "b25839cc-6422-42e9-027a-08de9b5a709d", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;\n ARA:13230040|376014|7416014|1800799024|366016|38070700021|921020|18002099003|22082099003|56012099003;", "x-microsoft-antispam-message-info": "\n IiwCKg3epFVNUP5jwriFbswYEN40LV75vlirYKw9bhKTeQAhUXL1IJJfdY/JJOP1Izj/wp9X2EMS9fspXruPDe0+pOluMgbdnU7RS+fvb4b3INMLa7sLkk7Po/OgTtkPOAq/xzhpqs7Z68vXxrsfgkXeE4DhO+93F71WJSvgskkr5rLoX6V4soYS7VlLw9niO1viI7uJft6RJphaiTGsuOmKHlhla3HlYtqBTNXhxHbRYa4pSngcFV7PynjVssyLxT316KVJxKyOZZ9CAiblzadoblrutryB8QkrgARD0I0A1WZv6CkzqvfA343TFy55oXdhU3A3sBDtZZKu5K2/ZQEpHcJWEW4jCbhdKI++yMaujdESoxThT4ILUEfiMyFd0F17iIq+jzAgHYbkZIgXxg2uJvMFUV9Om5i1JWAL1HAXS3XNabit+rOXu9k/1NK+OBeaVavpnk1sFZpk1xUNGRtn5hqhIgBCPU8lwGLH+1V1/6BzEScWi+/SI8dEoTiYY22Lny1LbCJ0l4fopVyH8EIAKszMU0DB9Iv1zQlBHTHMyOMbC3UG9GoPaeyTLEol+6jYnab8n+acHvKm9wsFLsV/NOpmrK+qj76M7BuXtCJs8vZkTGzEZ9ARMn2D8WjgmoUZt9kIT75+Yc+cNSEC1+d/rjfxyWqFAZqA6LdtHO55SHQV5BFjYhyemJObGRYUmVzxuZAwupbBuXXeu1NTJPiDS2YHFBM6G8B5ELiAcEUk3CjRk6Dk5n0XdfT51j4aBMu3Ewcc/EXL1gKcGZOx/kYssdzJ09LI3wy9NBUNTHXJrB6P6rOEN/NQnRnsqqEQ", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(1800799024)(366016)(38070700021)(921020)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "=?iso-8859-1?q?SILt1dXYKWb2aPUXrWabku+?=\n\t=?iso-8859-1?q?zCUtXHSYMK0pY2LtK0WqWYyUulrZAisvgPtFS2HW01RPWJAkuCMXibC+RiM4?=\n\t=?iso-8859-1?q?oICJtCf5my30rXEFKtWkCQpvgw+xiQqGlSJgmTjm1rZlRACBEPu7vJBYtYOp?=\n\t=?iso-8859-1?q?IXTsKoAM5TFHNYPM1x+odwoWORozYQ7362GKQQ7rKi3YipF+9IN0+Nk6c4Vc?=\n\t=?iso-8859-1?q?LE4EWd5VJyjGQBU415TJLoQ4zo4VqzxplPtKjOgmvda5q3dozFKBxI7HsgbP?=\n\t=?iso-8859-1?q?mzoLm4MOR00HIbVonaoW4OI+WjCFtgXDSmvK6qmHLX4RIuJU09YdBo6HJudp?=\n\t=?iso-8859-1?q?pscq9Ec+jtKoMju1xEPbmWyF7N4LAFJeS12YmGDRvFb3k6/IrWUAh9iy0mas?=\n\t=?iso-8859-1?q?Tgosq2eZZvxmgNcE+JHFDdPTmiQe7OJ3gaKBmex8x+hUXMlzWcRISvMuZEUL?=\n\t=?iso-8859-1?q?brv8THwIR5bvmU9YEBSYQTnvk13ROcaSLt77ddGSckebcPZ+9hG8yJVZh5iW?=\n\t=?iso-8859-1?q?dQ42QHoQxg8YeUhkHrNG+jqofSyIysTdLlyYy4dCqco8/s/I8l4VakxrIA3V?=\n\t=?iso-8859-1?q?ECEtMmtmgCfFEkoCZ7SQRV0Mz1f9jHBuRHdxa/wdtyQvR6YkY5DnTzB5Vn69?=\n\t=?iso-8859-1?q?0pv0X66jqtZnF6bErQVPDgSuTtQr1QkmoxlOWL2SR8BrNhcgF7KwMRGhJWl0?=\n\t=?iso-8859-1?q?KZXJ7evU04niuDWmW+4U6GVQgL3DaydS4jXRWu7r+DF9FHhINwCcv3/I7KcV?=\n\t=?iso-8859-1?q?znHK0R2+vYze7avu5OGA1BYH9ocdix6T7DBSfcjTv0PtIyWNw6slAKCsGDXL?=\n\t=?iso-8859-1?q?yomPsasoOn4CltRDkMpslnQ0dUTlhsLCTAFtTKhBdk4h0xOK1cHO1gatLUAj?=\n\t=?iso-8859-1?q?9+fz+Ek0lzZi1kUg81wDr3wi/o+txfpjL6z7i0kW1xwILkCVyP6qb/XuhKWi?=\n\t=?iso-8859-1?q?kh/WKmrPLqgqerVmeWBfmtZfWP+Fu+57aZP9rubl9uico3pRVwwYtk9tzBiP?=\n\t=?iso-8859-1?q?o+ejwLA+o+P07Q2RvVvGVt/LBhajXk2MtDyRfl+n5DyMBjM0ooCib3+NIigJ?=\n\t=?iso-8859-1?q?UhbevuksY2mIwWRTpOSPbXvesMWvcOyejURV601IIoCC9ETizpOgwKSphKsX?=\n\t=?iso-8859-1?q?DYHObRvUAJ+FLK+dOa1/XDoXf4L2Az3ie//e6Gei9o50qlhfp8VsSd/MHvQX?=\n\t=?iso-8859-1?q?wNcNMCRsBDAkK1NsWID2VCFStMkGeJY1S9+y5iVxXZg934y+t5VraerFR8KH?=\n\t=?iso-8859-1?q?6ojoifVWFRhWzQflHG++LSxySsHcI5DvgefXDB5AvinOTx2gQMDaAYqwooqw?=\n\t=?iso-8859-1?q?WBYC/KEBkFJ+ykOmbY4PqxP5Bf5wgRarFGWLpZaWXFIQLCD7sGQvUMkYWNPL?=\n\t=?iso-8859-1?q?irEe2Blt58XODkf3X2GP2KRYiWBegzRb/JGMp3TZl60cfImxWOmj7W37OfFP?=\n\t=?iso-8859-1?q?zZ+LKahljPiqC2UY+OwjTkh6IrX9esqOqSidWcUujK6mzfxHPqsQEEl+UpnC?=\n\t=?iso-8859-1?q?aCnpSDXDgrT/1dTf3jimd9+v7f1KDQ7kUdFdnbASdG0qSU5egQstxYlLsp4p?=\n\t=?iso-8859-1?q?FGGu307zjXpOdm0UIo7NTX7UEfQ1H5E1skreUXRIU9yvXeBL3YbxHRsDx0Wj?=\n\t=?iso-8859-1?q?lVBWg8JkG/vZ7Pw0WUGJFsfmye6IHxGu7ZnLEH8JAwxBBZWjCtnup9uFKySl?=\n\t=?iso-8859-1?q?h0/YuULR9Eaz57tK4XUsIk997h0glYSSHMvOHWwBWWTJ5umwZkPV+fdKZeLF?=\n\t=?iso-8859-1?q?XJ2DwjmMq1ZLle9aL0WdUSJKaWmx9bnkEh21SEGD3sDzhsg=3D=3D?=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-Exchange-RoutingPolicyChecked": "\n enSbhfOch9m/WoImIn7PrdAvPe2xD4MxYBv47twP7QJeagmKVOLSMvjlq84Hki7ABkBBvq/IXhcTnq3PgKfBzQ9lQzre1INEjH9SSdd+MwPz3hSewpnc45C7JEbkLR8zOHoAEA1MetAylOiRvwI8JrWFgI4MPfLhlWOqwuT68s/+T4FKK2XsLUpNdFfLs/lM/T8VD9lOH1i/p7ADfuy/2VDTLVax2q+6ANRYyqNo1djzYu83DX+rIDIxS/hm9oUVDA78BCp7CU/scxwzCc7wyOr48nk2x8Ljc70UxTtrtF420akdMzK2XjWTUAMiWv3LsytPwEmIS9V8F9pVHWucTQ==", "X-OriginatorOrg": "aspeedtech.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "TYPPR06MB8206.apcprd06.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b25839cc-6422-42e9-027a-08de9b5a709d", "X-MS-Exchange-CrossTenant-originalarrivaltime": "16 Apr 2026 01:49:47.1488 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "43d4aa98-e35b-4575-8939-080e90d5a249", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n 1Pnnl/6KMdG47rXMiKXJrZOdeAKe4/gGu6WBoY6suQ3Ix02Q0PgCiAzQGZ91AVuA9E5fuRvBYeSP4VDKYFXGV+Ixi+V9T28f4CKwY1nUsIc=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SEYPR06MB6202", "Received-SPF": "pass client-ip=2a01:111:f403:c405::5;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=TYPPR03CU001.outbound.protection.outlook.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "EHCI supports 64-bit control data structure addressing when the\n64-bit Addressing Capability bit in HCCPARAMS is set. In that mode,\nthe CTRLDSSEGMENT register supplies the upper 32 bits which are\nconcatenated with 32-bit link pointer fields to form full 64-bit\ndescriptor addresses (EHCI 1.0, section 2.3.5 and Appendix B).\n\nThe current implementation assumes 32-bit QH descriptor addresses\nand directly uses link pointer values without applying the\nCTRLDSSEGMENT upper dword.\n\nIntroduce a helper, ehci_get_desc_addr(), to construct full 64-bit\ndescriptor addresses when 64-bit capability is enabled. Update QH\ntraversal paths (async list walk, horizontal QH link, and periodic\nschedule entry handling) to use the translated 64-bit addresses.\n\nEHCI 64-bit buffer pointer fields are defined in Appendix B as\nsplit 32-bit low/high parts located at separate offsets, rather\nthan a single contiguous 64-bit field. Therefore, the buffer\npointers cannot be represented as uint64_t bufptr[5] without\nviolating the descriptor layout defined by the specification.\n\nIntroduce ehci_get_buf_addr() to construct full 64-bit buffer\naddresses from bufptr[] and bufptr_hi[] fields. Use this helper\nwhen calculating transfer buffer addresses so that data buffers\nabove 4GB are correctly handled.\n\nAlso add bufptr_hi[5] to EHCIqh to support 64-bit buffer pointer\nfields as defined in Appendix B.\n\nWhen 64-bit capability is disabled, descriptor addresses remain\n32-bit and existing behaviour is unchanged.\n\nNote: Similar split 64-bit buffer pointer handling is required for\nqTD, iTD and siTD descriptors, which will be addressed in follow-up\nchanges.\n\nSigned-off-by: Jamin Lin <jamin_lin@aspeedtech.com>\n---\n hw/usb/hcd-ehci.h | 4 ++++\n hw/usb/hcd-ehci.c | 48 ++++++++++++++++++++++++++++++++++-----------\n hw/usb/trace-events | 2 +-\n 3 files changed, 42 insertions(+), 12 deletions(-)", "diff": "diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h\nindex fe4c508c32..773f376834 100644\n--- a/hw/usb/hcd-ehci.h\n+++ b/hw/usb/hcd-ehci.h\n@@ -141,6 +141,9 @@ typedef struct EHCIqtd {\n #define QTD_BUFPTR_SH 12\n } EHCIqtd;\n \n+/* QH overlay: altnext_qtd, token, bufptr[5], bufptr_hi[5] */\n+#define EHCI_QH_OVERLAY_COUNT 12\n+\n /*\n * EHCI spec version 1.0 Section 3.6\n */\n@@ -194,6 +197,7 @@ typedef struct EHCIqh {\n #define BUFPTR_FRAMETAG_MASK 0x0000001f\n #define BUFPTR_SBYTES_MASK 0x00000fe0\n #define BUFPTR_SBYTES_SH 5\n+ uint32_t bufptr_hi[5];\n } EHCIqh;\n \n enum async_state {\ndiff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex b9e4251d62..37ae637e08 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -147,6 +147,24 @@ static const char *addr2str(hwaddr addr)\n return nr2str(ehci_mmio_names, ARRAY_SIZE(ehci_mmio_names), addr);\n }\n \n+static uint64_t ehci_get_buf_addr(EHCIState *s, uint32_t hi, uint32_t low,\n+ uint32_t mask)\n+{\n+ uint64_t addr;\n+\n+ addr = (uint64_t)(low & mask);\n+ if (s->caps_64bit_addr) {\n+ addr |= (uint64_t)hi << 32;\n+ }\n+\n+ return addr;\n+}\n+\n+static uint64_t ehci_get_desc_addr(EHCIState *s, uint32_t low)\n+{\n+ return ehci_get_buf_addr(s, s->ctrldssegment, low, UINT32_MAX);\n+}\n+\n static void ehci_trace_usbsts(uint32_t mask, int state)\n {\n /* interrupts */\n@@ -440,7 +458,7 @@ static bool ehci_verify_qh(EHCIQueue *q, EHCIqh *qh)\n (qh->current_qtd != q->qh.current_qtd) ||\n (q->async && qh->next_qtd != q->qh.next_qtd) ||\n (memcmp(&qh->altnext_qtd, &q->qh.altnext_qtd,\n- 7 * sizeof(uint32_t)) != 0) ||\n+ EHCI_QH_OVERLAY_COUNT * sizeof(uint32_t)) != 0) ||\n (q->dev != NULL && q->dev->addr != devaddr)) {\n return false;\n } else {\n@@ -1536,7 +1554,9 @@ static int ehci_state_waitlisthead(EHCIState *ehci, int async)\n EHCIqh qh;\n int i = 0;\n int again = 0;\n- uint64_t entry = ehci->asynclistaddr;\n+ uint64_t entry = 0;\n+\n+ entry = ehci_get_desc_addr(ehci, ehci->asynclistaddr);\n \n /* set reclamation flag at start event (4.8.6) */\n if (async) {\n@@ -1564,8 +1584,8 @@ static int ehci_state_waitlisthead(EHCIState *ehci, int async)\n goto out;\n }\n \n- entry = qh.next;\n- if (entry == ehci->asynclistaddr) {\n+ entry = ehci_get_desc_addr(ehci, qh.next);\n+ if (entry == ehci_get_desc_addr(ehci, ehci->asynclistaddr)) {\n break;\n }\n }\n@@ -1691,7 +1711,7 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci, int async)\n }\n \n if (trace_event_get_state_backends(TRACE_USB_EHCI_FETCHQH_DBG)) {\n- if (q->qhaddr != q->qh.next) {\n+ if (q->qhaddr != ehci_get_desc_addr(ehci, q->qh.next)) {\n trace_usb_ehci_fetchqh_dbg(q->qhaddr,\n q->qh.epchar & QH_EPCHAR_H,\n q->qh.token & QTD_TOKEN_HALT,\n@@ -1868,10 +1888,12 @@ static int ehci_state_fetchqtd(EHCIQueue *q)\n \n static int ehci_state_horizqh(EHCIQueue *q)\n {\n+ uint64_t addr;\n int again = 0;\n \n- if (ehci_get_fetch_addr(q->ehci, q->async) != q->qh.next) {\n- ehci_set_fetch_addr(q->ehci, q->async, q->qh.next);\n+ addr = ehci_get_desc_addr(q->ehci, q->qh.next);\n+ if (ehci_get_fetch_addr(q->ehci, q->async) != addr) {\n+ ehci_set_fetch_addr(q->ehci, q->async, addr);\n ehci_set_state(q->ehci, q->async, EST_FETCHENTRY);\n again = 1;\n } else {\n@@ -2200,6 +2222,8 @@ static void ehci_advance_periodic_state(EHCIState *ehci)\n uint32_t entry;\n uint32_t list;\n const int async = 0;\n+ uint64_t entry64;\n+ uint64_t list64;\n \n /* 4.6 */\n \n@@ -2224,12 +2248,14 @@ static void ehci_advance_periodic_state(EHCIState *ehci)\n break;\n }\n list |= ((ehci->frindex & 0x1ff8) >> 1);\n-\n- if (get_dwords(ehci, list, &entry, 1) < 0) {\n+ list64 = ehci_get_desc_addr(ehci, list);\n+ if (get_dwords(ehci, list64, &entry, 1) < 0) {\n break;\n }\n- trace_usb_ehci_periodic_state_advance(ehci->frindex / 8, list, entry);\n- ehci_set_fetch_addr(ehci, async, entry);\n+ entry64 = ehci_get_desc_addr(ehci, entry);\n+ trace_usb_ehci_periodic_state_advance(ehci->frindex / 8,\n+ list64, entry64);\n+ ehci_set_fetch_addr(ehci, async, entry64);\n ehci_set_state(ehci, async, EST_FETCHENTRY);\n ehci_advance_state(ehci, async);\n ehci_queues_rip_unused(ehci, async);\ndiff --git a/hw/usb/trace-events b/hw/usb/trace-events\nindex 8c90688bb3..67249d69c2 100644\n--- a/hw/usb/trace-events\n+++ b/hw/usb/trace-events\n@@ -113,7 +113,7 @@ usb_ehci_dma_error(void) \"\"\n usb_ehci_execute_complete(uint64_t qhaddr, uint32_t next, uint64_t qtdaddr, int status, int actual_length) \"qhaddr=0x%\" PRIx64 \", next=0x%x, qtdaddr=0x%\" PRIx64 \", status=%d, actual_length=%d\"\n usb_ehci_fetchqh_reclaim_done(uint64_t qhaddr) \"QH 0x%\" PRIx64 \" H-bit set, reclamation status reset - done processing\"\n usb_ehci_fetchqh_dbg(uint64_t qhaddr, uint32_t h, uint32_t halt, uint32_t active, uint32_t next) \"QH 0x%\" PRIx64 \" (h 0x%x halt 0x%x active 0x%x) next 0x%08x\"\n-usb_ehci_periodic_state_advance(uint32_t frame, uint32_t list, uint32_t entry) \"frame=%d, list=0x%x, entry=0x%x\"\n+usb_ehci_periodic_state_advance(uint32_t frame, uint64_t list, uint64_t entry) \"frame=%d, list=0x%\" PRIx64 \", entry=0x%\" PRIx64\n usb_ehci_skipped_uframes(uint64_t skipped_uframes) \"skipped %\" PRIu64 \" uframes\"\n usb_ehci_log(const char *msg) \"%s\"\n \n", "prefixes": [ "v3", "09/17" ] }