Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2223720/?format=api
{ "id": 2223720, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2223720/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416014928.1279360-6-jamin_lin@aspeedtech.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260416014928.1279360-6-jamin_lin@aspeedtech.com>", "date": "2026-04-16T01:49:40", "name": "[v3,05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with trace events", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9b76643968f0cc9912afe985d74fbebfb3fc9f54", "submitter": { "id": 81768, "url": "http://patchwork.ozlabs.org/api/1.1/people/81768/?format=api", "name": "Jamin Lin", "email": "jamin_lin@aspeedtech.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416014928.1279360-6-jamin_lin@aspeedtech.com/mbox/", "series": [ { "id": 500066, "url": "http://patchwork.ozlabs.org/api/1.1/series/500066/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500066", "date": "2026-04-16T01:49:32", "name": "hw/usb/ehci: Add 64-bit descriptor addressing support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/500066/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223720/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223720/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=ervodXUb;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx1Hv6J9zz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 11:53:15 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDBsM-0008I5-VK; Wed, 15 Apr 2026 21:50:38 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wDBri-0007rc-Ct; Wed, 15 Apr 2026 21:50:03 -0400", "from mail-japaneastazlp170120005.outbound.protection.outlook.com\n ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wDBrf-0007PV-Sf; Wed, 15 Apr 2026 21:49:57 -0400", "from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by SEYPR06MB6202.apcprd06.prod.outlook.com (2603:1096:101:c7::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Thu, 16 Apr\n 2026 01:49:40 +0000", "from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9818.017; Thu, 16 Apr 2026\n 01:49:40 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=IbHxWUkSuwTHrhvAtfH81nBmWjXDWA/1pN2sjY/OVEoJLw9DCHotbuGDelHUA/Ots26WTNgxCAY9StxbmG/TjMjH3X7bqNMeBm0gQuhjrrlqBUe6ocix8ZfTPjGib5t9aiqtHy6AejwFqs1JlcPdDU4l/mWubysfImED8josdCZc+qZNUDpRjJaWpWvJFRbRN1VCV9sW9B5PTHRLgFp42QAfQCw4PmSgQOeYe3mewQvA2z1wq27NyySWMA1wuc0CVV6yMNdpWyu9jse1rMCDb7TMu+n9sLuNPTYOCz+r+9enkdV3O4aZmrYf3d365mf76i6LcTyelMy3151SCFSKrA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=H6usZ5mXShBCQUWpF5kXm4oFlG2iJBMpiedjEUoqbNs=;\n b=QbFNZXwLDKw6qWw6i3A7d8xAHrvZLnTrb4UB//Ez5Cqnh/bkygDrVMpn0BzX3sF/tfRmtHzRbAJw3hmw4+JW+MekBfMBmAtmO1W/pNcEb7kiSzvrZq1JQwO0W1gpm9caTScAtWArZgtnf5MhMRrisMNIMzEg4miWomEyjFY0PJpcchj9v9ec82Au5OawHBTdU6ecjB2CP3eaxnJs0zQ83zupSNwF6aFJ7wBlElwuHgGqHw+FdrVVwdf/I1Y19kDwgR+jc3tkaeEm6yKj2PIIcc9Uo3JltnuzP88NJ/Fpi4O3gnyMEZuoq9ejP12W3KDUcbQq+eZXsSr51Potv2gf1w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=H6usZ5mXShBCQUWpF5kXm4oFlG2iJBMpiedjEUoqbNs=;\n b=ervodXUbBeuYKLlen/c8b8D9o/azBmuYA+UEDcuHH/C+4gbRD2zGTkbvXBs0ZF1DTY9cEVxln/XArPD6EpuGGuOTKslpc6Hk0WUM7LeRUioJMNzTstxT5tsWd/XqNLJcyp4OcsJtoP23O5Jsm3K+Aiw+9HDW7bezqOFQ7vpS38wRVIqQBurij5s3C1ujDjq8Hu+8uwATVoWK3MQwrXOPvukBgeKtGINo2SAOoLQisWuwLPPjA/GxxI1PwK8JkAa7QD5FIhXN1T0PfTR2Q3SpH+c2/2Pm6Am8p8BbMyItUk+yKLW8g4wcD2KCpZHzHKfZS+7wjGgPjRtErTwS1TVGAA==", "From": "Jamin Lin <jamin_lin@aspeedtech.com>", "To": "\"philmd@linaro.org\" <philmd@linaro.org>, =?iso-8859-1?q?C=E9dric_Le_Goat?=\n\t=?iso-8859-1?q?er?= <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Kane Chen <kane_chen@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n \"open list:ASPEED BMCs\" <qemu-arm@nongnu.org>,\n \"open list:All patches CC here\" <qemu-devel@nongnu.org>", "CC": "Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>,\n \"flwu@google.com\" <flwu@google.com>, \"nabihestefan@google.com\"\n <nabihestefan@google.com>", "Subject": "[PATCH v3 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with\n trace events", "Thread-Topic": "[PATCH v3 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs\n with trace events", "Thread-Index": "AQHczUNJbYaidtPzU0Ws/JExGfVqVQ==", "Date": "Thu, 16 Apr 2026 01:49:40 +0000", "Message-ID": "<20260416014928.1279360-6-jamin_lin@aspeedtech.com>", "References": "<20260416014928.1279360-1-jamin_lin@aspeedtech.com>", "In-Reply-To": "<20260416014928.1279360-1-jamin_lin@aspeedtech.com>", "Accept-Language": "zh-TW, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=ervodXUb;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "TYPPR06MB8206:EE_|SEYPR06MB6202:EE_", "x-ms-office365-filtering-correlation-id": "c787422c-d8f6-42b1-e3f9-08de9b5a6c60", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;\n ARA:13230040|376014|7416014|1800799024|366016|38070700021|921020|18002099003|22082099003|56012099003;", "x-microsoft-antispam-message-info": "\n prom7BlHFqaAtwo1pQeajI/ZNjwWUsgOthBJ2Lx6bjViHBeHBce7S8tdtAj58KqX0R9Xkw/SsY6B1f3N7AazX0R1PNo0wkWS+TCZIWb5EhYbXJ70LMk/I9+cf21geabINU+fi50DRS8ANslX8tPTea+xIMc4U9sOq5DGFCobBNrM+wpAb6XsvHd3BqvtYhLv7t5wMJYOiA3YV59zcvGF6QZHkFcFBzmmKdcbmKqvzrbq/G+xxcmfOw/vC3gRPlzjjA+zuVdi7WVKphuFFaZild6a3oTDmx5m8ZTLSUs+Q+DmLHXozCsNjGIzVz+diNoWm/kYIGS3RQqOx3SK+s3dXf/RCzCTNo2Wo/VisiyI7V7O9RZ1ULdDJs1NKqa0ig0VmyAC/ZDgsgo0CrMfUAGZprkJC/eAqQ5gRaeQ6Qf1ftJ+hQ7DHMzATZDTNhGyfoK92fbj2x3Nxx3bfOZjdGjGFUCt3zID+zGQziwe0sLYQ2zHaIf9n1zFibMNcRvTmnjhUMGOQ8dmbP/mIc47WaodhnsTikPkJ1Kfr3rhpN0stv2hGe8DMPTKKx+iPZUKTPsCV+2rQSSfYp0XF+UbD2cG5RBczzGYkhm2Weg35kTBXzttnkeV5aDhqThi5vcOphdzrAQeqHX0OiN0QPd4TqNhqYbqLi2/aSPbJUSfL9MJJ0dgFVtjmSs89LhWlIeyRZkZG9U8ufBnjOJwkVdfr34rMK+UXpj1Du1qkpI5RtsRpKic3ubsXPieS6nKpStfTXEaPSuFjtLBFM3NvGCBHiSnJqEvSes/jH1+nnrIyIRHHGSeytpz7Cf1l7uq8vlPO+tm", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(1800799024)(366016)(38070700021)(921020)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "=?iso-8859-1?q?oMpOg9eOrUnN1/W0g10WvWc?=\n\t=?iso-8859-1?q?T3IA8Lz1/WqQHLQhF5iKLXGHKOkntnhWItdrp/1hb2tBJ2k09mvfITszvNkQ?=\n\t=?iso-8859-1?q?0F1t/tB4IE4v5gmhD33pKTM9I6aXJ5YAcXo7ImhPeTCG+AQ8L6y3j7y454sH?=\n\t=?iso-8859-1?q?cSeaT05NMwbvtqsPDpdVAKO6xinfVwlEKiGWb39lLvdKxhXe6xmxoMaSQLxV?=\n\t=?iso-8859-1?q?YjrNGnKyZn0h4MUkTCpaq6iyMdlCdfZafuvDNx7jzIAo6G93sD+8uep2MAuM?=\n\t=?iso-8859-1?q?t/SGLqdmKvaUFoG1MjtGz9Yke88+OSs0IvBsxHWSjrnUyzLk3KqXlPLolnFQ?=\n\t=?iso-8859-1?q?zksiAXRtmYMBzYtBItVvE8pSkMamx+YM/nLh1a3UWfy8ny37jaLerJWsJjWQ?=\n\t=?iso-8859-1?q?quuWJwbI5YugMOyDo8PpcXgDB2m0Lh2jtHXoRDCXw9Xu5IxlDPZcs8AsElXI?=\n\t=?iso-8859-1?q?UeZe0Iv/GdossIs606I8wOw6uo+jZNcygZij94R1yEe/HrytGFXZJJkqAzx9?=\n\t=?iso-8859-1?q?vqyUOEPcEtGU1SzXHH+itK3CsqmxopudyJG8N08eCrCJZG5EVA8qUZij4YO6?=\n\t=?iso-8859-1?q?UVN0diihE6LO6V0XfwMEyWEshk935iJ2V8FH1l9INnQKXrpbUR1AkE8awI3N?=\n\t=?iso-8859-1?q?w3qbDoBTgumGedvCJzuzFJF4dfljvtHiVdDRjQPYZm+wkXZ0F8y7VQx4LqKu?=\n\t=?iso-8859-1?q?dGewy6bhf1YnKGP1rVx/T8u9dFvbdvPoNlP2+yGpmAxm9X5JPY9XqQjwdjIt?=\n\t=?iso-8859-1?q?i+6C5vhvTB0zKxwKeOJ7SpFtqQK78mLYMlAhnLO8zzu33zzbfDG1Nd7zbi3u?=\n\t=?iso-8859-1?q?nY6hhIU1YMbIKzDz7wGnKX3uEl5vMWE59GXU0p6U5yfEYkNwUmuIF/QlWczL?=\n\t=?iso-8859-1?q?1093KFUoCJEhw3wUEER/cYYezcSg+yNb72kTJlUw8Topj803i66u0A2iXz8Y?=\n\t=?iso-8859-1?q?JarCyvBh2wPsIG4FsFqIXE+n3UUyCZ58STBCSYgzeDVBHwb8k0taJgKbLUwu?=\n\t=?iso-8859-1?q?g4yZxYfIbSrtr85rCyr78V9EPhZ40FdRt0zCb/otvUujAMmDza4seaZUrpxz?=\n\t=?iso-8859-1?q?LrLN0ltGB8NuUzKP0nKQ6p16YohrqknWs7meMJotUhUc8yLVni3WOL9Pr9wP?=\n\t=?iso-8859-1?q?LVmtSGlxkhKFlpM+ETGErZn7J3JFNiAVWivlLTQJZOXf+0esqpaJGqANtgpr?=\n\t=?iso-8859-1?q?hvFaJ9gOEQjjPS57LfVsKAAZ5woeCTxhbJ58GG1xWdHoV/8VLZxf6oooTLUL?=\n\t=?iso-8859-1?q?SMh5DsE4rNegZgRuq6Yk2Kk7F7/aQGn4MFNZL+Bvd98big9sz5OddtdJ+wJ2?=\n\t=?iso-8859-1?q?6R0wjnVDJRv1n3tQzyLwaeCm7iq9SrFiqlYp4aBHIVDCVlGNxMvCDkgD0aKu?=\n\t=?iso-8859-1?q?3p158ayfmJ17ZCfQLJJcAdji5p8Y46hwdkXu3h3eC/qA+qMacZtT0cY8lwi4?=\n\t=?iso-8859-1?q?eU9TNW3wfej7OIvpokltyJQngXvkTzdxFwSJbcI11+ibtznV5gKSad+MXol8?=\n\t=?iso-8859-1?q?9aNqqWqz5W4cvEWgmVNCtngPN/H1eQhwYlZoeBiMT7t2O3LzXD7xKx2ENl7W?=\n\t=?iso-8859-1?q?v/14BOXo9UXzwZ7woWhUevwGYm6eNicEuZThk/w2LCptP9Fpi47VPTtlnte3?=\n\t=?iso-8859-1?q?FKAibsi0OkyplugmGV0lRVDtcX4Z9qvzSboRjh7E/pQOLOl+3LfTDX7puDJ4?=\n\t=?iso-8859-1?q?2JFpQ7eJ2wsAEpBkutjmp4w4OVkiBj1lfi0qpxSRDHTDQ+q7n6Etg4IRmT6l?=\n\t=?iso-8859-1?q?Zw/o3NRB0C/udA3/3BiVorJX99ErNE4GCKf4e++3uiivWoA=3D=3D?=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-Exchange-RoutingPolicyChecked": "\n WmXLzu/AKjGEAnXo03LigglsocyC3tNa/Sz4KW/1C8dqIh4fA6RZpguO6vqQHqGu1bnOtlpZ39DVIFI2MUbRx+SRKKndVGiN1vPZk17+cEHgK+t8q6NcUP+n4b9G30S8U52awM8GlsaFijaNaqhObqczqYqDISH1M3rDVa83RecNyI+EOCRqb0FGwA+YkFc2cErBkrKlCR/4Z0dyYbh6YNrlQ081kAcWplcDmsX+7eq3lNiPMD77pjVRNqXd7z5FkIyb3r+MIpaIYqd2e1lM7Jy+5ZBulFMnExaKLoPKYCQyJJAp/xgSiua0ZsfmitOjZYNtZ3N1R/BgscKkxJN4ag==", "X-OriginatorOrg": "aspeedtech.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "TYPPR06MB8206.apcprd06.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c787422c-d8f6-42b1-e3f9-08de9b5a6c60", "X-MS-Exchange-CrossTenant-originalarrivaltime": "16 Apr 2026 01:49:40.0490 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "43d4aa98-e35b-4575-8939-080e90d5a249", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n Nm23u4DDjozNLHmNCfLfPpnw0SRnCbfvzX/KtavHKM/gWIJGpqlZ41ZpH29CZQ5SmW1dsrDn9P0FgoeoK7QwUeOJd5Y8R621K3y8vdslD6k=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SEYPR06MB6202", "Received-SPF": "pass client-ip=2a01:111:f403:c405::5;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=TYPPR03CU001.outbound.protection.outlook.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Replace legacy DPRINTF() debug logging in the EHCI host controller\nimplementation with QEMU trace events.\n\nThe EHCI_DEBUG macro and associated DPRINTF() definitions are\nremoved as they are no longer needed.\n\nTrace events are added for:\n- packet submission and completion\n- queue head execution state\n- periodic schedule advancement\n- ITD error conditions\n- port state handling\n- skipped microframes\n\nNo functional change.\n\nSigned-off-by: Jamin Lin <jamin_lin@aspeedtech.com>\n---\n hw/usb/hcd-ehci.h | 10 ---------\n hw/usb/hcd-ehci.c | 49 +++++++++++++++++++--------------------------\n hw/usb/trace-events | 9 +++++++++\n 3 files changed, 30 insertions(+), 38 deletions(-)", "diff": "diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h\nindex 736407fd52..4234591cb4 100644\n--- a/hw/usb/hcd-ehci.h\n+++ b/hw/usb/hcd-ehci.h\n@@ -24,16 +24,6 @@\n #include \"hw/pci/pci_device.h\"\n #include \"hw/core/sysbus.h\"\n \n-#ifndef EHCI_DEBUG\n-#define EHCI_DEBUG 0\n-#endif\n-\n-#if EHCI_DEBUG\n-#define DPRINTF printf\n-#else\n-#define DPRINTF(...)\n-#endif\n-\n #define MMIO_SIZE 0x1000\n #define CAPA_SIZE 0x10\n \ndiff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex bebd137f94..d0ea4949f9 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -839,7 +839,7 @@ static USBDevice *ehci_find_device(EHCIState *ehci, uint8_t addr)\n for (i = 0; i < EHCI_PORTS; i++) {\n port = &ehci->ports[i];\n if (!(ehci->portsc[i] & PORTSC_PED)) {\n- DPRINTF(\"Port %d not enabled\\n\", i);\n+ trace_usb_ehci_port_disable(i);\n continue;\n }\n dev = usb_find_device(port, addr);\n@@ -1281,10 +1281,8 @@ static void ehci_execute_complete(EHCIQueue *q)\n assert(p->async == EHCI_ASYNC_INITIALIZED ||\n p->async == EHCI_ASYNC_FINISHED);\n \n- DPRINTF(\"execute_complete: qhaddr 0x%x, next 0x%x, qtdaddr 0x%x, \"\n- \"status %d, actual_length %d\\n\",\n- q->qhaddr, q->qh.next, q->qtdaddr,\n- p->packet.status, p->packet.actual_length);\n+ trace_usb_ehci_execute_complete(q->qhaddr, q->qh.next, q->qtdaddr,\n+ p->packet.status, p->packet.actual_length);\n \n switch (p->packet.status) {\n case USB_RET_SUCCESS:\n@@ -1327,7 +1325,7 @@ static void ehci_execute_complete(EHCIQueue *q)\n } else {\n tbytes = 0;\n }\n- DPRINTF(\"updating tbytes to %d\\n\", tbytes);\n+ trace_usb_ehci_qh_tbytes(tbytes);\n set_field(&q->qh.token, tbytes, QTD_TOKEN_TBYTES);\n \n ehci_finish_transfer(q, p->packet.actual_length);\n@@ -1392,10 +1390,9 @@ static int ehci_execute(EHCIPacket *p, const char *action)\n \n trace_usb_ehci_packet_action(p->queue, p, action);\n usb_handle_packet(p->queue->dev, &p->packet);\n- DPRINTF(\"submit: qh 0x%x next 0x%x qtd 0x%x pid 0x%x len %zd endp 0x%x \"\n- \"status %d actual_length %d\\n\", p->queue->qhaddr, p->qtd.next,\n- p->qtdaddr, p->pid, p->packet.iov.size, endp, p->packet.status,\n- p->packet.actual_length);\n+ trace_usb_ehci_packet_submit(p->queue->qhaddr, p->qtd.next, p->qtdaddr,\n+ p->pid, p->packet.iov.size, endp,\n+ p->packet.status, p->packet.actual_length);\n \n if (p->packet.actual_length > BUFF_SIZE) {\n qemu_log_mask(LOG_GUEST_ERROR,\n@@ -1472,7 +1469,8 @@ static int ehci_process_itd(EHCIState *ehci,\n usb_handle_packet(dev, &ehci->ipacket);\n usb_packet_unmap(&ehci->ipacket, &ehci->isgl);\n } else {\n- DPRINTF(\"ISOCH: attempt to address non-iso endpoint\\n\");\n+ trace_usb_ehci_log(\"ISOCH: \"\n+ \"attempt to address non-iso endpoint\");\n ehci->ipacket.status = USB_RET_NAK;\n ehci->ipacket.actual_length = 0;\n }\n@@ -1675,24 +1673,22 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci, int async)\n if (ehci->usbsts & USBSTS_REC) {\n ehci_clear_usbsts(ehci, USBSTS_REC);\n } else {\n- DPRINTF(\"FETCHQH: QH 0x%08x. H-bit set, reclamation status reset\"\n- \" - done processing\\n\", q->qhaddr);\n+ trace_usb_ehci_fetchqh_reclaim_done(q->qhaddr);\n ehci_set_state(ehci, async, EST_ACTIVE);\n q = NULL;\n goto out;\n }\n }\n \n-#if EHCI_DEBUG\n- if (q->qhaddr != q->qh.next) {\n- DPRINTF(\"FETCHQH: QH 0x%08x (h %x halt %x active %x) next 0x%08x\\n\",\n- q->qhaddr,\n- q->qh.epchar & QH_EPCHAR_H,\n- q->qh.token & QTD_TOKEN_HALT,\n- q->qh.token & QTD_TOKEN_ACTIVE,\n- q->qh.next);\n+ if (trace_event_get_state_backends(TRACE_USB_EHCI_FETCHQH_DBG)) {\n+ if (q->qhaddr != q->qh.next) {\n+ trace_usb_ehci_fetchqh_dbg(q->qhaddr,\n+ q->qh.epchar & QH_EPCHAR_H,\n+ q->qh.token & QTD_TOKEN_HALT,\n+ q->qh.token & QTD_TOKEN_ACTIVE,\n+ q->qh.next);\n+ }\n }\n-#endif\n \n if (q->qh.token & QTD_TOKEN_HALT) {\n ehci_set_state(ehci, async, EST_HORIZONTALQH);\n@@ -2154,7 +2150,7 @@ static void ehci_advance_async_state(EHCIState *ehci)\n /* make sure guest has acknowledged the doorbell interrupt */\n /* TO-DO: is this really needed? */\n if (ehci->usbsts & USBSTS_IAA) {\n- DPRINTF(\"IAA status bit still set.\\n\");\n+ trace_usb_ehci_log(\"IAA status bit still set.\");\n break;\n }\n \n@@ -2221,9 +2217,7 @@ static void ehci_advance_periodic_state(EHCIState *ehci)\n if (get_dwords(ehci, list, &entry, 1) < 0) {\n break;\n }\n-\n- DPRINTF(\"PERIODIC state adv fr=%d. [%08X] -> %08X\\n\",\n- ehci->frindex / 8, list, entry);\n+ trace_usb_ehci_periodic_state_advance(ehci->frindex / 8, list, entry);\n ehci_set_fetch_addr(ehci, async, entry);\n ehci_set_state(ehci, async, EST_FETCHENTRY);\n ehci_advance_state(ehci, async);\n@@ -2291,8 +2285,7 @@ static void ehci_work_bh(void *opaque)\n ehci_update_frindex(ehci, skipped_uframes);\n ehci->last_run_ns += UFRAME_TIMER_NS * skipped_uframes;\n uframes -= skipped_uframes;\n- DPRINTF(\"WARNING - EHCI skipped %\"PRIu64\" uframes\\n\",\n- skipped_uframes);\n+ trace_usb_ehci_skipped_uframes(skipped_uframes);\n }\n \n for (i = 0; i < uframes; i++) {\ndiff --git a/hw/usb/trace-events b/hw/usb/trace-events\nindex dd04f14add..0d4318dcf1 100644\n--- a/hw/usb/trace-events\n+++ b/hw/usb/trace-events\n@@ -89,6 +89,7 @@ usb_ehci_state(const char *schedule, const char *state) \"%s schedule %s\"\n usb_ehci_qh_ptrs(void *q, uint32_t addr, uint32_t nxt, uint32_t c_qtd, uint32_t n_qtd, uint32_t a_qtd) \"q %p - QH @ 0x%08x: next 0x%08x qtds 0x%08x,0x%08x,0x%08x\"\n usb_ehci_qh_fields(uint32_t addr, int rl, int mplen, int eps, int ep, int devaddr) \"QH @ 0x%08x - rl %d, mplen %d, eps %d, ep %d, dev %d\"\n usb_ehci_qh_bits(uint32_t addr, int c, int h, int dtc, int i) \"QH @ 0x%08x - c %d, h %d, dtc %d, i %d\"\n+usb_ehci_qh_tbytes(uint32_t tbytes) \"updating tbytes to %d\"\n usb_ehci_qtd_ptrs(void *q, uint32_t addr, uint32_t nxt, uint32_t altnext) \"q %p - QTD @ 0x%08x: next 0x%08x altnext 0x%08x\"\n usb_ehci_qtd_fields(uint32_t addr, int tbytes, int cpage, int cerr, int pid) \"QTD @ 0x%08x - tbytes %d, cpage %d, cerr %d, pid %d\"\n usb_ehci_qtd_bits(uint32_t addr, int ioc, int active, int halt, int babble, int xacterr) \"QTD @ 0x%08x - ioc %d, active %d, halt %d, babble %d, xacterr %d\"\n@@ -100,13 +101,21 @@ usb_ehci_port_reset(uint32_t port, int enable) \"reset port #%d - %d\"\n usb_ehci_port_suspend(uint32_t port) \"port #%d\"\n usb_ehci_port_wakeup(uint32_t port) \"port #%d\"\n usb_ehci_port_resume(uint32_t port) \"port #%d\"\n+usb_ehci_port_disable(uint32_t port) \"port #%d\"\n usb_ehci_queue_action(void *q, const char *action) \"q %p: %s\"\n usb_ehci_packet_action(void *q, void *p, const char *action) \"q %p p %p: %s\"\n+usb_ehci_packet_submit(uint32_t qhaddr, uint32_t next, uint32_t qtdaddr, int pid, size_t len, int endp, int status, int actual_length) \"qh=0x%x, next=0x%x, qtd=0x%x, pid=0x%x, len=%zd, endp=0x%x, status=%d, actual_length=%d\"\n usb_ehci_irq(uint32_t level, uint32_t frindex, uint32_t sts, uint32_t mask) \"level %d, frindex 0x%04x, sts 0x%x, mask 0x%x\"\n usb_ehci_guest_bug(const char *reason) \"%s\"\n usb_ehci_doorbell_ring(void) \"\"\n usb_ehci_doorbell_ack(void) \"\"\n usb_ehci_dma_error(void) \"\"\n+usb_ehci_execute_complete(uint32_t qhaddr, uint32_t next, uint32_t qtdaddr, int status, int actual_length) \"qhaddr=0x%x, next=0x%x, qtdaddr=0x%x, status=%d, actual_length=%d\"\n+usb_ehci_fetchqh_reclaim_done(uint32_t qhaddr) \"QH 0x%08x H-bit set, reclamation status reset - done processing\"\n+usb_ehci_fetchqh_dbg(uint32_t qhaddr, uint32_t h, uint32_t halt, uint32_t active, uint32_t next) \"QH 0x%08x (h 0x%x halt 0x%x active 0x%x) next 0x%08x\"\n+usb_ehci_periodic_state_advance(uint32_t frame, uint32_t list, uint32_t entry) \"frame=%d, list=0x%x, entry=0x%x\"\n+usb_ehci_skipped_uframes(uint64_t skipped_uframes) \"skipped %\" PRIu64 \" uframes\"\n+usb_ehci_log(const char *msg) \"%s\"\n \n # hcd-uhci.c\n usb_uhci_reset(void) \"=== RESET ===\"\n", "prefixes": [ "v3", "05/17" ] }