[{"id":3678482,"web_url":"http://patchwork.ozlabs.org/comment/3678482/","msgid":"<2ab50796-2750-4ab1-abe5-6c4f2c809734@linaro.org>","list_archive_url":null,"date":"2026-04-17T05:04:22","subject":"Re: [PATCH v3 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with\n trace events","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 16/4/26 03:49, Jamin Lin wrote:\n> Replace legacy DPRINTF() debug logging in the EHCI host controller\n> implementation with QEMU trace events.\n> \n> The EHCI_DEBUG macro and associated DPRINTF() definitions are\n> removed as they are no longer needed.\n> \n> Trace events are added for:\n> - packet submission and completion\n> - queue head execution state\n> - periodic schedule advancement\n> - ITD error conditions\n> - port state handling\n> - skipped microframes\n> \n> No functional change.\n> \n> Signed-off-by: Jamin Lin \n> ---\n> hw/usb/hcd-ehci.h | 10 ---------\n> hw/usb/hcd-ehci.c | 49 +++++++++++++++++++--------------------------\n> hw/usb/trace-events | 9 +++++++++\n> 3 files changed, 30 insertions(+), 38 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=vQ7ehO8I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxjVw46xMz1yGt\n\tfor ; Fri, 17 Apr 2026 15:05:10 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDbNl-00053u-HD; Fri, 17 Apr 2026 01:04:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDbNU-0004zs-2y\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 01:04:39 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDbNS-0008Et-Jg\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 01:04:27 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-488a9033b2cso2481165e9.2\n for ; Thu, 16 Apr 2026 22:04:26 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc100162sm17362975e9.5.2026.04.16.22.04.23\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 22:04:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776402265; x=1777007065; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=z8dxhqNjde42xCFjygpnI5gYTGKi/RMuEz/YjAzqBpw=;\n b=vQ7ehO8Il1Hu/WzoIn5C0yrBfENitwzFsfM9xgj3PCfZs7ne1fPNPSMYmquNbI9LSD\n /ajjkk4VWKGNSRCvJxROzmw9P8nJDJlTnX6g3j3wetuifsnwuVfKFDoRf9B6YyelZBS9\n PT7rKly7LXmkrrax3sLvCAsLsK6l/KHVBc+zTm+Oo/9ysFVtI1laOY96w6OPAWjj9u3K\n Okntzmq+OFwL9ZwwdlPw/l3pOi7L4tqQbijE6e40IusBybgKG5KNjVIJsupO7p96R47X\n uvrRr6vKrOzEFeCmnDSujsINuewJ9VKWkOj/ENLxZkWfrneM2pF+eXpSWN+o+bw7TcHU\n MceA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776402265; x=1777007065;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=z8dxhqNjde42xCFjygpnI5gYTGKi/RMuEz/YjAzqBpw=;\n b=S8j6XAbiqdo8Yc8bnfiFD1rpdSBMor8oV+WBQd+V8Axp/9cctpJNtxBRDUzGZQ74nE\n 32eijytMROSoqhM6NAeqJjZJwAIU4WN+NchZGbKsp3WsSIkvh4F4Q1WYv3JrK35ejoLB\n Dgsow//jo0R8mJSCGuWPWM1tlH3faWh0I3B+o72wNKti6vLiqrj/WKxiwZcxKgb9meJy\n 617rm2sruzTJvBqL/tWWkBcT8uCRrulWIzSbe5mhbx5Lo9AY+1TfciaW3vMs/loF2KBV\n KtWI3vC0rDv3gJfQT4hYf9jr4trU2GwXjgCXfHflmhoijsRGEUFWgX8IMwb6DZ3Gl5G/\n yhaQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/3wu/2XqOUWB+UO88lmuFXzDGTtsjkSYu+7V6AJCk4JN0iGI9KYh2CSIOdBIMA7tGEliRkzrdJZN5R@nongnu.org","X-Gm-Message-State":"AOJu0YxzFi5oKKWXISd4fDvUS7DAWi9IpVM+2sDMIA4HV4whiInpqhaK\n SuPa8PM0Zuc2F1e3gS00Rj/3n1IU8R3fmKreMvau1uZsNycKfvokpVb4PprqPEw3cSA=","X-Gm-Gg":"AeBDietMJj8Mdw1dLRNA1hlH+SrPOWEgQ37J7RWHclQy1PYc5kuTKQV9C5ADTaMs7LU\n Pb/AOLwRXbjA03X/y7cBeEhkxPKCZvtbNpYJ2es6kz9S7+HKtRGV9CCcQrTGUhoqvYTJdY56vv4\n XtXcbPqG8NUDV9g7umsfk8PQah85/+Cf0k/tKuUoS7Am5kydEv9FbcoAVwXs5Tg6JtE1bmhyLcu\n plKbhl/7vBrEsGYYXIox87q1n7MKJSD8OqeNMCn46eFZpg6qcKVmQ2J8+omABAPNHssXcQdXtaA\n I1x+nxWnpZWj7TJOsQF1iMqqY2ms3O7fpfjHOJF3v6YVt0Rtru2ar2YbrAtP6A5HVmVbgTb6BGJ\n +yz01u3445+hDCBv74A0SBejPWzJGNnmZJMIiP+OO0u0Gu+M1gfsFKid0R8zjs0P5ozJlfZucxN\n wXIWAZtGhiz1zu8rMwbqsra79OjLMRsmxraG/1JHuS/5KtaSpbqwDUf2dSDL+IDRGLgLu1eu2vr\n BN2","X-Received":"by 2002:a05:600c:4fd1:b0:488:a824:fdff with SMTP id\n 5b1f17b1804b1-488fb782a04mr14283205e9.22.1776402264994;\n Thu, 16 Apr 2026 22:04:24 -0700 (PDT)","Message-ID":"<2ab50796-2750-4ab1-abe5-6c4f2c809734@linaro.org>","Date":"Fri, 17 Apr 2026 07:04:22 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with\n trace events","Content-Language":"en-US","To":"Jamin Lin ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","Cc":"Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>\n <20260416014928.1279360-6-jamin_lin@aspeedtech.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260416014928.1279360-6-jamin_lin@aspeedtech.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]