Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222900/?format=api
{ "id": 2222900, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222900/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-19-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260414003001.97571-19-philmd@linaro.org>", "date": "2026-04-14T00:29:50", "name": "[v3,18/27] monitor: Have MonitorDef::get_value() always return int64_t type", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e1dab318efa8956f03dd433ee6c44617c9f53c7b", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-19-philmd@linaro.org/mbox/", "series": [ { "id": 499762, "url": "http://patchwork.ozlabs.org/api/1.1/series/499762/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499762", "date": "2026-04-14T00:29:32", "name": "monitor: Remove need of per-target handlers", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/499762/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222900/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222900/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=jB5T4fiG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlbn2kf8z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 10:32:37 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCRhb-0006bN-9r; Mon, 13 Apr 2026 20:32:27 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wCRhV-00062r-R9\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:32:23 -0400", "from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wCRhS-0003Nr-U2\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:32:21 -0400", "by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-488ab2db91aso77670625e9.3\n for <qemu-devel@nongnu.org>; Mon, 13 Apr 2026 17:32:17 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ee019d9bsm6022655e9.14.2026.04.13.17.32.13\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 13 Apr 2026 17:32:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776126735; x=1776731535; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=u67MdwYZYxVP5k0toQDZeYU1ghiGZ0fFyZnuWFb4BCE=;\n b=jB5T4fiGzKPxRRvun0p7r7Z1MdGiddYRzYSms9G+ma0UsLXaGL/pBgNhl8iG0QcV4K\n wH6LcRSzoSBcxIuaUOck7jQ1naCQyoktjd1itZTUkPjhUxfcLTNaWaOcRVhY9nyGTqFE\n yKYttGANwXCVsimEO3D2M873WX/D65S5/nN0sq5qMO4D2gTuKfZ4BshnGFd26M+TohRj\n Cz9j/AGT1JeudNCnDA2H/dQ/Qyz/zra0lHSnFQMOIW2bM+NK8S8vjwOBmsyy5sFVTGV8\n +Xkuf+6icD+TvtU6TyXhlX3g14Pb78omwCoGrw36VYPiDW+lCe6aEk7NYPOypKPJn49C\n Btgg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776126735; x=1776731535;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=u67MdwYZYxVP5k0toQDZeYU1ghiGZ0fFyZnuWFb4BCE=;\n b=oQooOOTRjYmM633Bi+9mwXMYn6njqKpbDMRXAxbOdphcZkfOJJZwHoadtC5MclRQi5\n /j7Em21yRXAopHNkrhU0+y6jgNWyFOtkiUinPUjrLfgi4MLbt931SZkzN4gs0UucWkar\n ve88iOcKpGRRoVgrG51ld+fi7VCYWS3NJtzi6nBPkmYcdgxn7lent4SyqrxTi/27Rljm\n gou/IhCGCsCVGG39PcUj1RO69LpcH7B1DwxSKHn4Gjz8slmagq97c1djnXfVQHqOSYAS\n h7Xiza6+14kUY2etMOJnDnwheXZkaU3GNDASWegzyeiiUCaQo+qItTCjoUXDkF3IeWnX\n zZ0w==", "X-Gm-Message-State": "AOJu0YxY0mc0GU7tf1VWp+wxU43jj2CIlILS4o6XC6d1TOYj76hVxzi1\n jip2O5ez+x/vDEYQS00TLv/0SMndUvdELYpZ0egzdXGOZCjxppymKIaiuORbRtRA6qkHYbTUb5R\n EZBnG4wc=", "X-Gm-Gg": "AeBDiesLLCdAE6nI0yWJhQa+BF7AXMIH8f5M+rMy04UIbIa2a05KvuCDxwn3VQolFiI\n tJxFqP0FoVAteIxEiH25/NT5AWQy9nUO2hAKFK5rDXIJ3eU/bfPzXJDftMkxUbzdqfuEkA7PIPg\n AnUhGxQM9K60UoB9g0qeS9MMAWkBnuZLyQC/iBx85kGBDaLVPAamEWxt/cgKgN/8aU4FPyDY9C5\n 7RE5Mp+dSqyZ8wnPQvNeheu5W1SEu/AoMoCy5O0VE6ZUho2yJ1zkiuSBg3wp2tDfMgCvfT/k3vI\n T0u+5VbW6TWf9srMRtteI2VDOLcJB/kjVhdZW4zD7XNk9lg1ycVLnpZcTrUwTq2xuPNaj7ta4te\n ITGkCgHwx4Fub5lqYbMlYCcBlUf1tupmRJyPG+zUcFgWW6kYXhoxWMmxSE2hcBhFEMzbE3zca12\n WtbAPhf+7cHeyn11ATRZtS98Vlv+f/donOywAmXe+Qk9WlEecuQJIYLlaLQAbIX6RrcQIutleo", "X-Received": "by 2002:a05:600c:608e:b0:488:8185:e672 with SMTP id\n 5b1f17b1804b1-488d688d2fbmr209037355e9.30.1776126735488;\n Mon, 13 Apr 2026 17:32:15 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Markus Armbruster <armbru@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Zhao Liu <zhao1.liu@intel.com>", "Subject": "[PATCH v3 18/27] monitor: Have MonitorDef::get_value() always return\n int64_t type", "Date": "Tue, 14 Apr 2026 02:29:50 +0200", "Message-ID": "<20260414003001.97571-19-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260414003001.97571-1-philmd@linaro.org>", "References": "<20260414003001.97571-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Simplify MonitorDef::get_value() handler by having it always\nreturn a int64_t type.\n\nLet the single caller (x86 targets) sign-extend the returned\nvalue, directly handling 64-bit CPUs in 32-bit or 16-bit mode.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n include/monitor/hmp-target.h | 6 +-----\n target/i386/monitor.c | 11 ++++++++---\n 2 files changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/monitor/hmp-target.h b/include/monitor/hmp-target.h\nindex 008c1a6570c..ae34ca65ded 100644\n--- a/include/monitor/hmp-target.h\n+++ b/include/monitor/hmp-target.h\n@@ -27,15 +27,11 @@\n \n typedef struct MonitorDef MonitorDef;\n \n-#ifdef COMPILING_PER_TARGET\n-#include \"exec/target_long.h\"\n struct MonitorDef {\n const char *name;\n int offset;\n- target_long (*get_value)(Monitor *mon, const struct MonitorDef *md,\n- int val);\n+ int64_t (*get_value)(Monitor *mon, const MonitorDef *md, int offset);\n };\n-#endif\n \n const MonitorDef *target_monitor_defs(void);\n \ndiff --git a/target/i386/monitor.c b/target/i386/monitor.c\nindex 977f65fe16c..98df5c7fd12 100644\n--- a/target/i386/monitor.c\n+++ b/target/i386/monitor.c\n@@ -593,11 +593,16 @@ void hmp_mce(Monitor *mon, const QDict *qdict)\n }\n }\n \n-static target_long monitor_get_pc(Monitor *mon, const struct MonitorDef *md,\n- int val)\n+static int64_t monitor_get_pc(Monitor *mon, const struct MonitorDef *md,\n+ int offset)\n {\n CPUArchState *env = mon_get_cpu_env(mon);\n- return env->eip + env->segs[R_CS].base;\n+ int64_t ret = env->eip + env->segs[R_CS].base;\n+\n+ if (!(env->hflags & HF_CS64_MASK)) {\n+ ret = (int32_t)ret;\n+ }\n+ return ret;\n }\n \n const MonitorDef monitor_defs[] = {\n", "prefixes": [ "v3", "18/27" ] }