[{"id":3676994,"web_url":"http://patchwork.ozlabs.org/comment/3676994/","msgid":"","list_archive_url":null,"date":"2026-04-14T00:49:02","subject":"Re: [PATCH v3 18/27] monitor: Have MonitorDef::get_value() always\n return int64_t type","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/14/26 10:29, Philippe Mathieu-Daudé wrote:\n> SimplifyMonitorDef::get_value() handler by having it always\n> return a int64_t type.\n> \n> Let the single caller (x86 targets) sign-extend the returned\n> value, directly handling 64-bit CPUs in 32-bit or 16-bit mode.\n> \n> Suggested-by: Richard Henderson\n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> include/monitor/hmp-target.h | 6 +-----\n> target/i386/monitor.c | 11 ++++++++---\n> 2 files changed, 9 insertions(+), 8 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=uYDDwDR6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlzC1Km8z1yCv\n\tfor ; Tue, 14 Apr 2026 10:49:27 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRxr-0007dX-Vi; Mon, 13 Apr 2026 20:49:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCRxo-0007ce-GZ\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:49:12 -0400","from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wCRxm-0007it-OS\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:49:12 -0400","by mail-pf1-x42a.google.com with SMTP id\n d2e1a72fcca58-824c9da9928so3476833b3a.3\n for ; Mon, 13 Apr 2026 17:49:10 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:377f:61ec:6edd:e205?\n ([2401:d002:dc0f:2100:377f:61ec:6edd:e205])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c339570sm12406056b3a.16.2026.04.13.17.49.05\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 13 Apr 2026 17:49:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776127749; x=1776732549; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=psAieoi9wJYJkxHTxcj1/8XSDLS22akGCnQF77/4XHg=;\n b=uYDDwDR6/2MnOXYpWdKaqdmwPrWSHAvRNvP3wYxJUSxBNy54ue+tqIQe0s9TTGA1LZ\n B0MeQMOEi1nbnjCDmt/1MEZLkgTt9Q4jLN/hdhrbJDu45Cl9mb2MV7rMevoMefxj4sNo\n 2F6RZVC9TYAYus5aOY/RyyIgW7bD2mBiDCFNLAaa+TUkOZRNeq8PPi0BqCDMW/+n5Uh6\n n4U+uy/D37th0fW5Z+7EgfUr7c7gLYq+HPRotEdPnfUVlDFbHx3LP4FGM/fy2wWiqdyJ\n sGZalpNJfIo9GR8Y20JIDd6Kh2AX6qrSaWnSCYgxfzsAbiNplus6JHEKta+TDSE3qf0s\n YShA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776127749; x=1776732549;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=psAieoi9wJYJkxHTxcj1/8XSDLS22akGCnQF77/4XHg=;\n b=P4VGg+lzOCPqO41Z+jCqY6LIv5LjlaJv2KdeZucTGSeYze4B2Zb/eGHlNU4QTX88aq\n fbacepXoF1xCVE737Un3iJmny3zBPKyTB8yTfbRvL5/lu9XcEaRO5G7DH+qQnMfrONB/\n ahcivEjQ2uzMykcguKQ3zJpTr4HQ9xAHD1d9mBkBptBavqodDXeoGLpSRl6Y+rhlBx0F\n wb8eq8GGhIltH32jZPduU4SFA6o4IHNJjTQbfUraUOq3tiD/0u1DEF20lF3kap1qtn4k\n +cpOYwZq2hm9P9OX1SQOlkm1dqB0e+U3g+25DG721n8PYGprlD/MAUiYnMCJAOdNQTMo\n v9yw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9N7gK1HISF4oIL8ThPwkh4cX6z5T82w1DiUDc1NCTSb7EvUakHvNKODI4dW8AYShs3rtMcpqBuLhuu@nongnu.org","X-Gm-Message-State":"AOJu0YxUc3NJadwPcsCEF7xklKxJDTiju33aZFKxS1isyUAe8uoaPjb4\n ktrUpd5azcmp3NED8FH8LJFVpin27Y089hMvprenRWZ4hAlrYB03qrDZTIlUSbrIxkY=","X-Gm-Gg":"AeBDieuJp4tZe/h8hvQ9acitemHQ2zueLGcIAn1TdOycFmMuRMi2VsaLnqlyVADKtL8\n ssdMUkuyVhN0Zq+J4chpqZ6n1StqqJvMiJZAKBXKZ1sOMPQDD/OwPEVw3AM60wPhTbrrde6ifg2\n tMgAGGXirK7N7K1CN1pzjyOWSaU6MhA/GDwF6XoMnUy6WQ7lZ9MJ68jfmdZZlxI8c7IacgRt15u\n IbkI0XxULI00R3GwkbjSU30iyAzvckuBbodSKrjGGyZFcVnzfv3pYUxDKHYn49W0+sDeUT/Hi8R\n FpCcjPg+S4iVC0D/kWWwe3WMt03lz4ulkfv3B7ee+wxu6/nLYxpX7iA5FRbufueBJ+hIPegms6C\n UMn8v1JUV1sUekzLu8kVPz9xxDZOKWxDNbz/zdmWLDLW/I+mRl9WcQpCRct1katymhWMyKXBRop\n zmPLPX5vTRjSXx4jQP3+8DplC6fIWP1h52t6MQ73S9Gm+NymHUkwayhS+FMMzG6cwgpma/nvPAd\n A6rpT74Jl+sEQ==","X-Received":"by 2002:a05:6a00:2c8a:b0:82f:37e3:ae67 with SMTP id\n d2e1a72fcca58-82f37e3b1b9mr4640398b3a.27.1776127748800;\n Mon, 13 Apr 2026 17:49:08 -0700 (PDT)","Message-ID":"","Date":"Tue, 14 Apr 2026 10:49:02 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 18/27] monitor: Have MonitorDef::get_value() always\n return int64_t type","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Markus Armbruster ,\n \"Dr. David Alan Gilbert\" ,\n Paolo Bonzini , Zhao Liu ","References":"<20260414003001.97571-1-philmd@linaro.org>\n <20260414003001.97571-19-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260414003001.97571-19-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::42a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]