Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222196/?format=api
{ "id": 2222196, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410200031.18572-2-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410200031.18572-2-philmd@linaro.org>", "date": "2026-04-10T20:00:30", "name": "[v2,1/2] hw/arm/smmuv3: Have smmuv3_accel_init() take an Error* parameter", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "14c4963272321088fb372905f3ccfe443f4ff40a", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410200031.18572-2-philmd@linaro.org/mbox/", "series": [ { "id": 499500, "url": "http://patchwork.ozlabs.org/api/1.1/series/499500/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499500", "date": "2026-04-10T20:00:29", "name": "hw/arm/smmuv3: Avoid including CONFIG_DEVICES in hw/ header", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499500/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222196/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222196/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=NGTGoFjN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsnkK3JMvz1yGS\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 06:01:29 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBI23-0007P5-3t; Fri, 10 Apr 2026 16:00:47 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wBI20-0007Ok-3e\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 16:00:44 -0400", "from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wBI1y-0006bn-I7\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 16:00:43 -0400", "by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-4838c15e3cbso21893715e9.3\n for <qemu-devel@nongnu.org>; Fri, 10 Apr 2026 13:00:42 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d5b3c597sm92483685e9.12.2026.04.10.13.00.39\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 13:00:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775851241; x=1776456041; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Qsggwi5zbpivKYu9vxgPsRTzFrjprzvcyLLml3Oa1F4=;\n b=NGTGoFjN6Peqk52B2QhZDDzyYEDg8UuIo2fXVmlll/9aOk99btm3mTQWDga219toLo\n Zo03pJ3RQGfT5TQw3hT/8zHK93wWTJbevO97TxLfY3o87OXQIlHaTJ/bCU/14OA15qw+\n CKyk2fbe+eKAMIxpm/L+llJB+hbxLh10p6ioLo/nCL8DTtMq57pR5LUWVfo9425BSWHr\n imWFlWSYtM8BxvYu6hRTCEC6Q2PPSAqPC87vYsEfAyYIstj2u9kN+iHEo+LCaTkpedhU\n dTpzm5MXjteBc+AaZkTwE6M5FF2AaEvQKO2BVVSM4Keib+falxNUPzoec3ToYunfGZQs\n AwoA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775851241; x=1776456041;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Qsggwi5zbpivKYu9vxgPsRTzFrjprzvcyLLml3Oa1F4=;\n b=j9iPziE0oPxtIaCOsSroDv3pTrqbhjS93DcMDaCi7HKzQd6GaUBBoHqwAeocw03kNG\n mum5gUE6vQzryWMF/Wwud9WyqiEK4Xv1z8KqOty9mD7HyARDCFJdJhw4KyYxadysNBy/\n rTbZx2NO0ttCbkfmW/v1CeTRKtx0TqtrjBYzBVaraEhaaeKvY+I6PE35i813TpqsWI9Z\n P3c3rn4wCj5OrUODNutCzdg93e2XI+ftYpktxBNbuBQVbZLSlqH0UBaqB8usaiyaIvco\n sRjyD+k/oaVV9Lz4vocBiS3Nu6jfFeCn6O93AFJCiw6D2i5/0M+BBXiz90w1BULY7jFC\n m8Og==", "X-Gm-Message-State": "AOJu0YzMRVcWwTiK5+g8BHhtNWKH/uM4mJZvxl4exveG1+ZnOWqwydo6\n BZIw1QzFxR6BNUTxxmavrR37NTUG6MKKJV8DQwx5aA/zsPi9dSuKxR69BOuJDUSCn3OdZ/wcGOd\n cnmFy45c=", "X-Gm-Gg": "AeBDieuh/Z4/SXrTGUpEKT60Ekq5BX64Awyu6TsXrIYhUFxoGdXzbwNNhYUjiLSZT7n\n UxB1uOn2ah5cEKZenvCxh1tOzj2KUHa0yX+Yty7GketjA+kytAxuCCOGRR/CjnlBO942sxAqhb0\n FtQQo57enIISMMVQ/gDe+xth7wbQD0PhGHAqIK9mJo/Hgo6i+MRT3TV+bgFwc0i7YINiXgLbeCE\n x/vTNZaeJUv1pIyoRIEGAkHIGVcaIYHvnWWOTUcnWIkY8sIw+wM/04iZZ23kHOGcYzSKNPXqRPD\n /wTjtxss17nKN0mgTsvPmThcfdRMzrdVxS/dJgbVWGi/39WYgbuoCNiVf2R/awvbJgMAx0LkGb5\n 7drPvpF0Jb6+GqGDGNHq2xzxCg60qR7pAvR3m5bKYyCXIPVFVfVf73PBueQ5ZN3o5367baSVrg6\n qwsga/F6JJuThlygLExNLhs/kBw217ljB2DUoUhaeUtwosPouVDuJgZ6/IJ+ZWt/Cfjp+1zM86", "X-Received": "by 2002:a05:600c:1f83:b0:488:b99b:4177 with SMTP id\n 5b1f17b1804b1-488d687bf61mr56226695e9.25.1775851240522;\n Fri, 10 Apr 2026 13:00:40 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Nathan Chen <nathanc@nvidia.com>, qemu-arm@nongnu.org,\n Peter Maydell <peter.maydell@linaro.org>,\n Shameer Kolothum Thodi <skolothumtho@nvidia.com>,\n Eric Auger <eric.auger@redhat.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH v2 1/2] hw/arm/smmuv3: Have smmuv3_accel_init() take an Error*\n parameter", "Date": "Fri, 10 Apr 2026 22:00:30 +0200", "Message-ID": "<20260410200031.18572-2-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260410200031.18572-1-philmd@linaro.org>", "References": "<20260410200031.18572-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::333;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "By giving smmuv3_accel_init() the ability to populate an error,\nwe can fail early in smmu_realize() when CONFIG_ARM_SMMUV3_ACCEL\nis not available, simplifying smmu_validate_property().\n\nSuggested-by: Shameer Kolothum Thodi <skolothumtho@nvidia.com>\nCo-developed-by: Shameer Kolothum Thodi <skolothumtho@nvidia.com>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n hw/arm/smmuv3-accel.h | 7 +++++--\n hw/arm/smmuv3-accel.c | 3 ++-\n hw/arm/smmuv3.c | 11 +++--------\n 3 files changed, 10 insertions(+), 11 deletions(-)", "diff": "diff --git a/hw/arm/smmuv3-accel.h b/hw/arm/smmuv3-accel.h\nindex dba6c71de52..1ca2c80a933 100644\n--- a/hw/arm/smmuv3-accel.h\n+++ b/hw/arm/smmuv3-accel.h\n@@ -42,7 +42,7 @@ typedef struct SMMUv3AccelDevice {\n } SMMUv3AccelDevice;\n \n #ifdef CONFIG_ARM_SMMUV3_ACCEL\n-void smmuv3_accel_init(SMMUv3State *s);\n+bool smmuv3_accel_init(SMMUv3State *s, Error **errp);\n bool smmuv3_accel_install_ste(SMMUv3State *s, SMMUDevice *sdev, int sid,\n Error **errp);\n bool smmuv3_accel_install_ste_range(SMMUv3State *s, SMMUSIDRange *range,\n@@ -54,8 +54,11 @@ void smmuv3_accel_idr_override(SMMUv3State *s);\n bool smmuv3_accel_alloc_veventq(SMMUv3State *s, Error **errp);\n void smmuv3_accel_reset(SMMUv3State *s);\n #else\n-static inline void smmuv3_accel_init(SMMUv3State *s)\n+#include \"qapi/error.h\"\n+static inline bool smmuv3_accel_init(SMMUv3State *s, Error **errp)\n {\n+ error_setg(errp, \"accel=on support not compiled in\");\n+ return false;\n }\n static inline bool\n smmuv3_accel_install_ste(SMMUv3State *s, SMMUDevice *sdev, int sid,\ndiff --git a/hw/arm/smmuv3-accel.c b/hw/arm/smmuv3-accel.c\nindex 65c2f44880a..ae031f1eccf 100644\n--- a/hw/arm/smmuv3-accel.c\n+++ b/hw/arm/smmuv3-accel.c\n@@ -917,11 +917,12 @@ static void smmuv3_accel_as_init(SMMUv3State *s)\n address_space_init(shared_as_sysmem, &root, \"smmuv3-accel-as-sysmem\");\n }\n \n-void smmuv3_accel_init(SMMUv3State *s)\n+bool smmuv3_accel_init(SMMUv3State *s, Error **errp)\n {\n SMMUState *bs = ARM_SMMU(s);\n \n s->s_accel = g_new0(SMMUv3AccelState, 1);\n bs->iommu_ops = &smmuv3_accel_ops;\n smmuv3_accel_as_init(s);\n+ return true;\n }\ndiff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c\nindex 5570a13c8a6..5c2855c3770 100644\n--- a/hw/arm/smmuv3.c\n+++ b/hw/arm/smmuv3.c\n@@ -1965,13 +1965,6 @@ static void smmu_reset_exit(Object *obj, ResetType type)\n \n static bool smmu_validate_property(SMMUv3State *s, Error **errp)\n {\n-#ifndef CONFIG_ARM_SMMUV3_ACCEL\n- if (s->accel) {\n- error_setg(errp, \"accel=on support not compiled in\");\n- return false;\n- }\n-#endif\n-\n if (s->ats == ON_OFF_AUTO_AUTO) {\n error_setg(errp, \"ats auto mode is not supported\");\n return false;\n@@ -2033,7 +2026,9 @@ static void smmu_realize(DeviceState *d, Error **errp)\n }\n \n if (s->accel) {\n- smmuv3_accel_init(s);\n+ if (!smmuv3_accel_init(s, errp)) {\n+ return;\n+ }\n error_setg(&s->migration_blocker, \"Migration not supported with SMMUv3 \"\n \"accelerator mode enabled\");\n if (migrate_add_blocker(&s->migration_blocker, errp) < 0) {\n", "prefixes": [ "v2", "1/2" ] }