[{"id":3676373,"web_url":"http://patchwork.ozlabs.org/comment/3676373/","msgid":"","list_archive_url":null,"date":"2026-04-12T20:27:34","subject":"RE: [PATCH v2 1/2] hw/arm/smmuv3: Have smmuv3_accel_init() take an\n Error* parameter","submitter":{"id":91580,"url":"http://patchwork.ozlabs.org/api/people/91580/","name":"Shameer Kolothum Thodi","email":"skolothumtho@nvidia.com"},"content":"> -----Original Message-----\n> From: Philippe Mathieu-Daudé \n> Sent: 10 April 2026 21:01\n> To: qemu-devel@nongnu.org\n> Cc: Nathan Chen ; qemu-arm@nongnu.org; Peter\n> Maydell ; Shameer Kolothum Thodi\n> ; Eric Auger ; Philippe\n> Mathieu-Daudé \n> Subject: [PATCH v2 1/2] hw/arm/smmuv3: Have smmuv3_accel_init() take an\n> Error* parameter\n> \n> External email: Use caution opening links or attachments\n> \n> \n> By giving smmuv3_accel_init() the ability to populate an error,\n> we can fail early in smmu_realize() when CONFIG_ARM_SMMUV3_ACCEL\n> is not available, simplifying smmu_validate_property().\n> \n> Suggested-by: Shameer Kolothum Thodi \n> Co-developed-by: Shameer Kolothum Thodi \n> Signed-off-by: Philippe Mathieu-Daudé \n\nReviewed-by: Shameer Kolothum \n\nThanks,\nShameer\n\n> hw/arm/smmuv3-accel.h | 7 +++++--\n> hw/arm/smmuv3-accel.c | 3 ++-\n> hw/arm/smmuv3.c | 11 +++--------\n> 3 files changed, 10 insertions(+), 11 deletions(-)\n> \n> diff --git a/hw/arm/smmuv3-accel.h b/hw/arm/smmuv3-accel.h\n> index dba6c71de52..1ca2c80a933 100644\n> --- a/hw/arm/smmuv3-accel.h\n> +++ b/hw/arm/smmuv3-accel.h\n> @@ -42,7 +42,7 @@ typedef struct SMMUv3AccelDevice {\n> } SMMUv3AccelDevice;\n> \n> #ifdef CONFIG_ARM_SMMUV3_ACCEL\n> -void smmuv3_accel_init(SMMUv3State *s);\n> +bool smmuv3_accel_init(SMMUv3State *s, Error **errp);\n> bool smmuv3_accel_install_ste(SMMUv3State *s, SMMUDevice *sdev, int sid,\n> Error **errp);\n> bool smmuv3_accel_install_ste_range(SMMUv3State *s, SMMUSIDRange\n> *range,\n> @@ -54,8 +54,11 @@ void smmuv3_accel_idr_override(SMMUv3State *s);\n> bool smmuv3_accel_alloc_veventq(SMMUv3State *s, Error **errp);\n> void smmuv3_accel_reset(SMMUv3State *s);\n> #else\n> -static inline void smmuv3_accel_init(SMMUv3State *s)\n> +#include \"qapi/error.h\"\n> +static inline bool smmuv3_accel_init(SMMUv3State *s, Error **errp)\n> {\n> + error_setg(errp, \"accel=on support not compiled in\");\n> + return false;\n> }\n> static inline bool\n> smmuv3_accel_install_ste(SMMUv3State *s, SMMUDevice *sdev, int sid,\n> diff --git a/hw/arm/smmuv3-accel.c b/hw/arm/smmuv3-accel.c\n> index 65c2f44880a..ae031f1eccf 100644\n> --- a/hw/arm/smmuv3-accel.c\n> +++ b/hw/arm/smmuv3-accel.c\n> @@ -917,11 +917,12 @@ static void smmuv3_accel_as_init(SMMUv3State *s)\n> address_space_init(shared_as_sysmem, &root, \"smmuv3-accel-as-\n> sysmem\");\n> }\n> \n> -void smmuv3_accel_init(SMMUv3State *s)\n> +bool smmuv3_accel_init(SMMUv3State *s, Error **errp)\n> {\n> SMMUState *bs = ARM_SMMU(s);\n> \n> s->s_accel = g_new0(SMMUv3AccelState, 1);\n> bs->iommu_ops = &smmuv3_accel_ops;\n> smmuv3_accel_as_init(s);\n> + return true;\n> }\n> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c\n> index 5570a13c8a6..5c2855c3770 100644\n> --- a/hw/arm/smmuv3.c\n> +++ b/hw/arm/smmuv3.c\n> @@ -1965,13 +1965,6 @@ static void smmu_reset_exit(Object *obj,\n> ResetType type)\n> \n> static bool smmu_validate_property(SMMUv3State *s, Error **errp)\n> {\n> -#ifndef CONFIG_ARM_SMMUV3_ACCEL\n> - if (s->accel) {\n> - error_setg(errp, \"accel=on support not compiled in\");\n> - return false;\n> - }\n> -#endif\n> -\n> if (s->ats == ON_OFF_AUTO_AUTO) {\n> error_setg(errp, \"ats auto mode is not supported\");\n> return false;\n> @@ -2033,7 +2026,9 @@ static void smmu_realize(DeviceState *d, Error\n> **errp)\n> }\n> \n> if (s->accel) {\n> - smmuv3_accel_init(s);\n> + if (!smmuv3_accel_init(s, errp)) {\n> + return;\n> + }\n> error_setg(&s->migration_blocker, \"Migration not supported with\n> SMMUv3 \"\n> \"accelerator mode enabled\");\n> if (migrate_add_blocker(&s->migration_blocker, errp) < 0) {\n> --\n> 2.53.0","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=GoJhnG6N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv2F01M7lz1yCx\n\tfor ; Mon, 13 Apr 2026 06:28:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wC1PI-0003iU-4I; Sun, 12 Apr 2026 16:27:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wC1PG-0003hJ-Q6; Sun, 12 Apr 2026 16:27:46 -0400","from mail-westus3azlp170120001.outbound.protection.outlook.com\n ([2a01:111:f403:c107::1] helo=PH8PR06CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wC1PE-000791-AN; Sun, 12 Apr 2026 16:27:45 -0400","from CH3PR12MB7548.namprd12.prod.outlook.com (2603:10b6:610:144::12)\n by CY5PR12MB6202.namprd12.prod.outlook.com (2603:10b6:930:25::8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Sun, 12 Apr\n 2026 20:27:35 +0000","from CH3PR12MB7548.namprd12.prod.outlook.com\n ([fe80::b710:d6a1:ab16:76de]) by CH3PR12MB7548.namprd12.prod.outlook.com\n ([fe80::b710:d6a1:ab16:76de%6]) with mapi id 15.20.9818.017; Sun, 12 Apr 2026\n 20:27:35 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=XYREi3eEl+F4C9nXKfBVdvYkR8ouB/zOjW1YA03T4YSlba70ykd9VHFvXP2jFaCrrXaM/BUfmVP7Isci6ito4wsA1XjfHASVFN31kRJVVYMJn+7+dWSIx7uvgJapYCuPmeA8ZT5K9FFMKKa7k+jWEpcV5TYRlAbcfz8H/Cs27erwH7JOJb8WKPD3O89hoZLaqdlkvJvYDQ0fcjh7PBk71MCy8kQo+5lFGDtMfA0MPPGlXYKK4jxHLKjAv0eqEPblIqECxyyGNPAaCRu0Oug+24l1VHgM3vJhzPQSjUTsXGfIWWlQRbterYrH9M0QbWmqPMrmrUKP8bUmhcugkpWWYA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=wTZilgP7eeUydVaZJ9o6gy90V7CRbW0OMM2BvXS21P4=;\n b=NhzAbIM+r2U4L7Nvp8M2vc6kUVPshfxFMBoNbnHxlvOrinSm/GQ1s7VV6wKYxel7jAoI1+aU78Do0awbT1HO1fPl/Sum5/EJUHVNCep2QYY04sCh6eNEIwEEkf83MA28Xt5cdmkDU7UIAhKXeDgGsDTnVww08syO60wkmGROldhu5HWm+J6j/t59ERDcFHumwz1d27z/ZUJpG0S7E8w+IzgclsXZZy3jplFLWBzL+K+7+l6M61vk2pz8aXa188vAdykoVfOKjGRSyYPdWQsJ0b4YDGvJsts+/kPiST9Jnj+x4QaA8NRFaXpLU1YbM9m7yYFKZ4QG4OcOwklCWBFv3A==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=wTZilgP7eeUydVaZJ9o6gy90V7CRbW0OMM2BvXS21P4=;\n b=GoJhnG6N0eQ9skfgUWp4kisHJwxayst1RyCQkAsq4Xn1KwH7edw7TIOaMZeK8VZ20keFKCZEDAtwcEhDPU4skJfikBVB56+CeW309Cc/7BXxfwqaC2roQPy30IjeIR6MmVn/v3it3DQbFZLZt/ZvHj/vcOMNcJV7r2qW2cohWi+3OaHCBSwf3EQhuYDE/sa7B9AJOsZIchfvlvT/Vj1r9hPcadys5lk9NtYF2Yy5fB1C7DPtrdZttXsRek0SkePgm6MED6wUWRKI/4lzmTPMaPrtSct6Fh1y4ZEQJ8R1LZfgCm8mSQX7S/gkBnbtc2yu5ezTg3numLlk6ePbocPfsw==","From":"Shameer Kolothum Thodi ","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n \"qemu-devel@nongnu.org\" ","CC":"Nathan Chen , \"qemu-arm@nongnu.org\"\n , Peter Maydell , Eric Auger\n ","Subject":"RE: [PATCH v2 1/2] hw/arm/smmuv3: Have smmuv3_accel_init() take an\n Error* parameter","Thread-Topic":"[PATCH v2 1/2] hw/arm/smmuv3: Have smmuv3_accel_init() take an\n Error* parameter","Thread-Index":"AQHcySS6wyduehyJ5ESi660Fm/XmYLXb4wLQ","Date":"Sun, 12 Apr 2026 20:27:34 +0000","Message-ID":"\n ","References":"<20260410200031.18572-1-philmd@linaro.org>\n <20260410200031.18572-2-philmd@linaro.org>","In-Reply-To":"<20260410200031.18572-2-philmd@linaro.org>","Accept-Language":"en-US, en-GB","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=GoJhnG6N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"CH3PR12MB7548:EE_|CY5PR12MB6202:EE_","x-ms-office365-filtering-correlation-id":"b6aee418-4477-43dd-7250-08de98d1ee7c","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003;","x-microsoft-antispam-message-info":"\n /lpW7ikOMaO98qVdx//wl9s3m9m3J1OoWU65Br0yk5TqvAB+PdTBolJXdG1CPWqesU0T15l9LCAYPJ8Q9soUXO50JKNYDSLn1Rf9BU4b4Kwh7jznOhAi56PVq4GK5qI4dx062XlLQ3f+JPeVsLunIhEPxW3YiCaloyUSmBwCPmOMBKtP+gq9GNdjLgIt9vPLud1getT0V4YKDJplQ7NSyreF8Ob26oRIsTbzzW8V3Wl+dKrtVVrU3htdqJVjRKQc/C5/bgDyZnNg2d6VfBdz/bBR1I9B5s3Eat+gwqf+XNN8PMEhvBd1WJ3mRbzCaS0CuH2FgUY+KMu4wZmT4gLUu79nS14YYlgOLAi5KQCyFgRyr1Fssc8cK3BuX7wxemHxpPEuRGJ+zFzfAO3mFrhDn6jbkVfM2mIgLbE939JOFfQP5moToSyChDVb4rkbAL/nM3dRp4+DHk75UyhVWD81QYO0gO/l81D0LX2rIsfosVGPXEuxiE/VzcDiPjg58Tp8VEzybGK2nNZcuyDeK6fTSK51neY3m9SJsb/gMVlCsnWKBJ7pf2SSWlxzovsnec2CTPxs70/xiPW6OhoGXg5XnIU+S78k7NJ6SVl+UgHk4FiVvQqSUyWW0bcBO5GEPxTZpcnQotOh39DO42Z5uL1o4KqfGasmRNq3w9U/YF17gOhIcUUJX0ePY4Mz0c4dwKPIrAHtoZieqB6mPUgtX257Toc0jjb/5SBcoMXqUsQ0+nrPWdg+x1jJ0HHJJEaZygMGOW7OVyFTEoWDwEtK4PObE4f3Uwr3reX0+UH7xu1xNps=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:CH3PR12MB7548.namprd12.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?B8SPN63R41q2CP880M7vvlAPFL+l?=\n\t=?utf-8?q?ZjP959M1xZdqbWTs/p6phQrNJm5AxmSJc7DpWkbLNvXzgfDDAncZGW5spKPtNTx9y?=\n\t=?utf-8?q?YbACWX9opozh9UAe2ZW8YtxKa/GBvij3pMmtxot2skXfjOx7QE20kPW+j4NCQrCHz?=\n\t=?utf-8?q?bkOOr/dUn61MZ4HUTmv76jRgwOUmls4OBR1daWketGIOY9VFBO7B2AdMi5PYY1v/p?=\n\t=?utf-8?q?A7X7exxozGMHCZJi2AgRMCrzgSkoeuRRRk6Mi8QShJ5R3yGQyg2+LomoJE/F9ojWp?=\n\t=?utf-8?q?9tvrDxzbTofT2eDqSSMqxZfjxV4snT7ra/RO13Fx1z4QfBmuqj0ZhEBbfdihx/uhU?=\n\t=?utf-8?q?d1hrt8kIengqFaFZUedJDWtktnCyAy8Vx8LEN7P9zd21K7Ap41HecH8KYB6vFCe1c?=\n\t=?utf-8?q?lKr3YYdEXuyLlOsd/SFonZxdtAS1vT+xdwont7iwwjbsNUiys+41f2bRKW97x3lZI?=\n\t=?utf-8?q?8XRaEm7QCEV/8lSbpuMuylTq5yrORKKfqCFZAypcrY3lQm0AjafgxXQ54PIvS2+vy?=\n\t=?utf-8?q?ADQjUXCm/j4LcdDyptcwLjbRwmHvttAM3zBk64i0r4LKk0HiTo82rAiFeE8v8SRSj?=\n\t=?utf-8?q?D3fXSrJ4+fKgIRPpWCU8RxFHmRkzAXr6coXqVAMLvwntLfoT+p1G3bOGPxmXDsInG?=\n\t=?utf-8?q?v4dfZPnH5UJk2BzQ4UglPHuSddjJDVWKsYKErOgFJG1wt6OumYkguumN3g1EDbO/l?=\n\t=?utf-8?q?hucNeC29Nh2Updqi+MHoMCC2kaMaAj6N4vJwXSzejx4m+bjHMNyi53rz76EXCllTt?=\n\t=?utf-8?q?2ySpDAvSWHe1zTj8fT5zPgCAgSvuUnRKlS69YGJus57z6Wf4lPp+S3cSSK9I07tcB?=\n\t=?utf-8?q?qiOCjP9E+N5P/eOJiEqhJVW8oMWR5DqDQuTsOKKRxOF3Iuxgnvu4LlZbPUFhCM2Ih?=\n\t=?utf-8?q?HgKKk74mbyJOjDUVuvLI4Xs160Qg/6LEskyh2tesOsWozr6tPgKXnXAV84rudi+vl?=\n\t=?utf-8?q?uWgTkQwneeS5q4p46MhsF9bQEGKj0NNMvoiYMaMn7bnYGcSxdPtr3T9gndqhsmS6J?=\n\t=?utf-8?q?pTclL69rpljM62hVlwp3uxKF1WYQ9jyQWNRR2wOICDKSwcg/G+LCrGaPjS5eNTP7K?=\n\t=?utf-8?q?X5Wv+VfZkjhyyc0pHhxbnQS7SxVTQjnw0dndpRaM3f6h3aEDF1cK44hDjJNzXrcVy?=\n\t=?utf-8?q?RN6FAJyakisCTy5Q4H1SSyPZzF1wqdEQe6ypD0Jh9IH/NfLDHATSOSWGYduIqdCIL?=\n\t=?utf-8?q?lbAE1/akg/joH87yoyvxFIoUT+NxPxTDiw4J+yqy9FapM3yxFWg4StPB62TM3eKWQ?=\n\t=?utf-8?q?6doySmK82T14GfTsX2E5pcj0vuaZvkPTOzmGwI7Eo2CIOdev8C6aqsZNxOw2fQh1y?=\n\t=?utf-8?q?7SX3a2QeptsRqiSO7JpVfqgWoC5QRKQ+xCG3f5dZPlYjY2EXkz+5pOCYI+7hUwSP5?=\n\t=?utf-8?q?Sm1Qc9jWZhR7Ztnp9u3viRtZKbG4WFMQWgmTDpBvV1VPOTYUevo39vuvo0SzS+z8D?=\n\t=?utf-8?q?P51jWMr28ouN+QclW5hKfiGY85anaVtPxqHR9gGVeI91yVCfn0v8rsBbAZJgF706q?=\n\t=?utf-8?q?v1jreV2V/i9f83vZ+KfyOiKhHpNtDX+gtMvK4ezngkTil/C1bNOLHwv/QiImqpKav?=\n\t=?utf-8?q?BMURsd0IJM3RPjcXqmUUYl0OcvfCwGgj8x0vtwC7hCGJn582Pkau3jo1DCV6KOYLZ?=\n\t=?utf-8?q?h9Q219AcSxkaFNz6Mi1cq3uuyMCkjlmQ=3D=3D?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"CH3PR12MB7548.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n b6aee418-4477-43dd-7250-08de98d1ee7c","X-MS-Exchange-CrossTenant-originalarrivaltime":"12 Apr 2026 20:27:34.9601 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n ktPx/suNdoz2ms53/f/bcAZeSImH+gEGXAmkhHabbe7MJOMkG+Q/nA5r3vUWuqbIqKKN+oRCHc9GgktptMov7A==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY5PR12MB6202","Received-SPF":"permerror client-ip=2a01:111:f403:c107::1;\n envelope-from=skolothumtho@nvidia.com;\n helo=PH8PR06CU001.outbound.protection.outlook.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]