Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222130/?format=api
{ "id": 2222130, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222130/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-50-231416f76dc3@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410-qemu-vnc-v2-50-231416f76dc3@redhat.com>", "date": "2026-04-10T19:19:12", "name": "[v2,50/67] ui/vnc: report an error for duplicate display id", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "719c5a5f82a9142387bd747c78254604c828fae2", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-50-231416f76dc3@redhat.com/mbox/", "series": [ { "id": 499494, "url": "http://patchwork.ozlabs.org/api/1.1/series/499494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494", "date": "2026-04-10T19:18:23", "name": "ui: add standalone VNC server over D-Bus", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499494/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222130/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222130/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=FQTtI6x9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmzf2K0dz20HT\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:27:58 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBHSR-0006Ve-9x; Fri, 10 Apr 2026 15:23:59 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHSQ-0006Qs-40\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:58 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHSO-0002CY-Ob\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:57 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-0olYaZuFMSCsMpQ442sWWQ-1; Fri,\n 10 Apr 2026 15:23:54 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id BEF2F19560A2\n for <qemu-devel@nongnu.org>; Fri, 10 Apr 2026 19:23:53 +0000 (UTC)", "from localhost (unknown [10.44.22.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A3A461800B7F; Fri, 10 Apr 2026 19:23:52 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775849036;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=fNtgm7Dc2sKWUhtRubFcPFp7/J/116trHEswWgG7p+s=;\n b=FQTtI6x9XeNeLOB0LHP6dRfnXm2yereicsgrZ87JQVQTt4OH6gZsNP04QPLYlsYqCskuHA\n 2WZdcFMqEUnJ5iF2oRK3WyxaWjpltLPIkSC9k+4+iddMdex68YxJ1wyYVhuOk2nLNzFXIT\n NfoHwHRVobAcTS0P9TcmOwP2XHhDg80=", "X-MC-Unique": "0olYaZuFMSCsMpQ442sWWQ-1", "X-Mimecast-MFC-AGG-ID": "0olYaZuFMSCsMpQ442sWWQ_1775849033", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Fri, 10 Apr 2026 23:19:12 +0400", "Subject": "[PATCH v2 50/67] ui/vnc: report an error for duplicate display id", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260410-qemu-vnc-v2-50-231416f76dc3@redhat.com>", "References": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "In-Reply-To": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=626;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=mfbePML5bipQlj6KwnAkOKEr3720h6Lm42X86FPcooY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0W32iHIweWZQB1LArz4q6UCrapUnPG/4czw\n tBvw3AfInmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFgAKCRDa6OEJdZac\n 5SI9D/9Oy8WwyMVBAry7QePW90J+1nmgeJuBWvwzel4zJ2Ti9PeKZKa3amVIW3bkkRjbX4bDb4s\n xeoMyS7aOyg371Vpkg6Apo87whY3WwUzNu3UIJ0YhCnCQ1YLSMWjPlJA8FMFAo/m3sKROLnVB0A\n E21lPTkmFpqQNVB0bjwNFKa7FlpOk+u/R/Kow/0u1rlwU+Gu7xH8AA07+OndLfDj2Ru4G/DFjVn\n vty3rtUPu5n6XUeFrrgRMCUTGt7BstLmKPLKW8APPo2/guW9DYFoDt8/PSG7ulVOOFQDwsge/Ua\n wkHEnTkDYciBgQdktbYJS6aPgMQ8ZIOLGiDMdyHd/uHq+P1gZxyr3EqyIshsKbeO5ihvBafrWGg\n ny43CKuYekZndVULPKCywMeKtanYqSN+LuLiw3cug30WDniJu8KV4PGezHcRX8gmrMlPxLBL+mK\n iTK5M4d3L2B6Ukj9Qks7xLAb65uIFXg7wsdLaaN9BMcLHX+hrYrleMeXq79nJDZrZN+xILi7dRD\n gqtij97pQiigUwTYpPWssMkYEE4oU3f1jY15An7aVu/nDp339Jtincc8jfHE9XL383n32N5ouO+\n e46itjTLcysN0RjEJ8zKsVcQZNF0RdZ03TYRRF0jluWBDJ23MK2djcfwSjGncWxQSEOjIt6Us9n\n w6aaHlcpHT6mVyg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "7", "X-Spam_score": "0.7", "X-Spam_bar": "/", "X-Spam_report": "(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Returning NULL without setting an error is odd.\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/vnc.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/ui/vnc.c b/ui/vnc.c\nindex c26b581f3ef..6f9cc3f25a3 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3430,6 +3430,7 @@ VncDisplay *vnc_display_new(const char *id, Error **errp)\n VncDisplay *vd;\n \n if (vnc_display_find(id) != NULL) {\n+ error_setg(errp, \"Display '%s' already exists\", id);\n return NULL;\n }\n vd = g_malloc0(sizeof(*vd));\n", "prefixes": [ "v2", "50/67" ] }