[{"id":3676214,"web_url":"http://patchwork.ozlabs.org/comment/3676214/","msgid":"<4030263a-78ea-44e6-a041-16c1f460b13d@linaro.org>","list_archive_url":null,"date":"2026-04-11T22:33:02","subject":"Re: [PATCH v2 50/67] ui/vnc: report an error for duplicate display id","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 10/4/26 21:19, Marc-André Lureau wrote:\n> Returning NULL without setting an error is odd.\n> \n> Reviewed-by: Daniel P. Berrangé \n> Signed-off-by: Marc-André Lureau \n> ---\n> ui/vnc.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/ui/vnc.c b/ui/vnc.c\n> index c26b581f3ef..6f9cc3f25a3 100644\n> --- a/ui/vnc.c\n> +++ b/ui/vnc.c\n> @@ -3430,6 +3430,7 @@ VncDisplay *vnc_display_new(const char *id, Error **errp)\n> VncDisplay *vd;\n> \n> if (vnc_display_find(id) != NULL) {\n> + error_setg(errp, \"Display '%s' already exists\", id);\n\nAh. That should get squashed in patch #48 \"merge vnc_display_init() and\nvnc_display_open()\" and answer my previous question there.\n\n> return NULL;\n> }\n> vd = g_malloc0(sizeof(*vd));\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HenFH6Bs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftT3B1ScJz1y2d\n\tfor ; Sun, 12 Apr 2026 08:33:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBgt3-0005fe-NB; Sat, 11 Apr 2026 18:33:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBgt1-0005fH-G1\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 18:33:07 -0400","from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBgsz-0005D8-VN\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 18:33:07 -0400","by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so33438435e9.2\n for ; Sat, 11 Apr 2026 15:33:05 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d58a414bsm176775275e9.4.2026.04.11.15.33.02\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 11 Apr 2026 15:33:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775946784; x=1776551584; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=O3JOOWd+nXMoryIxrNpHmQG7cMh3rWDpQjH+olW1uPc=;\n b=HenFH6BsYKZQv3VG7Yoh+vp22ryr2KPHwIPzXPTka5cymIi0My+8sCQwFbGZyvLDPh\n iOdoLursMfQxXvLLMFyJ84ODhOGPCPK4ixMnh9MyOGlqO3PL9cjBq7Cv85BxXtb3E6LM\n Jc1Wihh82S6/echc2iR6dvLdYDx1CrNJ7+tCJmLBNtgx+E3GYAAphV+XkBawRQd6ymNo\n G+HW7IHa66s97NCUYpUK+W98HYaLBW5ZxRDOsHG3bmorLnnB/GMqNBLpXAOjuy6qNlVa\n zDcebz9QnHDV9u+RHtTjPxRAH9kLwfetId2vA6lsHcFVX6Rrbl4M860dEKcF+2qIhuzM\n p1Dw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775946784; x=1776551584;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=O3JOOWd+nXMoryIxrNpHmQG7cMh3rWDpQjH+olW1uPc=;\n b=CgwJ6K11MlvC9THwMdkBDwfTpApWdlqSro8rSO0ScCKFFE7xvnMP43XZqN8QcKC+of\n 8NQ0zcu0OtmWTfB2zh6kQ+Lp2thI4frT0NHeL9g4vJyqmw6V7WQJYh7GxuG6G5c+TBmz\n ESPSkXzhhv4d0jM3e98S7Pq3Gj43ghb+p39TU5nBG1YEo2nUtV+RtcPud997Zclf0qYt\n WqKo9QwHoqK44+goHo3V+VanDJbvTPMTrIanWcBB/HFxjd3rMa8ZFzDdkhElSszZFI3b\n JVZdft1wk2ORTgT2+Vmc9VyYt8vamv9XctTB8d+ZnTrBxciid274HBYDBsD0cOmgn9py\n /9Bg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXljFfLqD/nPLdMxv6ME8YYyGfBQIfRnuriTQuIftFoT/362WJwAIXcMrWTeFxzR/D7uJXHH7wvhwmo@nongnu.org","X-Gm-Message-State":"AOJu0YwWlqLRESSyTxTI1KeDdnMQUBAUP6Yd6cOzfo8LpZK55LDApFay\n ZmgaDg91NMEg4eAakHxBylF4k28uKtFVPLj+IHXRwqp8rLE9AdTu/9FVwFA7N0RuHoY=","X-Gm-Gg":"AeBDievANfg2NNlgvi2VuM3dJlGA277upXedlsyFyyrVvrb2hveJQOC9e05EwQUU60Q\n XS5b2ibz+S8TU1Hfxneycd6j5vFTAuaUtuzSV4Xw+PBgG+aHMTZhkMcfsENDnRZR7oPonnjO6As\n ZwJqo95JMqubQ03B7Wbr/ux4oOf0M0yjbAf5QQYIvfUbchnOdFRoZ3E89PzLtWW41jmtJtnXbqZ\n XRmVbdZqgPtlpAfZaiueAO93nTidL549LbwUPsLob4HEax7h7Vs5HoNEs30fW0HgxTLUngrYt2H\n sJkAtJJp2pZDVwExmzIA8Ze3Xxi0Txl+fnI4NvoEi6YrEOKFxIWqB8sGLFuFT5S/906VgYL8s9z\n J+gN7ADKu6WfJxRGEmI9L1A1PMMM+AYJZrroR4pBt/xvZjviVfEMGtn77F611gH93KKK8PmomN6\n LRHTLj3Fv20SZ78mXwwL5WFjz0Inazw3td0eoVJo1rc2pPuVGA+p7ytHTfAPZ2xLX/NIVKQS2b0\n qrN","X-Received":"by 2002:a05:600c:45cf:b0:483:8062:b2f with SMTP id\n 5b1f17b1804b1-488d67b8dddmr103288235e9.6.1775946783886;\n Sat, 11 Apr 2026 15:33:03 -0700 (PDT)","Message-ID":"<4030263a-78ea-44e6-a041-16c1f460b13d@linaro.org>","Date":"Sun, 12 Apr 2026 00:33:02 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 50/67] ui/vnc: report an error for duplicate display id","Content-Language":"en-US","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>\n <20260410-qemu-vnc-v2-50-231416f76dc3@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260410-qemu-vnc-v2-50-231416f76dc3@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]