Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221421/?format=api
{ "id": 2221421, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221421/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409110256.684-1-anthony.roberts@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260409110256.684-1-anthony.roberts@linaro.org>", "date": "2026-04-09T11:02:55", "name": "ui/sdl2: Fix assumption of EGL presence at runtime", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "48e6ce04be2e6fd6077034523f34814613ed6754", "submitter": { "id": 93100, "url": "http://patchwork.ozlabs.org/api/1.1/people/93100/?format=api", "name": "Anthony Roberts", "email": "anthony.roberts@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409110256.684-1-anthony.roberts@linaro.org/mbox/", "series": [ { "id": 499289, "url": "http://patchwork.ozlabs.org/api/1.1/series/499289/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499289", "date": "2026-04-09T11:02:55", "name": "ui/sdl2: Fix assumption of EGL presence at runtime", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499289/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221421/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221421/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=jO69rCjZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs0VR43pkz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 23:03:25 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAp19-0006WV-Fa; Thu, 09 Apr 2026 09:01:55 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <anthony.roberts@linaro.org>)\n id 1wAnAN-0001uC-WE\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 07:03:20 -0400", "from mail-wm1-x335.google.com ([2a00:1450:4864:20::335])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <anthony.roberts@linaro.org>)\n id 1wAnAM-0002XG-E3\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 07:03:19 -0400", "by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-488a9033b2cso8493955e9.2\n for <qemu-devel@nongnu.org>; Thu, 09 Apr 2026 04:03:17 -0700 (PDT)", "from ANTHONY-T14S ([2a02:6da0:45:960:f48b:8163:76f0:5ff6])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488cd1879b2sm33446475e9.8.2026.04.09.04.03.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 04:03:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775732596; x=1776337396; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=l1xmRNO4MPFO4sE6cHQgCqUs4K6g7ptewn3o/ZQpDqU=;\n b=jO69rCjZprtAjlj9SU0WF7pn4nt06G0RsuG3gya0QluwXaVAR6Cp3/AIDr4olbMduQ\n dREPse32+7CdFz8bDMfa/6CuDVcJVXzlAi6QqNRD8AYtfAK3kC7AmeMRn2ku7ZlP1UoU\n eOpu/KUP8XqCEz3ILGTAgIaXenqESgj7+h6E4qHBWEThSDHa4m46ULy5ThifZvcclp7d\n pCe/e0ph5r8nt9q5BY4MdpRcBM36C3wJpDecxCl+AVVHTjEMkDl+qiEi7u08RWg4WKHJ\n U1cMjtXgoR2bMo/SlbX4laDR5EXbwNsTiy/HTn6yet/PyCDTEdjgJwEc1avbS1qoEmDn\n HEQA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775732596; x=1776337396;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=l1xmRNO4MPFO4sE6cHQgCqUs4K6g7ptewn3o/ZQpDqU=;\n b=O9fVYmjvkLAUPelcWReu/Q82O3ncYHvk2N+NhY0CmSpcI3UrLzWVqB/eTpdWPLL4UX\n oTLdewTDE8FHbQBL8e8mC89PvwB4MN0Kmdrw4tjNY+xnx1EB/CODVBXWJewg1kWqzeT7\n Ew6gMYE7xtdea7wpvdbJo++G5P4f0IzMmIVdd34swnMRBu2NCqZot7bWCvpdECuy2nh6\n 0BlYWDd8QvFSIZ7Huu8ufvxzyy6MkuhpgI3pkrh02x3ILILaY/0dk9U0dTLaOpgND8Ze\n Zp1/bGNe2WpnPhpQjqGerATvRZOc4hzHjI/X5TwrFfDLmY1pSko7UKKZDq19uG3gDolI\n TBhQ==", "X-Gm-Message-State": "AOJu0YyT5HBZL2yzaEHdU06hzPnIyIXOds91ECntUZuukaMHanIb1IA5\n dhN5EAaDO9SCyfRNFdxCuWzhhLBanoa1nXM1BnexlsM3OhhhzmBUpnTOp+Z4hqAju9Gpdqn3Tes\n XYthnwF4=", "X-Gm-Gg": "AeBDiev5Qn3RfBWbmbi9dBgulr/G+S8USqd0BIvlcaUOks+uGkbb/ytHtXTlL5l8j2l\n Mj+WmD2AquaKLrNjqdhbXE/7szW3jamW01suGuiD6/aSV8NEgtyOwGByNHMZVnWppIDMKhefFME\n mzT4Go+NWc++2jgFJ9Ez1Eo3Sg7sNsBmGcRVDHrj8yginZRIEdGi8a8oMOiENX1roZ/5RiKIGeS\n IcH96pV18+USddGg62qVFLEmGGpKzQ0rQp4awSMPFoc0FstLK/Fo1+bshwEJ0uZ5s18aInDRrdB\n QW4tOfvKx6Whv/t9L4d6r5ElRnOfcp/Fd4By/SrgjGAO8VovViZfA8qQy/s75KXEddwz72Fj1ex\n hGb0m1RsF/2pXANO+ZMIWYcWl1EHqeg4fgyPr4EZp2rHhRrFtBgh256gXrYoxUrgtYLN1gp5RWr\n mU7lcLP8rENsdTf0hR0wc4txELVNjzwv6rWwkPxg==", "X-Received": "by 2002:a05:600c:444c:b0:488:a977:8de with SMTP id\n 5b1f17b1804b1-488a9770d4amr247443975e9.16.1775732595537;\n Thu, 09 Apr 2026 04:03:15 -0700 (PDT)", "From": "Anthony Roberts <anthony.roberts@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "alex.bennee@linaro.org, Anthony Roberts <anthony.roberts@linaro.org>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PATCH] ui/sdl2: Fix assumption of EGL presence at runtime", "Date": "Thu, 9 Apr 2026 12:02:55 +0100", "Message-ID": "<20260409110256.684-1-anthony.roberts@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::335;\n envelope-from=anthony.roberts@linaro.org; helo=mail-wm1-x335.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-Mailman-Approved-At": "Thu, 09 Apr 2026 09:01:31 -0400", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The original commit had a section of code which worked on the assumption\nthat if OpenGL was enabled at build, it was present on the end user machine,\nand calls could be made to it. This is not always the case (such as Windows\non Arm devices).\n\nThis line should have also included a runtime check.\n\nThis commit moves the relevant line to inside a runtime check for OpenGL.\n\nFixes: 52053b7e0a0e (\"ui/sdl2: Implement dpy dmabuf functions\")\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3347\nSigned-off-by: Anthony Roberts <anthony.roberts@linaro.org>\n---\n ui/sdl2.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/ui/sdl2.c b/ui/sdl2.c\nindex aaaede56e0..987ad334bb 100644\n--- a/ui/sdl2.c\n+++ b/ui/sdl2.c\n@@ -120,15 +120,15 @@ void sdl2_window_create(struct sdl2_console *scon)\n \n scon->winctx = SDL_GL_CreateContext(scon->real_window);\n SDL_GL_SetSwapInterval(0);\n+\n+#ifdef CONFIG_OPENGL\n+ qemu_egl_display = eglGetCurrentDisplay();\n+#endif\n } else {\n /* The SDL renderer is only used by sdl2-2D, when OpenGL is disabled */\n scon->real_renderer = SDL_CreateRenderer(scon->real_window, -1, 0);\n }\n \n-#ifdef CONFIG_OPENGL\n- qemu_egl_display = eglGetCurrentDisplay();\n-#endif\n-\n sdl_update_caption(scon);\n }\n \n", "prefixes": [] }