[{"id":3675317,"web_url":"http://patchwork.ozlabs.org/comment/3675317/","msgid":"<87mrzcjmj4.fsf@draig.linaro.org>","list_archive_url":null,"date":"2026-04-09T13:22:55","subject":"Re: [PATCH] ui/sdl2: Fix assumption of EGL presence at runtime","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Mohamed Mediouni writes:\n\n(Add Stefan to CC)\n\n>> On 9. Apr 2026, at 14:08, Alex Bennée wrote:\n>> \n>> Anthony Roberts writes:\n>> \n>>> The original commit had a section of code which worked on the assumption\n>>> that if OpenGL was enabled at build, it was present on the end user machine,\n>>> and calls could be made to it. This is not always the case (such as Windows\n>>> on Arm devices).\n>>> \n>>> This line should have also included a runtime check.\n>>> \n>>> This commit moves the relevant line to inside a runtime check for OpenGL.\n>>> \n>>> Fixes: 52053b7e0a0e (\"ui/sdl2: Implement dpy dmabuf functions\")\n>>> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3347\n>>> Signed-off-by: Anthony Roberts \n>> \n>> Reviewed-by: Alex Bennée \n>> \n>> -- \n>> Alex Bennée\n>> Virtualisation Tech Lead @ Linaro\n>> \n>\n> Hello,\n>\n> As a related note, modern QEMU is built assuming EGL which Windows does\n> not ship as a system library - and doesn’t support a WGL-only configuration...\n>\n> For those distributing QEMU binaries on Windows, they should bring an\n> EGL implementation along such as the one in mingw-w64-angleproject \n> or Mesa for Windows if they wish to support OpenGL functionality\n> instead of having crashes.\n\nStefan handles the semi-official windows binaries. \n\nGenerally our windows coverage is poor as most developers can only use\nthe mingw cross compilers (if they even check) and we have one Windows\nx86_64 runner via Cirrus which doesn't have bare metal access to the\nhypervisor.\n\nIt would be nice to have better testing coverage in CI but that would\nrequire someone to fund some bare metal runners and volunteer to keep\nthem updated.\n\n>\n> Wonder what’s the best place to document that requirement…\n\ndocs/system/devices/virtio/virtio-gpu.rst\n\nhas a fairly in-depth breakdown of the various moving parts you need.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=JLeHrgkB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs0xr1DT0z1xy1\n\tfor ; Thu, 09 Apr 2026 23:23:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wApLb-0004c7-Qb; Thu, 09 Apr 2026 09:23:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wApLZ-0004bb-Ss\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 09:23:01 -0400","from mail-wr1-x444.google.com ([2a00:1450:4864:20::444])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wApLY-00077q-4m\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 09:23:01 -0400","by mail-wr1-x444.google.com with SMTP id\n ffacd0b85a97d-43cf8fe9c2aso565626f8f.2\n for ; Thu, 09 Apr 2026 06:22:59 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e4f5294sm64127495f8f.35.2026.04.09.06.22.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 06:22:56 -0700 (PDT)","from draig (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id C3B9C5FA6F;\n Thu, 09 Apr 2026 14:22:55 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775740978; x=1776345778; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:user-agent\n :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=b0KvwrJymUbJzIua33NKYuOwjtkD7R74EjdXbvE3sgE=;\n b=JLeHrgkB4sCOc504m67xc11y/rAkmTB0d7qfdvKeZFbKkywiKyJSgJ31yH8miEibp0\n ErrvGt4RlFNzFBgjWns4hFEUdqpzBNFHXINQwWGsnFdKOnK+HScTDsPdIhdnbugJDGoc\n yaEba+8rlbSZTdnxbyPbodw3R7QGaq4CqDem2rExR7hWFtb3WPCg81T2XHHF7F58DDd4\n FKAIgoJCPvQOg7XTOA+2v51IZ1kkPkSLqee8Uk5jbzObSSMOd6A211SOom3cVclkYi9/\n aieVvbPDO4FMbVqJi9zMnm1D9/L5sTPzeYcvJstDgIkk/HDMjnKqA+3qAb58N1Byjmjq\n zGuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775740978; x=1776345778;\n h=content-transfer-encoding:mime-version:message-id:date:user-agent\n :references:in-reply-to:subject:cc:to:from:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=b0KvwrJymUbJzIua33NKYuOwjtkD7R74EjdXbvE3sgE=;\n b=Ehmvmf+jn8F49ej9+/b5+GXRzVibKNtuEGg6F4TYGou0WxPoOaKaDl32AhPcIEUR4I\n Y8mINBITcS/gH5wmwosWBm33jRpwxGykaI2hMG9hRttjj6C9uUVSSFBsYvkvJQ6bZm6C\n VqIBfKHroNP8h9InsxkDqTxKZluYRJhwQHCnDW5l2lcFCg1MbKwPiikM5RYY4mP+XTNZ\n j9oYJxfihUMseyZGZCsM0QsT+KEKVQj8q/P8gqLXJy0YS31T0rXxODYNiR5YjFo75dJj\n joLSbDG4B3k5DPg7s1G4vtFp+xqpluXyOVN51H8o89VKXo/48+LlaPkX2f+zo3JdWmcS\n fAbQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVnZXKfMbHagsJ19vEJ6ZRaWT4iuDyf0EwrRTFVt52cjkWkP5ESp46Bvw0oHksY7Y1Fs88bwdLKXvBw@nongnu.org","X-Gm-Message-State":"AOJu0YxKWNvWkZIV7T0jy6VLgu+dQiyGsMmcxYnmabtT9hP6ahVxygRo\n d4wi5XEqdAnbgaJwGA+huQpPuIgMs8qjo0Q2nmzVYRR5Q+1x0Xmaya1UBgfxoGRyvdZjzEXPYNd\n NYwhRHPOw4Q==","X-Gm-Gg":"AeBDieuwpClwZJ3HYPfwEdUiKS5P2evYMgbXfaaY0PBXDftZwpzM1sEpvBRu5ANlDyq\n 0HSxKyUBA6dAGMslMYeVviFMf8kFQFyw9dYkgssBlUVNH+rcHLOesyyp1gf3J5H+VlZoaooYafT\n pze/LpqO11ZHX2dzuDC5rHnWubO4AOs9/fbyTvPWG157Vr6ISp72eUf/TW64rRTMFM81cDWpYlK\n BqonOSblXCYFYl5CfweOXJcsRWFPKkBaa9hAq6GqldC7JZK7FjafxPMDlLPTakrZM2kWjQxBlMK\n 0EBeR6Lz03ma13OHgKbdM4dzIoeLxv7KPEdaCNHZpgVo5//Y0kQU+vWxMva0JZKQ5x9gUQ9Hs9o\n aSf+k/g4EElkgmsrQsfqnkW7mQAmxtyq31ORIK/dgGLJiHEFYXZEZOs1aiTbYrufIzpAMf53dbX\n 3pX+pvtypzECNxAbs0yQvk1vo=","X-Received":"by 2002:a5d:588c:0:b0:43d:1cec:4766 with SMTP id\n ffacd0b85a97d-43d292e3a26mr37404760f8f.23.1775740977136;\n Thu, 09 Apr 2026 06:22:57 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"Mohamed Mediouni ","Cc":"Anthony Roberts , qemu-devel@nongnu.org,\n\t=?utf-8?q?Marc-Andr=C3=A9?= Lureau ,\n Stefan Weil ","Subject":"Re: [PATCH] ui/sdl2: Fix assumption of EGL presence at runtime","In-Reply-To":"<627204A0-8806-4420-97A2-CBDC36C41981@unpredictable.fr> (Mohamed\n Mediouni's message of \"Thu, 9 Apr 2026 14:21:59 +0200\")","References":"<20260409110256.684-1-anthony.roberts@linaro.org>\n <87qzoo9vzu.fsf@draig.linaro.org>\n <627204A0-8806-4420-97A2-CBDC36C41981@unpredictable.fr>","User-Agent":"mu4e 1.14.1-pre1; emacs 30.1","Date":"Thu, 09 Apr 2026 14:22:55 +0100","Message-ID":"<87mrzcjmj4.fsf@draig.linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2a00:1450:4864:20::444;\n envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x444.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3675495,"web_url":"http://patchwork.ozlabs.org/comment/3675495/","msgid":"","list_archive_url":null,"date":"2026-04-09T20:18:37","subject":"Re: [PATCH] ui/sdl2: Fix assumption of EGL presence at runtime","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Thu, 9 Apr 2026 at 13:09, Alex Bennée wrote:\n>\n> Anthony Roberts writes:\n>\n> > The original commit had a section of code which worked on the assumption\n> > that if OpenGL was enabled at build, it was present on the end user machine,\n> > and calls could be made to it. This is not always the case (such as Windows\n> > on Arm devices).\n> >\n> > This line should have also included a runtime check.\n> >\n> > This commit moves the relevant line to inside a runtime check for OpenGL.\n> >\n> > Fixes: 52053b7e0a0e (\"ui/sdl2: Implement dpy dmabuf functions\")\n> > Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3347\n> > Signed-off-by: Anthony Roberts \n>\n> Reviewed-by: Alex Bennée \n\nApplied to git directly, as requested.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=nRk/sVZt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsB9F37XZz1xy1\n\tfor ; Fri, 10 Apr 2026 06:19:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAvq0-0000wv-Ts; Thu, 09 Apr 2026 16:18:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAvpz-0000wl-KW\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 16:18:51 -0400","from mail-yx1-xb12a.google.com ([2607:f8b0:4864:20::b12a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wAvpx-0007n3-Ut\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 16:18:51 -0400","by mail-yx1-xb12a.google.com with SMTP id\n 956f58d0204a3-6505ef94043so1400139d50.2\n for ; Thu, 09 Apr 2026 13:18:49 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1775765929; cv=none;\n d=google.com; s=arc-20240605;\n b=GsqvqamZkPRUV/3gadQYy+mxIpPQ1f9FlooDNwKiA21EoP6PJ8vcOrw8ZMaG9B4ane\n 6n3bjvc83ukH+WSHZK9OLJjYtkpxyWBVTHrhExNLRQlYCOPv8I5f/lzG9HMCKpWsU78l\n c8rKRJU36dcvypcHRK3f4fhYL8J6HnTpdLNIlqG407q71Kz8Bx3exlkG3rnROLtT7X4F\n jxHElafq503p2Yf+zEowbX0yhtwqC3z4zQPHHhLfc+xNp2ghe34bMAsWf97DN70nF/9m\n ePRdaGsqduzljwJ5E57hfLl5XQKLMTB1dwj4CfcS/ZcAi77joYfspBlbtiv44diU/lsw\n WV6w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=4plR2ELqZYXgy0a8tUDJL86AodK9YMya5DajTn+4JH4=;\n fh=JqUq8MrIlWC9x6+SgSpz3yeZ6a4MgfoXe4ZGO/gz6y4=;\n b=eaN2OhcyCYAfLg3sMCO0cAdJmo1BqxMFdI+9y71i/5zoW3/rYdOgiIaCa6vpCIaZy6\n EJ11slASIkw+QDuBtJymiQ10x+0DVSoMBafzqM/1ezU3NVM0e2knpkQygy1BA16HSbf0\n nFg0AGOlX+iWRsmf+O0f0czlXfk/EaQ+x9mr/PFVMO6Q54yKMCZ5QHwBvpPNfr0rKORZ\n agD0y7L/nnCIRrIbi4r1PP62xmeVP5/op0fFEMenwoRqCZD4GYaUxkLrzqY//oajlOU/\n PNsXskfU2RAhoKzlJnTNH8llufjWKSeeANCAXEA1DVSH9E24cN55utLI44HVpQ8QlFTN\n atQA==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775765929; x=1776370729; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4plR2ELqZYXgy0a8tUDJL86AodK9YMya5DajTn+4JH4=;\n b=nRk/sVZtf1X1k8yQNjEc7FBsr1On6UviENUDmGUk/BwK8WkL907hMRivD255t+Sw5o\n BzK56uDHIqKZj1dQxGQEg46WdaUDZbZW2tZse5Kqt8UPUaQ6apttZHDeq1bOaJBbvKrp\n iQ9HRDrH5Z/Tfhb1zZHtxOPl1ajWdZ8LOFlkndievA3krCULVcXzKAOLUDsDrWitlVQB\n qK033YQuC09NWNTGNyoQi40jscIZD/988GXSHg8rOpFugEmFSBOesPFMWtfl1Y68xt8f\n +HZd7MckPjwV3D+bmTIcxIALDCafelZlvm2hMrRkQ2PO+EZYxxxnoZuPeBO2g53tT4yd\n ibag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775765929; x=1776370729;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4plR2ELqZYXgy0a8tUDJL86AodK9YMya5DajTn+4JH4=;\n b=HiI9XveaxyRrLQxvTfQ41ynzocjdrWXaQrbeUXhjzLtZ4EfWE7j9eIpIPiJyr245as\n 34OBhnxdQLEtVHjMtqE9kLnX7Xoxy6Y+wt88daTSZZXXWBTLw0HcwaMMrnm0TMwq9Bsg\n 22dXUUXadb0jBWd8lCbKD9kzETrxc2LKFwC+XYiPxbSyuwEvmdmDjbpuHCL3uPYZXKXF\n GdWReJEjd5da2YgTwqSgzFEU6AIipjfRBRrklm1n1/XHxCpWqnf+X4uWVxZkwtmMngea\n CgPD2hkGiF4OGlT52i1XhtqkNZ6JIk20TjmYdDdtGcBCL0xR2KER+m4pL2kQMjj5kdyb\n CtNw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUx9abdwUyjhrUD4vFnLaFQPjh1btfoyWnyCUzREuPDMQSXB9ldJblyXkn5EIu1S4dhj3ci84Ruf6hp@nongnu.org","X-Gm-Message-State":"AOJu0YwyICWfkwt1boq1+yNVBlgVdPhFHupUIps/i4N+RelXNZR7hjzN\n ElKevlalGswP4JfoAxyQy3Bhr+5qGuIDW1cReovyoBbZvgRgwMjiG/2Rz+tzTm/NYh+8UDws6DP\n ijtc3XLziBl+sF6XHAn1bcIMCf7rEGey4xJIAh9wt1A==","X-Gm-Gg":"AeBDietLIcbp3WPgiHJMvLplGwDwtsyLK7Hb3EPO3NScA87RkHYAaWH76DSVLbw+59E\n tb7z3tnNlDqlVnQS4M26BlzJ58l2QYy1yCL+omufAd9zsz6/jAIlJw67H2VFUTidykvTnOXpEp0\n U8Imh8pBRuPGh0snVS+oYfE5eYKk5z8QcID7z2nlovcyILrQXtPIAImrnHBVHneAiGqhlefvNI+\n ECo0nRJh7wyGWtf3QAI+I9Km53Fu9y+iCqLEqeIwUmqucYxBz0ZJy48irZmIwTwaPoaMR6dNblh\n JtsaO/RyCmsxLc4jiDSILvThLHH/EXRqxI/Vr0sAN+L8qpIByYDHoczeyg+P9Ssp5LA=","X-Received":"by 2002:a53:b174:0:b0:650:8923:5618 with SMTP id\n 956f58d0204a3-65198bd4155mr288604d50.57.1775765928729; Thu, 09 Apr 2026\n 13:18:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20260409110256.684-1-anthony.roberts@linaro.org>\n <87qzoo9vzu.fsf@draig.linaro.org>","In-Reply-To":"<87qzoo9vzu.fsf@draig.linaro.org>","From":"Peter Maydell ","Date":"Thu, 9 Apr 2026 21:18:37 +0100","X-Gm-Features":"AQROBzC3wDWKbiJK8Q3XOXR-HuMw_NfQAZHN8d_A6mx5NrUtx0zgYqHt4KnMGkA","Message-ID":"\n ","Subject":"Re: [PATCH] ui/sdl2: Fix assumption of EGL presence at runtime","To":"=?utf-8?q?Alex_Benn=C3=A9e?= ","Cc":"Anthony Roberts , qemu-devel@nongnu.org,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b12a;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb12a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3678834,"web_url":"http://patchwork.ozlabs.org/comment/3678834/","msgid":"<87zf31pm9e.fsf@draig.linaro.org>","list_archive_url":null,"date":"2026-04-17T16:47:09","subject":"Re: [PATCH] ui/sdl2: Fix assumption of EGL presence at runtime","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Anthony Roberts writes:\n\n> The original commit had a section of code which worked on the assumption\n> that if OpenGL was enabled at build, it was present on the end user machine,\n> and calls could be made to it. This is not always the case (such as Windows\n> on Arm devices).\n>\n> This line should have also included a runtime check.\n>\n> This commit moves the relevant line to inside a runtime check for OpenGL.\n>\n> Fixes: 52053b7e0a0e (\"ui/sdl2: Implement dpy dmabuf functions\")\n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3347\n> Signed-off-by: Anthony Roberts \n\nAs this got missed I've queued to virtio-gpu/next, thanks.\n\n> ---\n> ui/sdl2.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/ui/sdl2.c b/ui/sdl2.c\n> index aaaede56e0..987ad334bb 100644\n> --- a/ui/sdl2.c\n> +++ b/ui/sdl2.c\n> @@ -120,15 +120,15 @@ void sdl2_window_create(struct sdl2_console *scon)\n> \n> scon->winctx = SDL_GL_CreateContext(scon->real_window);\n> SDL_GL_SetSwapInterval(0);\n> +\n> +#ifdef CONFIG_OPENGL\n> + qemu_egl_display = eglGetCurrentDisplay();\n> +#endif\n> } else {\n> /* The SDL renderer is only used by sdl2-2D, when OpenGL is disabled */\n> scon->real_renderer = SDL_CreateRenderer(scon->real_window, -1, 0);\n> }\n> \n> -#ifdef CONFIG_OPENGL\n> - qemu_egl_display = eglGetCurrentDisplay();\n> -#endif\n> -\n> sdl_update_caption(scon);\n> }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kw2T73u6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy15Q2Tpyz1yCv\n\tfor ; Sat, 18 Apr 2026 02:47:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDmLd-00073z-N6; Fri, 17 Apr 2026 12:47:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDmLZ-00073X-Qu\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 12:47:14 -0400","from mail-wm1-x342.google.com ([2a00:1450:4864:20::342])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDmLY-0005lF-3z\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 12:47:13 -0400","by mail-wm1-x342.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so13519695e9.2\n for ; Fri, 17 Apr 2026 09:47:11 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc1c0354sm50295405e9.11.2026.04.17.09.47.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 09:47:09 -0700 (PDT)","from draig (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 212325F94F;\n Fri, 17 Apr 2026 17:47:09 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776444430; x=1777049230; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:user-agent\n :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nQ4h1UD4AUxGiWPVBEk10Epis/sCNJJ+eXo3oJDn2hc=;\n b=kw2T73u6/Mi6rq4P7s1eNO/CRafvxcl7ZH3auVk1S+pdd09T7QmTzbNglfSTCTa/wu\n g3AkJos30mJHOLfzP+UeJUe4nPWt+60hguDckAOT9o585hIqteB54WVLeImJvkRVLCiV\n vhEnfIz84gzzChv+DvR5j3/U+fqutw9qp4t5TlaTLXXIFMJrmIvuTw1Nf6X1QRetMxjm\n wmrEsIOrFQe8k9aKHFV84M3m+xG0a9qmpl/ecC1UV433jIbLDusl99FnjqHvaYUV2oTx\n GtWXU/fIiTRP3h9FSfJhv/ya65YnTzeae8P0Ij+GbNtsazUkNrFop5ZhoTOpUTcDZPqW\n EOTQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776444430; x=1777049230;\n h=content-transfer-encoding:mime-version:message-id:date:user-agent\n :references:in-reply-to:subject:cc:to:from:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=nQ4h1UD4AUxGiWPVBEk10Epis/sCNJJ+eXo3oJDn2hc=;\n b=b52QDjWb8uLJUKtOMcds98rXuEHRhB/74BhzeZbSeQJTiWkrdwAzHsDgYzyvtV7wuO\n 8nflxCt2bFlcGJnhdrigTbS4eS/Zz/C3ABcg1bIBfjBm/beI4jX2t6GhRhDpoNHGhMx9\n S88K52XQUi+9Ktak1nToCA0nu4GPZCV0ZDbuqzCw3YGAlZs+SEyW3/d+NOQx6sWui01V\n wMvVWNlTE070hUBjbMxdMRrR7uPzwI25Zc9i84A+glVjk+MryVX4ZI/8a1GnKXymua/S\n PhcvKyKIvotVaTBMv91fX5K8AeJT2UgRUcLwTYGZkSQhKQcbbLuMHCpJ2TAhPSThoh+3\n /vhw==","X-Gm-Message-State":"AOJu0YzVeut7LET/8dqwcAnneUxz4Hu9CPsKnQvfDuKndoURRiK8DHEM\n 0COZnWzRT8fhab+r7phGnu+gFTZt0boBTm5ow5emPb+96nEAuO2x9Smkp9SqSIdfnqKwtngC871\n ySceM/9Hwhg==","X-Gm-Gg":"AeBDievjzmiqLVulCrSQN8pYroNJMbKTe6PmFFPtUbwq8DXWIKt4D3/bRPZ4cu1oRcU\n LzcNZFUxybALmxwWLfv2C6aGk96INHvyPGmdRe7FOMcD2bU2IcOMaG+NsNfqLyWWMR26ZDNUjNc\n A5lUvpUoU/B9l/BgAQBpqa9SIzS3Z1mXOh2KDKRHd2qsHcFJMS6uSUryTz703XfQuObGv9xIQcR\n kjifU/xDvuCo//+GFzTCYPIoBOhBAp1NPNvly2CuBuBfGuc95lkVPab4OUJTeluIbLLppAA5pZh\n yvh/zGrvFfNT0T2h4ru1esstUXC7QJXk5L5aHj3l4cEvQ9KEtIh2d08eEXQ3QXtf6BqijSoMuFq\n z/kcW3kv8h2f7ktg5ovV5FbC0GLInASu2cifN7JCwjYobu3CvbA60wfn/wbLPYkXcmF8dQr8yXe\n /rZnhUlPSJyZBYFXB1yBieOEpuBlTP+1bxAg==","X-Received":"by 2002:a05:600c:8582:b0:485:4006:960c with SMTP id\n 5b1f17b1804b1-488fb7710e1mr40723245e9.16.1776444430491;\n Fri, 17 Apr 2026 09:47:10 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"Anthony Roberts ","Cc":"qemu-devel@nongnu.org,\n =?utf-8?q?Marc-Andr=C3=A9?= Lureau ","Subject":"Re: [PATCH] ui/sdl2: Fix assumption of EGL presence at runtime","In-Reply-To":"<20260409110256.684-1-anthony.roberts@linaro.org> (Anthony\n Roberts's message of \"Thu, 9 Apr 2026 12:02:55 +0100\")","References":"<20260409110256.684-1-anthony.roberts@linaro.org>","User-Agent":"mu4e 1.14.1-pre2; emacs 30.1","Date":"Fri, 17 Apr 2026 17:47:09 +0100","Message-ID":"<87zf31pm9e.fsf@draig.linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2a00:1450:4864:20::342;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x342.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]