Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221202/?format=api
{ "id": 2221202, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221202/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408031725.641417-1-zhaoguohan@kylinos.cn/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408031725.641417-1-zhaoguohan@kylinos.cn>", "date": "2026-04-08T03:17:25", "name": "ui/spice-app: detect runtime directory creation failures", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0ebb9c0a39c706f82d252aa80a0b6aaf200184d5", "submitter": { "id": 92952, "url": "http://patchwork.ozlabs.org/api/1.1/people/92952/?format=api", "name": "GuoHan Zhao", "email": "zhaoguohan@kylinos.cn" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408031725.641417-1-zhaoguohan@kylinos.cn/mbox/", "series": [ { "id": 499204, "url": "http://patchwork.ozlabs.org/api/1.1/series/499204/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499204", "date": "2026-04-08T03:17:25", "name": "ui/spice-app: detect runtime directory creation failures", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499204/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221202/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221202/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYQh66kCz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 05:43:40 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAYWZ-0007Sq-Ap; Wed, 08 Apr 2026 15:25:15 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhaoguohan@kylinos.cn>)\n id 1wAY71-0007Vb-Kx\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:58:51 -0400", "from mailgw.kylinos.cn ([124.126.103.232])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhaoguohan@kylinos.cn>)\n id 1wAJQS-0001LE-1Z\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 23:17:58 -0400", "from localhost.localdomain [(116.128.244.171)] by mailgw.kylinos.cn\n (envelope-from <zhaoguohan@kylinos.cn>)\n (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256)\n with ESMTP id 1481549653; Wed, 08 Apr 2026 11:17:48 +0800" ], "X-UUID": [ "84d4ddb832f911f1aa26b74ffac11d73-20260408", "84d4ddb832f911f1aa26b74ffac11d73-20260408" ], "X-CTIC-Tags": "HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME,\n HR_CHARSET\n HR_CHARSET_NUM, HR_CTE_8B, HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD\n HR_DATE_ZONE, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM\n HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_CHARSET, HR_TO_CHARSET_NUM\n HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NAME, IP_TRUSTED, SRC_TRUSTED\n DN_TRUSTED, SA_UNTRUSTED, SA_LOWREP, SA_EXISTED, SPF_NOPASS\n DKIM_NOPASS, DMARC_NOPASS, CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS\n GTI_RG_INFO, GTI_C_BU, AMN_GOOD, ABX_MISS_RDNS", "X-CID-O-RULE": "Release_Ham", "X-CID-RULE": "Release_Ham", "X-CID-O-INFO": "VERSION:1.3.12, REQID:21705341-a251-44ec-b80e-6fa56709a50d,\n IP:15,\n URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-30,FILE:0,BULK:0,RULE:Release_Ham,ACTI\n ON:release,TS:-15", "X-CID-INFO": "VERSION:1.3.12, REQID:21705341-a251-44ec-b80e-6fa56709a50d, IP:15,\n UR\n L:0,TC:0,Content:0,EDM:0,RT:0,SF:-30,FILE:0,BULK:0,RULE:Release_Ham,ACTION\n :release,TS:-15", "X-CID-META": "VersionHash:e7bac3a, CLOUDID:111e8b26c11240dc7a0a63084f48b8af,\n BulkI\n D:260408111718OAURA2JV,BulkQuantity:1,Recheck:0,SF:10|66|78|102|123|127|85\n 0|898,TC:nil,Content:0|15|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS\n :nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,A\n RC:0", "X-CID-BVR": "2,SSN|SDN", "X-CID-BAS": "2,SSN|SDN,0,_", "X-CID-FACTOR": "TF_CID_SPAM_SNR", "X-CID-RHF": "D41D8CD98F00B204E9800998ECF8427E", "X-User": "zhaoguohan@kylinos.cn", "From": "zhaoguohan@kylinos.cn", "To": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Cc": "qemu-devel@nongnu.org,\n\tGuoHan Zhao <zhaoguohan@kylinos.cn>", "Subject": "[PATCH] ui/spice-app: detect runtime directory creation failures", "Date": "Wed, 8 Apr 2026 11:17:25 +0800", "Message-ID": "<20260408031725.641417-1-zhaoguohan@kylinos.cn>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=124.126.103.232;\n envelope-from=zhaoguohan@kylinos.cn; helo=mailgw.kylinos.cn", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: GuoHan Zhao <zhaoguohan@kylinos.cn>\n\nspice_app_display_early_init() creates the per-VM runtime directory\nwith g_mkdir_with_parents() before setting up the Spice socket. The\ncode checks for \"< -1\", but g_mkdir_with_parents() returns -1 on\nfailure, so the error path is never taken.\n\nThis lets spice-app continue after a directory creation failure and\ndefers the problem to later setup steps.\n\nCheck for \"< 0\" instead so the failure is reported immediately and\nspice-app exits before using an invalid runtime directory.\n\nFixes: d8aec9d9f129 (\"display: add -display spice-app launching a Spice client\")\nSigned-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>\n---\n ui/spice-app.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/ui/spice-app.c b/ui/spice-app.c\nindex 9e55f2737159..0df7325e6792 100644\n--- a/ui/spice-app.c\n+++ b/ui/spice-app.c\n@@ -151,7 +151,7 @@ static void spice_app_display_early_init(DisplayOptions *opts)\n if (qemu_name) {\n app_dir = g_build_filename(g_get_user_runtime_dir(),\n \"qemu\", qemu_name, NULL);\n- if (g_mkdir_with_parents(app_dir, S_IRWXU) < -1) {\n+ if (g_mkdir_with_parents(app_dir, S_IRWXU) < 0) {\n error_report(\"Failed to create directory %s: %s\",\n app_dir, strerror(errno));\n exit(1);\n", "prefixes": [] }