[{"id":3674961,"web_url":"http://patchwork.ozlabs.org/comment/3674961/","msgid":"","list_archive_url":null,"date":"2026-04-08T05:40:26","subject":"Re: [PATCH] ui/spice-app: detect runtime directory creation failures","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"Hi\n\nOn Wed, Apr 8, 2026 at 7:18 AM wrote:\n>\n> From: GuoHan Zhao \n>\n> spice_app_display_early_init() creates the per-VM runtime directory\n> with g_mkdir_with_parents() before setting up the Spice socket. The\n> code checks for \"< -1\", but g_mkdir_with_parents() returns -1 on\n> failure, so the error path is never taken.\n>\n> This lets spice-app continue after a directory creation failure and\n> defers the problem to later setup steps.\n>\n> Check for \"< 0\" instead so the failure is reported immediately and\n> spice-app exits before using an invalid runtime directory.\n>\n> Fixes: d8aec9d9f129 (\"display: add -display spice-app launching a Spice client\")\n> Signed-off-by: GuoHan Zhao \n\nReviewed-by: Marc-André Lureau \n\n> ---\n> ui/spice-app.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/ui/spice-app.c b/ui/spice-app.c\n> index 9e55f2737159..0df7325e6792 100644\n> --- a/ui/spice-app.c\n> +++ b/ui/spice-app.c\n> @@ -151,7 +151,7 @@ static void spice_app_display_early_init(DisplayOptions *opts)\n> if (qemu_name) {\n> app_dir = g_build_filename(g_get_user_runtime_dir(),\n> \"qemu\", qemu_name, NULL);\n> - if (g_mkdir_with_parents(app_dir, S_IRWXU) < -1) {\n> + if (g_mkdir_with_parents(app_dir, S_IRWXU) < 0) {\n> error_report(\"Failed to create directory %s: %s\",\n> app_dir, strerror(errno));\n> exit(1);\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=gglKICR1;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=A7DQUD21;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYRc3w48z1xy1\n\tfor ; Thu, 09 Apr 2026 05:44:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYaw-0001CP-3j; Wed, 08 Apr 2026 15:29:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAY8v-0000Am-72\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:00:49 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wALed-0000JU-Eb\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 01:40:45 -0400","from mail-pj1-f72.google.com (mail-pj1-f72.google.com\n [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-34-U26elcI3Ms20ABWY4Gjafg-1; Wed, 08 Apr 2026 01:40:39 -0400","by mail-pj1-f72.google.com with SMTP id\n 98e67ed59e1d1-358e95e81aeso13334997a91.0\n for ; Tue, 07 Apr 2026 22:40:39 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775626841;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1GaYXssJET9HUuN8qmmpMmIRItyV5vk+8O1bNepNsjg=;\n b=gglKICR1Gnp74dto23+6jCq3uFe/MPsqG7qyZnLF7mJSP1DXCn+AVXA2NUyrPFa6pDyd1o\n qqgIVOjYKkeJRBVWKysRQ08uwOBlU1b1wSXEDKV9lR3jAP9MsSWgcqZ/Qe2Hm/YDZqEdXX\n +D8tdioldd2zdhIg3AgkP3hxM2ellPc=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775626838; x=1776231638; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1GaYXssJET9HUuN8qmmpMmIRItyV5vk+8O1bNepNsjg=;\n b=A7DQUD21dfY8xDWoZsPvxAHAICbnSUPoXgem+QOqqm9aqBJNm0gIgcFLaMzn4/HjOF\n O8/1RU+AQR7vJTL+FOxWTWbLDKMo7LiJaSdhHG2/dpfCUuWEX6UG/hxNrXn1ZiicKY4i\n g5ULZyUtJbsLgiPMEvm1CyzK1ojT2CA9Z3wUULViKeyYSedkXe/NBLhH/POZjp3va6m8\n aO05OBWtRQtNTL49ZAUr0D3EFvB3Ko6pgUYDViRXXchnsLqPZRDPE51HKNC3/PzFa1hb\n d9whp0gRvs0mta5Y+M6dtxLUY9pHGpxkjJB7fcly7swk7BNNx/kRMdJh9/UNgHBchkee\n 5HNw=="],"X-MC-Unique":"U26elcI3Ms20ABWY4Gjafg-1","X-Mimecast-MFC-AGG-ID":"U26elcI3Ms20ABWY4Gjafg_1775626839","ARC-Seal":"i=1; a=rsa-sha256; t=1775626838; cv=none;\n d=google.com; s=arc-20240605;\n b=fDOHyNTAOeghXFDGJxpWMmn6WeaNjb+A4k/tTTbz20XUU9ZhoT9RLxUtua3pa7qhAF\n NvXu7DQXdJvunRKJxWys3DPr9RBdJsmp5sPBjDLjAA6bFH7eoR7fN6I8YFQB6riQ5mFL\n qCAGiBNnUGJodtJWSANq17gO4CRz/tdEqsKQCQf8lx4taHaq/8FFclN2bs7eU/6USQJG\n VvGfR7e3SEvuCFN9GpiWAMqn89ctxkj48UyytpZv+HhWHSXggimu72VmFMP3Mm1oZL1v\n XowWSES3BE8ePJXZ8p3td76TMI8YGDB26m6rl2nEwJYNhlHrS760HeMYOn7KlUJCJ7vx\n GArA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=1GaYXssJET9HUuN8qmmpMmIRItyV5vk+8O1bNepNsjg=;\n fh=J0lI+6V1e8A1yyN2nd5Guz99SJqLbGXMn75K4Y7Xiz8=;\n b=jCzdS4sZ2pkyxan8O/LgbRAzjiEQYCNjiewQbWmnkPUUqubqnaWLDDHJ7OQeh0FG44\n M4x4ioHAJcm1SAEmM7qLUoixLOTVhKERNn14eMDcVqWQSXlluDttIqBrmjadXBMgveUz\n tg47nGsrCv8PK5WRbaUIpBAJRNtPN4BjeBfMIFw2JGH7EPuRbOnZMvYtYsNL2smDJxSB\n ap+COWitw360ofTl/ohojCCZWsHpR4z9cmGAMwGWxJfcD+x0xxUpvRW/XyXZetlK5FQo\n PT1l+hjFuYWspfdWVXSPQFUCwmO5DKffYO1BsANCZ2npSDW16Bw+AG+5Cbr/OaSuH6sK\n 6lUg==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775626838; x=1776231638;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=1GaYXssJET9HUuN8qmmpMmIRItyV5vk+8O1bNepNsjg=;\n b=GJXbHbJ7jg6ArtHrlbuKHSvxZp8pFbZGV5nSSQ4+QrhxtcEHBTJnBuiHx39vgpchgc\n 5OOI4wZ2pk4+bv4/xNovq9DoMaC7acYrxBzes2Ql7grdcfmmBR+IBIYDEgbR9QrH2HMA\n mdx8IJcg5Tn+uERPqoEi4tVvqb54TcOxnjWkN10s5pkCT3/36GY+IkDG9v4N6PKXLz/2\n XWODJemllUF0TTNlT9QRopBEIrctvmnqLCrl+3J4VBf4ZuqNjlK8URQKsUv9NzpE/H6X\n 4TowHUbmlFXQ9SnAnJlKSRnvqvpGGDk464su0cDDw3ONKc07fOaYXHiBYuflUuxG+Btx\n C6gA==","X-Gm-Message-State":"AOJu0YzyvdtA6VvzkCWQxJvpr57YUYSlEZSG+B5W9237Us1+NEQ2LXg+\n oW5fqcwKvhQPHve0Y+Tq/F62bIi2ze1S8murqEGbDWWd/7ZNc2uIiLniIubuvEDJe3g1DphsR9a\n F+jSQsRUswIzCKm1yxhJXct/rxNtbZCz6Dah55G58Y0LnVzrn7Sfo7lSIRf8DBc9soR/xyNg0z0\n 2o6UN2+vjz3qRzAxNR48SrHXGrYUiiFzxuTLjn+r5ruA==","X-Gm-Gg":"AeBDieuQpzhwtBJLB8+rfhFefkTTW/W9eN1F+lAOReguziQQFAIoqJO4fs9YKbkF5Ct\n pErx9M6M0psw9+B0oLla7ltJ24Lo4ZUMMjIC3jK81e3JSZT3MU3JzC1fGTnYF+s12fb/E6T3Y29\n JA6sdUdS4IauSNtHpKPC6AUgVIjHx1+Jn+XjWM4XUySUOapgPTGPDGGtdcGNMJVyTdu3MjHxtB7\n 0OdKbHJlpSoI+WfBEKkZFWq2sZ8Slrn4jL0Y+G1/hSl6m9EAbww5A33bLAE5AEsBbLbfua3UHIQ\n GFht7tZnbgW4E5bhgpIWWEM=","X-Received":["by 2002:a17:90b:3d8a:b0:35b:e4f8:7b2b with SMTP id\n 98e67ed59e1d1-35de68ebaf3mr21279419a91.18.1775626838275;\n Tue, 07 Apr 2026 22:40:38 -0700 (PDT)","by 2002:a17:90b:3d8a:b0:35b:e4f8:7b2b with SMTP id\n 98e67ed59e1d1-35de68ebaf3mr21279385a91.18.1775626837732; Tue, 07 Apr 2026\n 22:40:37 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260408031725.641417-1-zhaoguohan@kylinos.cn>","In-Reply-To":"<20260408031725.641417-1-zhaoguohan@kylinos.cn>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Wed, 8 Apr 2026 09:40:26 +0400","X-Gm-Features":"AQROBzAFhhUboDZvXi8EzRHILwcHfSFw81EIKZwbwelGIdWr7xB8iEikNgPdoSk","Message-ID":"\n ","Subject":"Re: [PATCH] ui/spice-app: detect runtime directory creation failures","To":"zhaoguohan@kylinos.cn","Cc":"qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=mlureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]