Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221077/?format=api
{ "id": 2221077, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221077/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408-jk-even-more-e825c-fixes-v1-4-b959da91a81f@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408-jk-even-more-e825c-fixes-v1-4-b959da91a81f@intel.com>", "date": "2026-04-08T18:46:34", "name": "[iwl-net,4/4] ice: fix ice_ptp_read_tx_hwtstamp_status_eth56g", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "c34298c493c75ddc52655f4ec365d924a1e1bfe8", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/1.1/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/1.1/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408-jk-even-more-e825c-fixes-v1-4-b959da91a81f@intel.com/mbox/", "series": [ { "id": 499189, "url": "http://patchwork.ozlabs.org/api/1.1/series/499189/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499189", "date": "2026-04-08T18:46:30", "name": "ice: E825C missing PHY timestamp interrupt fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499189/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221077/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221077/checks/", "tags": {}, "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=gNFkh/9k;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frX9y1mzHz1yD6\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 04:47:34 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id A0B3641020;\n\tWed, 8 Apr 2026 18:47:32 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id lB0kG_whue7E; Wed, 8 Apr 2026 18:47:31 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C7A6141000;\n\tWed, 8 Apr 2026 18:47:31 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 37BF91F6\n for <intel-wired-lan@lists.osuosl.org>; Wed, 8 Apr 2026 18:47:30 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 1D53440383\n for <intel-wired-lan@lists.osuosl.org>; Wed, 8 Apr 2026 18:47:30 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id uFf3FqzH2ssW for <intel-wired-lan@lists.osuosl.org>;\n Wed, 8 Apr 2026 18:47:29 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.18])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 5114140130\n for <intel-wired-lan@lists.osuosl.org>; Wed, 8 Apr 2026 18:47:29 +0000 (UTC)", "from fmviesa004.fm.intel.com ([10.60.135.144])\n by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 11:47:28 -0700", "from orcnseosdtjek.jf.intel.com (HELO [10.166.28.109])\n ([10.166.28.109])\n by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 11:47:27 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org C7A6141000", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5114140130" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775674051;\n\tbh=6BZRACkg6HCd8QTfUZiajdSXrt4t/7hWMQhstCE5isQ=;\n\th=From:Date:References:In-Reply-To:To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=gNFkh/9kjr7vgu+krO855aRrl44BPtq16mb3E0F3EvdePWFrAAbiqOS0MWW+LcCtt\n\t JZSpDsNcftPGmCDi3tMlv07bBu/+g9x5i597z3ANMgtays356FxWGGeGG8YyVK797r\n\t c8TJOrPP+tLVAB9G9RXn1n9hoDhr6bBrTYtPc0CZeTMgDIxGo8NJTUopkAW4JSSg+y\n\t pehtLlmovcaiW8uZNaeGivkg2mg2G78ddJfc5WBHspUhsYID0E/cYMJqyWsgJus8Gs\n\t +yw9ogsPJUO7kpxfSA58hQ2Lk9HVb+l23CbmqN5czmkhvELqaCFAU8+2jeyemez5e1\n\t gcXkRU7/qmc5g==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.18;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 5114140130", "X-CSE-ConnectionGUID": [ "sIgIqY7+SIOK0And13Xgkw==", "8hAv3SWVTB6eEHvfPYVAnA==" ], "X-CSE-MsgGUID": [ "keuVBjXxQqCacXUzpXLv6A==", "clAReoAlSWaVf9ZvYM4epA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11753\"; a=\"75841382\"", "E=Sophos;i=\"6.23,168,1770624000\"; d=\"scan'208\";a=\"75841382\"", "E=Sophos;i=\"6.23,168,1770624000\"; d=\"scan'208\";a=\"230217570\"" ], "X-ExtLoop1": "1", "From": "Jacob Keller <jacob.e.keller@intel.com>", "Date": "Wed, 08 Apr 2026 11:46:34 -0700", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260408-jk-even-more-e825c-fixes-v1-4-b959da91a81f@intel.com>", "References": "<20260408-jk-even-more-e825c-fixes-v1-0-b959da91a81f@intel.com>", "In-Reply-To": "<20260408-jk-even-more-e825c-fixes-v1-0-b959da91a81f@intel.com>", "To": "Anthony Nguyen <anthony.l.nguyen@intel.com>,\n Intel Wired LAN <intel-wired-lan@lists.osuosl.org>, netdev@vger.kernel.org", "X-Mailer": "b4 0.16-dev-306a9", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1919;\n i=jacob.e.keller@intel.com; h=from:subject:message-id;\n bh=R6AxwX9GU8IMz9cc9hHesk4hswO49vClh2NXD0wCyaU=;\n b=owGbwMvMwCWWNS3WLp9f4wXjabUkhsxri/Y+bSrduCnDdYNNGJPPVBP12JaMpDUuKV9mhBSf5\n lS/e6Gmo5SFQYyLQVZMkUXBIWTldeMJYVpvnOVg5rAygQxh4OIUgIncn87wiyl3veh+2e1PH3JP\n NFr6wmrN072BHdc+fVv19YBH3oOvmr8YGd6s//mjPfNjgKXMGqG9XYfnMcSslPmd8VlFflkDC3N\n EECcA", "X-Developer-Key": "i=jacob.e.keller@intel.com; a=openpgp;\n fpr=204054A9D73390562AEC431E6A965D3E6F0F28E8", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775674049; x=1807210049;\n h=from:date:subject:mime-version:content-transfer-encoding:\n message-id:references:in-reply-to:to:cc;\n bh=R6AxwX9GU8IMz9cc9hHesk4hswO49vClh2NXD0wCyaU=;\n b=WmVl2axIpajhgQfl9wz3i1FqVVUGYT9/BFTpFFxnc0+MqZjXQyf9a0pe\n BIT6yDXNXn8HqkHn2TKKqSzbe/TITvRJXyg3vliGF1q4Sckz7UpSiihkt\n UZyZLIYeJldUA6kBjtgBjfgpsAFi9J0/8j2xtT/kwia6ZswpO/nngioGO\n MvnmdPqe2KrCDZrbR0JTFNyjQPuxRnQFysvjq/hdjA4kMm+Q+dXlQHimk\n xqaSA48QLaSjJL2Ny8sPveeG0jp2VNlYmn6Fegc9Xp5uMRI8yrwC04gsJ\n WawptFwkhbq53ryDWm+mj91vjhv/w3DX7tfoZAVrbv83co6eRzvoiFPV9\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=WmVl2axI" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net 4/4] ice: fix\n ice_ptp_read_tx_hwtstamp_status_eth56g", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Jacob Keller <jacob.e.keller@intel.com>,\n Timothy Miskell <timothy.miskell@intel.com>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The ice_ptp_read_tx_hwtstamp_status_eth56g function calls\nice_read_phy_eth56g with a PHY index. However the function actually expects\na port index. This causes the function to read the wrong PHY_PTP_INT_STATUS\nregisters, and effectively makes the status wrong for the second set of\nports from 4 to 7.\n\nThe ice_read_phy_eth56g function uses the provided port index to determine\nwhich PHY device to read. We could refactor the entire chain to take a PHY\nindex, but this would impact many code sites. Instead, multiply the PHY\nindex by the number of ports, so that we read from the first port of each\nPHY.\n\nFixes: 7cab44f1c35f (\"ice: Introduce ETH56G PHY model for E825C products\")\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\nindex 64ad5ed5c688..672218e5d1f9 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\n@@ -2219,13 +2219,19 @@ int ice_ptp_read_tx_hwtstamp_status_eth56g(struct ice_hw *hw, u32 *ts_status)\n \t*ts_status = 0;\n \n \tfor (phy = 0; phy < params->num_phys; phy++) {\n+\t\tu8 port;\n \t\tint err;\n \n-\t\terr = ice_read_phy_eth56g(hw, phy, PHY_PTP_INT_STATUS, &status);\n+\t\t/* ice_read_phy_eth56g expects a port index, so use the first\n+\t\t * port of the PHY\n+\t\t */\n+\t\tport = phy * hw->ptp.ports_per_phy;\n+\n+\t\terr = ice_read_phy_eth56g(hw, port, PHY_PTP_INT_STATUS, &status);\n \t\tif (err)\n \t\t\treturn err;\n \n-\t\t*ts_status |= (status & mask) << (phy * hw->ptp.ports_per_phy);\n+\t\t*ts_status |= (status & mask) << port;\n \t}\n \n \tice_debug(hw, ICE_DBG_PTP, \"PHY interrupt err: %x\\n\", *ts_status);\n", "prefixes": [ "iwl-net", "4/4" ] }