| Message ID | 20210811032307.11436-2-jeremy.szu@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mute/micmute LEDs no function on HP ProBook 650 G8 | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> The $subject only references OEM-5.10, but I assume you still want this applied to Hirsute/Impish ? On 8/10/21 9:23 PM, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1939473 > > The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is > using 0x02 to control mute LED and 0x01 to control micmute LED. > Therefore, add a quirk to make it works. > > Link: https://lore.kernel.org/lkml/20210810100846.65844-1-jeremy.szu@canonical.com/ > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 70da7e3716b4..22c2f323fbf8 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -8333,6 +8333,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > + SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), >
On 11.08.21 05:23, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1939473 > > The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is > using 0x02 to control mute LED and 0x01 to control micmute LED. > Therefore, add a quirk to make it works. > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com Signed-off-by: Takashi Iwai <tiwai@suse.de> (cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51 linux-next) > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- As Tim mentioned the patch does not ask for this for Hirsute, also the bug report had no nomination for it (added) and neither does for oem-5.13. This is in linux-next now, so UBUNTU: SAUCE: should be dropped when applying with the extended sob area. -Stefan > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 70da7e3716b4..22c2f323fbf8 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -8333,6 +8333,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > + SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), >
Jeremy, This patch has only "[OEM-5.10]" on the subject line but on the cover letter there's also "H/I/U/OEM-5.13". Could you please clarify if the same patche should also be applied to these other kernels? On 11.08.21 05:23, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1939473 > > The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is > using 0x02 to control mute LED and 0x01 to control micmute LED. > Therefore, add a quirk to make it works. > > Link: https://lore.kernel.org/lkml/20210810100846.65844-1-jeremy.szu@canonical.com/ > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> This patch has already been applied to Linus' tree, so the whole provenance block should be: Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com Signed-off-by: Takashi Iwai <tiwai@suse.de> (cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51) Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> And the "UBUNTU: SAUCE:" prefix on the subject line removed. Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> Thanks --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 70da7e3716b4..22c2f323fbf8 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -8333,6 +8333,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > + SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), >
Hi Stefan and Tim. Thanks for the comments. When I drop this patch, it's because the schedule of the OEM project is quite tight. I don't want to use "UBUNTU: SAUCE:" for other series since the patch was only in the maintainer's tree. Thus, I submitted the "UBUNTU: SAUCE:" to OEM-5.10 for meeting the project schedule and plan to work on other series after the patch is landed in the mainline tree. That's why I used [U/I/H/OEM-5.13/OEM-5.10] in the cover letter and submitted the OEM-5.10 with "UBUNTU: SAUCE:" first. In this case, how do you suggest dealing with this? On Tue, Aug 31, 2021 at 9:02 PM Stefan Bader <stefan.bader@canonical.com> wrote: > > On 11.08.21 05:23, Jeremy Szu wrote: > > BugLink: https://bugs.launchpad.net/bugs/1939473 > > > > The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is > > using 0x02 to control mute LED and 0x01 to control micmute LED. > > Therefore, add a quirk to make it works. > > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > Cc: <stable@vger.kernel.org> > Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com > Signed-off-by: Takashi Iwai <tiwai@suse.de> > (cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51 linux-next) > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > Acked-by: Stefan Bader <stefan.bader@canonical.com> > > --- > > As Tim mentioned the patch does not ask for this for Hirsute, also the bug > report had no nomination for it (added) and neither does for oem-5.13. > > This is in linux-next now, so UBUNTU: SAUCE: should be dropped when applying > with the extended sob area. > > -Stefan > > sound/pci/hda/patch_realtek.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index 70da7e3716b4..22c2f323fbf8 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -8333,6 +8333,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > > + SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > > > >
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 70da7e3716b4..22c2f323fbf8 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8333,6 +8333,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), + SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
BugLink: https://bugs.launchpad.net/bugs/1939473 The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is using 0x02 to control mute LED and 0x01 to control micmute LED. Therefore, add a quirk to make it works. Link: https://lore.kernel.org/lkml/20210810100846.65844-1-jeremy.szu@canonical.com/ Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)