mbox series

[SRU,H/I/U/OEM-5.10/OEM-5.13,0/1] mute/micmute LEDs no function on HP ProBook 650 G8

Message ID 20210811032307.11436-1-jeremy.szu@canonical.com
Headers show
Series mute/micmute LEDs no function on HP ProBook 650 G8 | expand

Message

Jeremy Szu Aug. 11, 2021, 3:23 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1939473

[Impact]
The mic mute/audio mute LEDS are not work on HP ProBook 650 G8 Notebook PC

[Fix]
It needs the specific quirk for the hardware layout.
Thus, add the quirks to make it works.

[Test]
After applying the quirk, the audio/mic mute LEDs are working good.

[Where problems could occur]
If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).

Jeremy Szu (1):
  ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 650 G8
    Notebook PC

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Paolo Pisati Aug. 17, 2021, 3:29 p.m. UTC | #1
On Wed, Aug 11, 2021 at 11:23:06AM +0800, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939473

Commit already present in Impish/Unstable (upstream/gregkh's stable).
Stefan Bader Aug. 31, 2021, 1:06 p.m. UTC | #2
On 11.08.21 05:23, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939473
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on HP ProBook 650 G8 Notebook PC
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 650 G8
>      Notebook PC
> 
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
> 
Actually NACK, you have sent the same patch again without NACKing this submission.