mbox series

[0/26,FHI,linux-azure] Update Microsoft MANA to 5.15-rc6

Message ID 20211021122400.10390-1-tim.gardner@canonical.com
Headers show
Series Update Microsoft MANA to 5.15-rc6 | expand

Message

Tim Gardner Oct. 21, 2021, 12:23 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1947859

SRU Justification

[Impact]

Microsoft has requested the addition of MANA EQ-sharing patch set which is essentially everything up through v5.15-rc6.
There are a couple of bug fix patches that are not strictly required, but seemed like a good idea.

3 more patches from Haiyang regarding EQ-sharing for Microsoft Azure Network Adapter (MANA). This saves MSI-X interrupts and allows the host to offer more virtual ports (network interfaces) to the VM. With the patches, the MANA driver supports up to 256 virtual ports per VF (it was 16/VF), and support up to 64 queues per vPort (it was 16).

Hirsute appears to have missed having the MANA driver added while it was in development. This
patch set corrects that overight. Upgrading users from focal/linux-azure to focal/linux-azure-5.11
will cause a regression with respect to MANA.

[Test Case]

Microsoft to test and verify.
A Microsoft engineer manually tested the 3 kernels using iperf, ethtool, and hot-add/remove NIC, and all worked well.
The 3 kernels do use EQ-sharing according to /proc/interrupts.

[Where things might go wrong]

More virtual ports may cause issues in older kernels.

[Other Info]

SF: #00321275

----------------------------------------------------------------
The following changes since commit bc4974dcc627f703ad351c654d53935e52c945ed:

  net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:42:47 -0600)

are available in the Git repository at:

  https://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/focal 

for you to fetch changes up to bc4974dcc627f703ad351c654d53935e52c945ed:

  net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:42:47 -0600)

----------------------------------------------------------------
The following changes since commit 9c595b89e7dd726949c37ab357621a020e7eaaff:

  net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:50:30 -0600)

are available in the Git repository at:

  https://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/hirsute 

for you to fetch changes up to 9c595b89e7dd726949c37ab357621a020e7eaaff:

  net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:50:30 -0600)

----------------------------------------------------------------
The following changes since commit acf854e7401c0911a6527698bffc8bbb6d73864a:

  net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:53:14 -0600)

are available in the Git repository at:

  https://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/impish 

for you to fetch changes up to acf854e7401c0911a6527698bffc8bbb6d73864a:

  net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:53:14 -0600)

----------------------------------------------------------------

Comments

Krzysztof Kozlowski Oct. 21, 2021, 12:40 p.m. UTC | #1
On 21/10/2021 14:23, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1947859
> 
> SRU Justification
> 
> [Impact]
> 
> Microsoft has requested the addition of MANA EQ-sharing patch set which is essentially everything up through v5.15-rc6.
> There are a couple of bug fix patches that are not strictly required, but seemed like a good idea.
> 
> 3 more patches from Haiyang regarding EQ-sharing for Microsoft Azure Network Adapter (MANA). This saves MSI-X interrupts and allows the host to offer more virtual ports (network interfaces) to the VM. With the patches, the MANA driver supports up to 256 virtual ports per VF (it was 16/VF), and support up to 64 queues per vPort (it was 16).
> 
> Hirsute appears to have missed having the MANA driver added while it was in development. This
> patch set corrects that overight. Upgrading users from focal/linux-azure to focal/linux-azure-5.11
> will cause a regression with respect to MANA.
> 
> [Test Case]
> 
> Microsoft to test and verify.
> A Microsoft engineer manually tested the 3 kernels using iperf, ethtool, and hot-add/remove NIC, and all worked well.
> The 3 kernels do use EQ-sharing according to /proc/interrupts.
> 
> [Where things might go wrong]
> 
> More virtual ports may cause issues in older kernels.
> 
> [Other Info]
> 
> SF: #00321275
> 

For entire set F+H+I:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof
Marcelo Henrique Cerri Oct. 21, 2021, 1:08 p.m. UTC | #2
LGTM! Thanks, Tim!

Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>

On Thu, Oct 21, 2021 at 06:23:34AM -0600, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1947859
> 
> SRU Justification
> 
> [Impact]
> 
> Microsoft has requested the addition of MANA EQ-sharing patch set which is essentially everything up through v5.15-rc6.
> There are a couple of bug fix patches that are not strictly required, but seemed like a good idea.
> 
> 3 more patches from Haiyang regarding EQ-sharing for Microsoft Azure Network Adapter (MANA). This saves MSI-X interrupts and allows the host to offer more virtual ports (network interfaces) to the VM. With the patches, the MANA driver supports up to 256 virtual ports per VF (it was 16/VF), and support up to 64 queues per vPort (it was 16).
> 
> Hirsute appears to have missed having the MANA driver added while it was in development. This
> patch set corrects that overight. Upgrading users from focal/linux-azure to focal/linux-azure-5.11
> will cause a regression with respect to MANA.
> 
> [Test Case]
> 
> Microsoft to test and verify.
> A Microsoft engineer manually tested the 3 kernels using iperf, ethtool, and hot-add/remove NIC, and all worked well.
> The 3 kernels do use EQ-sharing according to /proc/interrupts.
> 
> [Where things might go wrong]
> 
> More virtual ports may cause issues in older kernels.
> 
> [Other Info]
> 
> SF: #00321275
> 
> ----------------------------------------------------------------
> The following changes since commit bc4974dcc627f703ad351c654d53935e52c945ed:
> 
>   net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:42:47 -0600)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/focal 
> 
> for you to fetch changes up to bc4974dcc627f703ad351c654d53935e52c945ed:
> 
>   net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:42:47 -0600)
> 
> ----------------------------------------------------------------
> The following changes since commit 9c595b89e7dd726949c37ab357621a020e7eaaff:
> 
>   net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:50:30 -0600)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/hirsute 
> 
> for you to fetch changes up to 9c595b89e7dd726949c37ab357621a020e7eaaff:
> 
>   net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:50:30 -0600)
> 
> ----------------------------------------------------------------
> The following changes since commit acf854e7401c0911a6527698bffc8bbb6d73864a:
> 
>   net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:53:14 -0600)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/impish 
> 
> for you to fetch changes up to acf854e7401c0911a6527698bffc8bbb6d73864a:
> 
>   net: mana: Fix error handling in mana_create_rxq() (2021-10-20 05:53:14 -0600)
> 
> ----------------------------------------------------------------
> 
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Tim Gardner Oct. 21, 2021, 1:23 p.m. UTC | #3
Applied to focal/linux-azure master-next, hirsute/linux-azure 
master-next, impish/linux-azure master-next. Thanks.

-rtg

On 10/21/21 6:23 AM, Tim Gardner wrote:
>    https://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/focal