| Message ID | 20210827093047.69888-1-vicamo.yang@canonical.com |
|---|---|
| Headers | show |
| Series | iwlwifi: support LARI_CONFIG_CHANGE cmd | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 8/27/21 3:30 AM, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1941665 > > [Impact] > > After applied patches from bug 1933938 to enable AX201 on ADL platforms, > some of them may still fail to functioning stably due to fw error when > LARI_CONFIG_CHANGE command is sent. With CONFIG_IWLWIFI_DEBUG turned on, > following error appears: > > iwlwifi 0000:00:14.3: iwl_mvm_lari_cfg sending LARI_CONFIG_CHANGE, > config_bitmap=0x8, oem_11ax_allow_bitmap=0xf > iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Attempting to send > sync command UNKNOWN > iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Setting HCMD_ACTIVE > for command UNKNOWN > > Then begin FW error, hardware reset. > > [Fix] > > Commit 54b4fda5a761 ("iwlwifi: mvm: Read acpi dsm to get unii4 > enable/disable bitmap") is required to fix this issue. The other commit > is pulled in for dependency. > > [Test Case] > > Install a prebuilt kernel with these fixes, put DUT under idle for 5 > mins and check if there is still firmware error messages. > > [Where problems could occur] > > There is little chance that it can ever go wrong judging from the > simplexity of the two commits. > > [Other Info] > > While the two patches have already been included in mainline and > therefore Ubuntu unstable, only oem-5.13 and impish are nominated. > > Abhishek Naik (1): > iwlwifi: mvm: Read acpi dsm to get unii4 enable/disable bitmap. > > Miri Korenblit (1): > iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 50 ++++++++++++++----- > drivers/net/wireless/intel/iwlwifi/fw/acpi.h | 10 ++++ > .../wireless/intel/iwlwifi/fw/api/nvm-reg.h | 19 +++++++ > drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 44 +++++++++++----- > 4 files changed, 99 insertions(+), 24 deletions(-) >
On 27.8.2021 12.30, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1941665 > > [Impact] > > After applied patches from bug 1933938 to enable AX201 on ADL platforms, > some of them may still fail to functioning stably due to fw error when > LARI_CONFIG_CHANGE command is sent. With CONFIG_IWLWIFI_DEBUG turned on, > following error appears: > > iwlwifi 0000:00:14.3: iwl_mvm_lari_cfg sending LARI_CONFIG_CHANGE, > config_bitmap=0x8, oem_11ax_allow_bitmap=0xf > iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Attempting to send > sync command UNKNOWN > iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Setting HCMD_ACTIVE > for command UNKNOWN > > Then begin FW error, hardware reset. > > [Fix] > > Commit 54b4fda5a761 ("iwlwifi: mvm: Read acpi dsm to get unii4 > enable/disable bitmap") is required to fix this issue. The other commit > is pulled in for dependency. > > [Test Case] > > Install a prebuilt kernel with these fixes, put DUT under idle for 5 > mins and check if there is still firmware error messages. > > [Where problems could occur] > > There is little chance that it can ever go wrong judging from the > simplexity of the two commits. > > [Other Info] > > While the two patches have already been included in mainline and > therefore Ubuntu unstable, only oem-5.13 and impish are nominated. > > Abhishek Naik (1): > iwlwifi: mvm: Read acpi dsm to get unii4 enable/disable bitmap. > > Miri Korenblit (1): > iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 50 ++++++++++++++----- > drivers/net/wireless/intel/iwlwifi/fw/acpi.h | 10 ++++ > .../wireless/intel/iwlwifi/fw/api/nvm-reg.h | 19 +++++++ > drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 44 +++++++++++----- > 4 files changed, 99 insertions(+), 24 deletions(-) > I think you should merge this with the other patchset, as this depends on the other?
On 27.8.2021 12.30, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1941665 > > [Impact] > > After applied patches from bug 1933938 to enable AX201 on ADL platforms, > some of them may still fail to functioning stably due to fw error when > LARI_CONFIG_CHANGE command is sent. With CONFIG_IWLWIFI_DEBUG turned on, > following error appears: > > iwlwifi 0000:00:14.3: iwl_mvm_lari_cfg sending LARI_CONFIG_CHANGE, > config_bitmap=0x8, oem_11ax_allow_bitmap=0xf > iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Attempting to send > sync command UNKNOWN > iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Setting HCMD_ACTIVE > for command UNKNOWN > > Then begin FW error, hardware reset. > > [Fix] > > Commit 54b4fda5a761 ("iwlwifi: mvm: Read acpi dsm to get unii4 > enable/disable bitmap") is required to fix this issue. The other commit > is pulled in for dependency. > > [Test Case] > > Install a prebuilt kernel with these fixes, put DUT under idle for 5 > mins and check if there is still firmware error messages. > > [Where problems could occur] > > There is little chance that it can ever go wrong judging from the > simplexity of the two commits. > > [Other Info] > > While the two patches have already been included in mainline and > therefore Ubuntu unstable, only oem-5.13 and impish are nominated. > > Abhishek Naik (1): > iwlwifi: mvm: Read acpi dsm to get unii4 enable/disable bitmap. > > Miri Korenblit (1): > iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 50 ++++++++++++++----- > drivers/net/wireless/intel/iwlwifi/fw/acpi.h | 10 ++++ > .../wireless/intel/iwlwifi/fw/api/nvm-reg.h | 19 +++++++ > drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 44 +++++++++++----- > 4 files changed, 99 insertions(+), 24 deletions(-) > on a second thought applied to oem-5.13, thanks
BugLink: https://bugs.launchpad.net/bugs/1941665 [Impact] After applied patches from bug 1933938 to enable AX201 on ADL platforms, some of them may still fail to functioning stably due to fw error when LARI_CONFIG_CHANGE command is sent. With CONFIG_IWLWIFI_DEBUG turned on, following error appears: iwlwifi 0000:00:14.3: iwl_mvm_lari_cfg sending LARI_CONFIG_CHANGE, config_bitmap=0x8, oem_11ax_allow_bitmap=0xf iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Attempting to send sync command UNKNOWN iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Setting HCMD_ACTIVE for command UNKNOWN Then begin FW error, hardware reset. [Fix] Commit 54b4fda5a761 ("iwlwifi: mvm: Read acpi dsm to get unii4 enable/disable bitmap") is required to fix this issue. The other commit is pulled in for dependency. [Test Case] Install a prebuilt kernel with these fixes, put DUT under idle for 5 mins and check if there is still firmware error messages. [Where problems could occur] There is little chance that it can ever go wrong judging from the simplexity of the two commits. [Other Info] While the two patches have already been included in mainline and therefore Ubuntu unstable, only oem-5.13 and impish are nominated. Abhishek Naik (1): iwlwifi: mvm: Read acpi dsm to get unii4 enable/disable bitmap. Miri Korenblit (1): iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 50 ++++++++++++++----- drivers/net/wireless/intel/iwlwifi/fw/acpi.h | 10 ++++ .../wireless/intel/iwlwifi/fw/api/nvm-reg.h | 19 +++++++ drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 44 +++++++++++----- 4 files changed, 99 insertions(+), 24 deletions(-)