From patchwork Fri Aug 27 09:30:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1521593 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GwvbT5jWsz9sRN; Fri, 27 Aug 2021 19:31:01 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mJYCO-0006L8-Ro; Fri, 27 Aug 2021 09:30:56 +0000 Received: from mail-pg1-f174.google.com ([209.85.215.174]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mJYCJ-0006Kl-AS for kernel-team@lists.ubuntu.com; Fri, 27 Aug 2021 09:30:51 +0000 Received: by mail-pg1-f174.google.com with SMTP id t1so5519531pgv.3 for ; Fri, 27 Aug 2021 02:30:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=6hl7v/O2qbOS2j2lZJm1WeOtRQbGAzK5NvbkO9pFOBg=; b=k7O0Wv1C/6wtXuuecs3l5KmqzJKFfF2aojZQ4206TvtmUGYLmDr83vmNBTo79AwbEY FEAd3Di9Ub4yLBGDBkLMKXH5eoZzGnEMnZkznWy8a4Lf58ugPn7XaPiOlFTXFwsS5+b2 D5oTe9O/JqqJeE3LF9IDPzUEcW+XVJ6+EG7GycHrPoEdPFgqlIl6MSdw5rOsZJig5Pbl zyiHFjq6nTBtenRmX6Pnl2dkt/JFjvgSnmAj09Z8QbxAmm7lrKUlq2USzMEJ8LX2rDD7 Mh1KbxMoNP3fRu6XdEBj7AmFMZtxI/Fbf78vyvR/VS8APmZsHO8xkVeLUgPBaTcwLofK haxw== X-Gm-Message-State: AOAM5339xj4bodCfv4EpF06tSR1XJgUeYpMjtIoM4KEZDhol/JNExKCQ y0/F2HPYbGIca6nxEW8mw9Au6vcF03OVUg== X-Google-Smtp-Source: ABdhPJxw88d7+2Rlo1QDa07Z4hWVgU4eMyQhY7BZUs1bdxYbbxUnHegdItROK8j3HtvaGHojalOZtQ== X-Received: by 2002:a63:164a:: with SMTP id 10mr7275486pgw.161.1630056649189; Fri, 27 Aug 2021 02:30:49 -0700 (PDT) Received: from localhost (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id nk17sm5631613pjb.18.2021.08.27.02.30.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Aug 2021 02:30:48 -0700 (PDT) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/2][SRU][OEM-5.13][I] iwlwifi: support LARI_CONFIG_CHANGE cmd Date: Fri, 27 Aug 2021 17:30:45 +0800 Message-Id: <20210827093047.69888-1-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.215.174; envelope-from=vicamo@gmail.com; helo=mail-pg1-f174.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1941665 [Impact] After applied patches from bug 1933938 to enable AX201 on ADL platforms, some of them may still fail to functioning stably due to fw error when LARI_CONFIG_CHANGE command is sent. With CONFIG_IWLWIFI_DEBUG turned on, following error appears: iwlwifi 0000:00:14.3: iwl_mvm_lari_cfg sending LARI_CONFIG_CHANGE, config_bitmap=0x8, oem_11ax_allow_bitmap=0xf iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Attempting to send sync command UNKNOWN iwlwifi 0000:00:14.3: iwl_trans_txq_send_hcmd_sync Setting HCMD_ACTIVE for command UNKNOWN Then begin FW error, hardware reset. [Fix] Commit 54b4fda5a761 ("iwlwifi: mvm: Read acpi dsm to get unii4 enable/disable bitmap") is required to fix this issue. The other commit is pulled in for dependency. [Test Case] Install a prebuilt kernel with these fixes, put DUT under idle for 5 mins and check if there is still firmware error messages. [Where problems could occur] There is little chance that it can ever go wrong judging from the simplexity of the two commits. [Other Info] While the two patches have already been included in mainline and therefore Ubuntu unstable, only oem-5.13 and impish are nominated. Abhishek Naik (1): iwlwifi: mvm: Read acpi dsm to get unii4 enable/disable bitmap. Miri Korenblit (1): iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 50 ++++++++++++++----- drivers/net/wireless/intel/iwlwifi/fw/acpi.h | 10 ++++ .../wireless/intel/iwlwifi/fw/api/nvm-reg.h | 19 +++++++ drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 44 +++++++++++----- 4 files changed, 99 insertions(+), 24 deletions(-) Acked-by: Tim Gardner