Message ID | 20210622172352.3975782-1-kai.heng.feng@canonical.com |
---|---|
Headers | show |
Series | Add s2idle support for AMD Cezzane | expand |
BugLink: https://bugs.launchpad.net/bugs/1932577 [Impact] Attempt to suspend AMD Cezzane laptop will cause a straight shutdown. [Fix] More ad-hoc fixes from AMD. Also replace all previous fixes with upstream version. [Test] Suspend and resume HP EliteBook 845 G8 and the laptop shuts down. After applying this fix, the laptop can suspend and resume normally. [Where problems could occur] s2idle never works on Cezzane, and barely works on Renoir. So this can be treat as a new feature with no regression risk. Alex Deucher (1): ACPI: PM: s2idle: Add missing LPS0 functions for AMD Kai-Heng Feng (6): Revert "UBUNTU: SAUCE: platform/x86: force LPS0 functions for AMD" Revert "UBUNTU: SAUCE: platform/x86: Add missing LPS0 functions for AMD" Revert "UBUNTU: SAUCE: nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path" Revert "UBUNTU: SAUCE: Move ASPM quirk flag to MSB" Revert "UBUNTU: SAUCE: PCI: quirks: Quirk PCI d3hot delay for AMD xhci" Revert "UBUNTU: SAUCE: usb: pci-quirks: disable D3cold on AMD xhci suspend for s2idle" Marcin Bachry (1): PCI: quirks: Quirk PCI d3hot delay for AMD xhci Mario Limonciello (3): nvme-pci: look for StorageD3Enable on companion ACPI device instead usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD Renoir ACPI: PM: Adjust behavior for field problems on AMD systems Pratik Vishwakarma (4): ACPI: PM: s2idle: Use correct revision id ACPI: PM: s2idle: Refactor common code ACPI: PM: s2idle: Add support for multiple func mask ACPI: PM: s2idle: Add support for new Microsoft UUID Rafael J. Wysocki (2): ACPI: PM: s2idle: Move x86-specific code to the x86 directory ACPI: PM: s2idle: Drop unused local variables and related code drivers/acpi/Makefile | 1 + drivers/acpi/sleep.c | 464 +-------------------------------- drivers/acpi/sleep.h | 16 ++ drivers/acpi/x86/s2idle.c | 505 ++++++++++++++++++++++++++++++++++++ drivers/nvme/host/pci.c | 29 +-- drivers/pci/quirks.c | 11 - drivers/usb/host/xhci-pci.c | 7 +- drivers/usb/host/xhci.h | 2 +- include/linux/pci.h | 4 +- include/linux/pci_ids.h | 2 - 10 files changed, 541 insertions(+), 500 deletions(-) create mode 100644 drivers/acpi/x86/s2idle.c
On 22.6.2021 20.23, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1932577 > > [Impact] > Attempt to suspend AMD Cezzane laptop will cause a straight shutdown. > > [Fix] > More ad-hoc fixes from AMD. > Also replace all previous fixes with upstream version. > > [Test] > Suspend and resume HP EliteBook 845 G8 and the laptop shuts down. > After applying this fix, the laptop can suspend and resume normally. > > [Where problems could occur] > s2idle never works on Cezzane, and barely works on Renoir. So this can > be treat as a new feature with no regression risk. > > Alex Deucher (1): > ACPI: PM: s2idle: Add missing LPS0 functions for AMD > > Kai-Heng Feng (6): > Revert "UBUNTU: SAUCE: platform/x86: force LPS0 functions for AMD" > Revert "UBUNTU: SAUCE: platform/x86: Add missing LPS0 functions for > AMD" > Revert "UBUNTU: SAUCE: nvme: put some AMD PCIE downstream NVME device > to simple suspend/resume path" > Revert "UBUNTU: SAUCE: Move ASPM quirk flag to MSB" > Revert "UBUNTU: SAUCE: PCI: quirks: Quirk PCI d3hot delay for AMD > xhci" > Revert "UBUNTU: SAUCE: usb: pci-quirks: disable D3cold on AMD xhci > suspend for s2idle" > > Marcin Bachry (1): > PCI: quirks: Quirk PCI d3hot delay for AMD xhci > > Mario Limonciello (3): > nvme-pci: look for StorageD3Enable on companion ACPI device instead > usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD > Renoir > ACPI: PM: Adjust behavior for field problems on AMD systems > > Pratik Vishwakarma (4): > ACPI: PM: s2idle: Use correct revision id > ACPI: PM: s2idle: Refactor common code > ACPI: PM: s2idle: Add support for multiple func mask > ACPI: PM: s2idle: Add support for new Microsoft UUID > > Rafael J. Wysocki (2): > ACPI: PM: s2idle: Move x86-specific code to the x86 directory > ACPI: PM: s2idle: Drop unused local variables and related code > > drivers/acpi/Makefile | 1 + > drivers/acpi/sleep.c | 464 +-------------------------------- > drivers/acpi/sleep.h | 16 ++ > drivers/acpi/x86/s2idle.c | 505 ++++++++++++++++++++++++++++++++++++ > drivers/nvme/host/pci.c | 29 +-- > drivers/pci/quirks.c | 11 - > drivers/usb/host/xhci-pci.c | 7 +- > drivers/usb/host/xhci.h | 2 +- > include/linux/pci.h | 4 +- > include/linux/pci_ids.h | 2 - > 10 files changed, 541 insertions(+), 500 deletions(-) > create mode 100644 drivers/acpi/x86/s2idle.c > applied to oem-5.10, thanks
On 22.6.2021 20.23, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1932577 > > [Impact] > Attempt to suspend AMD Cezzane laptop will cause a straight shutdown. > > [Fix] > More ad-hoc fixes from AMD. > Also replace all previous fixes with upstream version. > > [Test] > Suspend and resume HP EliteBook 845 G8 and the laptop shuts down. > After applying this fix, the laptop can suspend and resume normally. > > [Where problems could occur] > s2idle never works on Cezzane, and barely works on Renoir. So this can > be treat as a new feature with no regression risk. > > Alex Deucher (1): > ACPI: PM: s2idle: Add missing LPS0 functions for AMD > > Kai-Heng Feng (6): > Revert "UBUNTU: SAUCE: platform/x86: force LPS0 functions for AMD" > Revert "UBUNTU: SAUCE: platform/x86: Add missing LPS0 functions for > AMD" > Revert "UBUNTU: SAUCE: nvme: put some AMD PCIE downstream NVME device > to simple suspend/resume path" > Revert "UBUNTU: SAUCE: Move ASPM quirk flag to MSB" > Revert "UBUNTU: SAUCE: PCI: quirks: Quirk PCI d3hot delay for AMD > xhci" > Revert "UBUNTU: SAUCE: usb: pci-quirks: disable D3cold on AMD xhci > suspend for s2idle" > > Marcin Bachry (1): > PCI: quirks: Quirk PCI d3hot delay for AMD xhci > > Mario Limonciello (3): > nvme-pci: look for StorageD3Enable on companion ACPI device instead > usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD > Renoir > ACPI: PM: Adjust behavior for field problems on AMD systems > > Pratik Vishwakarma (4): > ACPI: PM: s2idle: Use correct revision id > ACPI: PM: s2idle: Refactor common code > ACPI: PM: s2idle: Add support for multiple func mask > ACPI: PM: s2idle: Add support for new Microsoft UUID > > Rafael J. Wysocki (2): > ACPI: PM: s2idle: Move x86-specific code to the x86 directory > ACPI: PM: s2idle: Drop unused local variables and related code > > drivers/acpi/Makefile | 1 + > drivers/acpi/sleep.c | 464 +-------------------------------- > drivers/acpi/sleep.h | 16 ++ > drivers/acpi/x86/s2idle.c | 505 ++++++++++++++++++++++++++++++++++++ > drivers/nvme/host/pci.c | 29 +-- > drivers/pci/quirks.c | 11 - > drivers/usb/host/xhci-pci.c | 7 +- > drivers/usb/host/xhci.h | 2 +- > include/linux/pci.h | 4 +- > include/linux/pci_ids.h | 2 - > 10 files changed, 541 insertions(+), 500 deletions(-) > create mode 100644 drivers/acpi/x86/s2idle.c > and now applied to oem-5.13 too