mbox series

[0/1,linux-riscv,F] Build linux-libc-dev for riscv64 from main kernel package

Message ID 20200708162735.44886-1-seth.forshee@canonical.com
Headers show
Series Build linux-libc-dev for riscv64 from main kernel package | expand

Message

Seth Forshee July 8, 2020, 4:27 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1886188

SRU Justification

Impact: Building linux-libc-dev for riscv64 from the linux-riscv package means
that it can have a different version from the package on other architectures.
This makes it uninstallable for cross building.

Fix: Move the riscv64 linux-libc-dev build back to the main kernel package so
that the version will match.

Test Case: See bug description.

Regression Potential: This could cause trouble if the main kernel package
version is behind the linux-riscv package version, and may require artificially
inflating the version of the linux package. Currently this is not necessary,
but it needs to be kept in mind when preparing packages for upload with the
fixes applied.

Note that these changes should only be applied along with the
corresponding changes for linux, sent separately.

Thanks,
Seth

---

Seth Forshee (1):
  UBUNTU: [Config] Move build of linux-libc-dev to primary kernel

 debian.riscv/rules.d/riscv64.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Bader July 9, 2020, 8:20 a.m. UTC | #1
On 08.07.20 18:27, Seth Forshee wrote:
> BugLink: https://bugs.launchpad.net/bugs/1886188
> 
> SRU Justification
> 
> Impact: Building linux-libc-dev for riscv64 from the linux-riscv package means
> that it can have a different version from the package on other architectures.
> This makes it uninstallable for cross building.
> 
> Fix: Move the riscv64 linux-libc-dev build back to the main kernel package so
> that the version will match.
> 
> Test Case: See bug description.
> 
> Regression Potential: This could cause trouble if the main kernel package
> version is behind the linux-riscv package version, and may require artificially
> inflating the version of the linux package. Currently this is not necessary,
> but it needs to be kept in mind when preparing packages for upload with the
> fixes applied.
> 
> Note that these changes should only be applied along with the
> corresponding changes for linux, sent separately.
> 
> Thanks,
> Seth
> 
> ---
> 
> Seth Forshee (1):
>   UBUNTU: [Config] Move build of linux-libc-dev to primary kernel
> 
>  debian.riscv/rules.d/riscv64.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
Note that this is related to the other thread: "[PATCH 0/2][F] Build
linux-libc-dev for riscv64 from main kernel package" which modifies the main
kernel. Both need to be applied at the same time.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Marcelo Henrique Cerri July 9, 2020, 1:11 p.m. UTC | #2
Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>

On Wed, Jul 08, 2020 at 11:27:34AM -0500, Seth Forshee wrote:
> BugLink: https://bugs.launchpad.net/bugs/1886188
> 
> SRU Justification
> 
> Impact: Building linux-libc-dev for riscv64 from the linux-riscv package means
> that it can have a different version from the package on other architectures.
> This makes it uninstallable for cross building.
> 
> Fix: Move the riscv64 linux-libc-dev build back to the main kernel package so
> that the version will match.
> 
> Test Case: See bug description.
> 
> Regression Potential: This could cause trouble if the main kernel package
> version is behind the linux-riscv package version, and may require artificially
> inflating the version of the linux package. Currently this is not necessary,
> but it needs to be kept in mind when preparing packages for upload with the
> fixes applied.
> 
> Note that these changes should only be applied along with the
> corresponding changes for linux, sent separately.
> 
> Thanks,
> Seth
> 
> ---
> 
> Seth Forshee (1):
>   UBUNTU: [Config] Move build of linux-libc-dev to primary kernel
> 
>  debian.riscv/rules.d/riscv64.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
Kelsey Skunberg Aug. 3, 2020, 6:48 p.m. UTC | #3
Applied to linux-riscv/focal master-next. The corresponding changes for
focal/linux were applied to focal/linux master-next too. Thank you! 

-Kelsey

On 2020-07-08 11:27:34 , Seth Forshee wrote:
> BugLink: https://bugs.launchpad.net/bugs/1886188
> 
> SRU Justification
> 
> Impact: Building linux-libc-dev for riscv64 from the linux-riscv package means
> that it can have a different version from the package on other architectures.
> This makes it uninstallable for cross building.
> 
> Fix: Move the riscv64 linux-libc-dev build back to the main kernel package so
> that the version will match.
> 
> Test Case: See bug description.
> 
> Regression Potential: This could cause trouble if the main kernel package
> version is behind the linux-riscv package version, and may require artificially
> inflating the version of the linux package. Currently this is not necessary,
> but it needs to be kept in mind when preparing packages for upload with the
> fixes applied.
> 
> Note that these changes should only be applied along with the
> corresponding changes for linux, sent separately.
> 
> Thanks,
> Seth
> 
> ---
> 
> Seth Forshee (1):
>   UBUNTU: [Config] Move build of linux-libc-dev to primary kernel
> 
>  debian.riscv/rules.d/riscv64.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team