mbox series

[E,SRU,0/1] fix for fanotify15 from ubuntu_ltp_syscalls

Message ID 20200520073255.20666-1-po-hsu.lin@canonical.com
Headers show
Series fix for fanotify15 from ubuntu_ltp_syscalls | expand

Message

Po-Hsu Lin May 20, 2020, 7:32 a.m. UTC 
== SRU Justification ==
The fanotify15 from ubuntu_ltp_syscalls will fail on differenet
filesystems with Eoan kernel:
  fanotify15.c:223: FAIL: Got event: mask=2 (expected 400003c0) pid=16744 fd=-1
  fanotify15.c:223: FAIL: Got event: mask=2 (expected 40000400) pid=16744 fd=-1
  fanotify15.c:210: FAIL: got unnecessary event: mask=2 pid=16744 fd=-1
  fanotify15.c:210: FAIL: got unnecessary event: mask=400003c0 pid=16744 fd=-1
  fanotify15.c:210: FAIL: got unnecessary event: mask=40000400 pid=16744 fd=-1

== Fix ==
* f367a62a7cad ("fanotify: merge duplicate events on parent and child")

This patch has been applied to Focal via stable update process, and
this test will be skipped on Disco and older kernels with
"FAN_REPORT_FID not supported in kernel".

Thus Eoan will be the only kernel that needs this patch. It needs to be
backported because of missing commit dfc2d2594e4 ("fsnotify: replace
inode pointer with an object id")

== Test ==
A test kernel could be found here:
https://people.canonical.com/~phlin/kernel/lp-1878748-fanotify15/

This faontify15 test will pass with this patch applied.
Also tested with the whole ubuntu_ltp_syscalls test suite, no new
failures were reported.

== Regression Potential ==
Low, it's just a minor bug according to the patch author [1] and it's
testable with positive result.

[1] https://lwn.net/Articles/812675/

Amir Goldstein (1):
  fanotify: merge duplicate events on parent and child

 fs/notify/fanotify/fanotify.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)