From patchwork Wed May 20 07:32:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1294081 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49Rkxk6n1pz9sTT; Wed, 20 May 2020 17:33:14 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jbJDy-0005wJ-Li; Wed, 20 May 2020 07:33:10 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jbJDw-0005w3-Ov for kernel-team@lists.ubuntu.com; Wed, 20 May 2020 07:33:08 +0000 Received: from mail-pl1-f197.google.com ([209.85.214.197]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jbJDw-0007CN-C2 for kernel-team@lists.ubuntu.com; Wed, 20 May 2020 07:33:08 +0000 Received: by mail-pl1-f197.google.com with SMTP id f3so1917635plo.14 for ; Wed, 20 May 2020 00:33:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=k7eVU70KQ4Ft4CghL1+HY/R0o89TtUxRly0Yic8jroQ=; b=ZT7jJqkbCjVtLowARDoC7E4fV1D59aLFaB0nxjNW71JWiYN0oyIiTAUSyeTGwmhQAC i0e5/JhgGFCopqeEfCS61BJMMIXU0HsWNJdnKROLEWpBM1ekky3lsa4U/rvZfTDZXZNw BeF75WMglgbHnUTe+JieQBVXGwvguT7MUSujb4jMXwtj4yW3w6B19Jrb6lLl18bkSogF eHP6/WU8tlRAThO76/LNDBRNL4rmiRCAINYGEQ9VNw2VuIZFpzqzKXFLI0qR+Vnv1dRw 5sbHuJLBIdXk5e7yXSVuiYHYq3ckXb2+bF942rL9GMisoPa1Mf1RQmOXWznoXBJP1OkA iJlQ== X-Gm-Message-State: AOAM532ER2Bqvb8BWyHDZuBqgvGPSW6aphfYAg/h/lfEZv0Gg3gNxjJA 6j+7jknEUo7EP9Vb5ov6CMt9L4NitoNDyga7YtghbzmodHkeUC0nlZrLCNT6EAv14rfnyBv8qJP QNBF/hE6lyGIsL0ieW0NKr5NDQmG4NcWN6iUjuxup X-Received: by 2002:a63:6f4c:: with SMTP id k73mr2817595pgc.241.1589959986492; Wed, 20 May 2020 00:33:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsyif6Xuf7wcLSmR6IWXwMI8TyQsbZc2NsEszrcoiCcku9mynvdlgdXhOPNsZjTlxQXxcR/w== X-Received: by 2002:a63:6f4c:: with SMTP id k73mr2817571pgc.241.1589959986059; Wed, 20 May 2020 00:33:06 -0700 (PDT) Received: from localhost.localdomain (114-137-195-160.emome-ip.hinet.net. [114.137.195.160]) by smtp.gmail.com with ESMTPSA id y23sm1174512pgc.78.2020.05.20.00.33.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 00:33:05 -0700 (PDT) From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [E][SRU][PATCH 0/1] fix for fanotify15 from ubuntu_ltp_syscalls Date: Wed, 20 May 2020 15:32:54 +0800 Message-Id: <20200520073255.20666-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" == SRU Justification == The fanotify15 from ubuntu_ltp_syscalls will fail on differenet filesystems with Eoan kernel: fanotify15.c:223: FAIL: Got event: mask=2 (expected 400003c0) pid=16744 fd=-1 fanotify15.c:223: FAIL: Got event: mask=2 (expected 40000400) pid=16744 fd=-1 fanotify15.c:210: FAIL: got unnecessary event: mask=2 pid=16744 fd=-1 fanotify15.c:210: FAIL: got unnecessary event: mask=400003c0 pid=16744 fd=-1 fanotify15.c:210: FAIL: got unnecessary event: mask=40000400 pid=16744 fd=-1 == Fix == * f367a62a7cad ("fanotify: merge duplicate events on parent and child") This patch has been applied to Focal via stable update process, and this test will be skipped on Disco and older kernels with "FAN_REPORT_FID not supported in kernel". Thus Eoan will be the only kernel that needs this patch. It needs to be backported because of missing commit dfc2d2594e4 ("fsnotify: replace inode pointer with an object id") == Test == A test kernel could be found here: https://people.canonical.com/~phlin/kernel/lp-1878748-fanotify15/ This faontify15 test will pass with this patch applied. Also tested with the whole ubuntu_ltp_syscalls test suite, no new failures were reported. == Regression Potential == Low, it's just a minor bug according to the patch author [1] and it's testable with positive result. [1] https://lwn.net/Articles/812675/ Amir Goldstein (1): fanotify: merge duplicate events on parent and child fs/notify/fanotify/fanotify.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)