| Message ID | af8d8e25ed86a2228bc0d5e2185a482334a8d6b7.1447062305.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Mon, Nov 09, 2015 at 10:45:07AM +0100, Michal Simek wrote: > CONFIG_OF_EMBED=y is the option which is here only for testing purpose > and shouldn't be enabled by default as is describe at: > "dts: Add a comment about CONFIG_OF_EMBED being for local use" > (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c) > > But still enabling this option locally shouldn't end up with compilation > error when you build SPL. This patch fix it. > > Compilation error: > lib/built-in.o: In function `fdtdec_setup': > /mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to > `__dtb_dt_begin' > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Off-list but I _think_ patchwork will pick this up still: Reported-by: Tom Rini <trini@konsulko.com> And: Reviewed-by: Tom Rini <trini@konsulko.com> Thanks!
On 9 November 2015 at 12:03, Tom Rini <trini@konsulko.com> wrote: > On Mon, Nov 09, 2015 at 10:45:07AM +0100, Michal Simek wrote: > >> CONFIG_OF_EMBED=y is the option which is here only for testing purpose >> and shouldn't be enabled by default as is describe at: >> "dts: Add a comment about CONFIG_OF_EMBED being for local use" >> (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c) >> >> But still enabling this option locally shouldn't end up with compilation >> error when you build SPL. This patch fix it. >> >> Compilation error: >> lib/built-in.o: In function `fdtdec_setup': >> /mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to >> `__dtb_dt_begin' >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > Off-list but I _think_ patchwork will pick this up still: > Reported-by: Tom Rini <trini@konsulko.com> > And: > Reviewed-by: Tom Rini <trini@konsulko.com> Reviewed-by: Simon Glass <sjg@chromium.org>
On 11/09/2015 09:03 PM, Tom Rini wrote: > On Mon, Nov 09, 2015 at 10:45:07AM +0100, Michal Simek wrote: > >> CONFIG_OF_EMBED=y is the option which is here only for testing purpose >> and shouldn't be enabled by default as is describe at: >> "dts: Add a comment about CONFIG_OF_EMBED being for local use" >> (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c) >> >> But still enabling this option locally shouldn't end up with compilation >> error when you build SPL. This patch fix it. >> >> Compilation error: >> lib/built-in.o: In function `fdtdec_setup': >> /mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to >> `__dtb_dt_begin' >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > Off-list but I _think_ patchwork will pick this up still: > Reported-by: Tom Rini <trini@konsulko.com> :-) yep. TBH I was aware about this problem for a while - just didn't send patch out. Cheers, Michal
On Mon, Nov 09, 2015 at 10:45:07AM +0100, Michal Simek wrote: > CONFIG_OF_EMBED=y is the option which is here only for testing purpose > and shouldn't be enabled by default as is describe at: > "dts: Add a comment about CONFIG_OF_EMBED being for local use" > (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c) > > But still enabling this option locally shouldn't end up with compilation > error when you build SPL. This patch fix it. > > Compilation error: > lib/built-in.o: In function `fdtdec_setup': > /mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to > `__dtb_dt_begin' > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > Reported-by: Tom Rini <trini@konsulko.com> > Reviewed-by: Tom Rini <trini@konsulko.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index dd235b9d7ad6..8f690eb70c47 100644 --- a/scripts/Makefile.spl +++ b/scripts/Makefile.spl @@ -56,6 +56,7 @@ libs-y += common/init/ libs-$(CONFIG_SPL_LIBCOMMON_SUPPORT) += common/ libs-$(CONFIG_SPL_LIBDISK_SUPPORT) += disk/ libs-y += drivers/ +libs-y += dts/ libs-y += fs/ libs-$(CONFIG_SPL_LIBGENERIC_SUPPORT) += lib/ libs-$(CONFIG_SPL_POST_MEM_SUPPORT) += post/drivers/
CONFIG_OF_EMBED=y is the option which is here only for testing purpose and shouldn't be enabled by default as is describe at: "dts: Add a comment about CONFIG_OF_EMBED being for local use" (sha1: 3d3f60cb7a6bb6c338e00a9769fa918a8536096c) But still enabling this option locally shouldn't end up with compilation error when you build SPL. This patch fix it. Compilation error: lib/built-in.o: In function `fdtdec_setup': /mnt/disk/u-boot/lib/fdtdec.c:1246: undefined reference to `__dtb_dt_begin' Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- scripts/Makefile.spl | 1 + 1 file changed, 1 insertion(+)