diff mbox

[U-Boot] Add lzmadec command

Message ID CALPAzDM=YdS2=KB1JRXzFULOs28A_7HZxLUyOno-XM6cPNTsCQ@mail.gmail.com
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Patrice B Jan. 28, 2014, 8:17 a.m. UTC
Hello,

  Here's the patch that enables lzmadec command in sandbox. Should I
send it as a new thread or is it fine like that ?

  Regards

     Patrice

---
 include/configs/sandbox.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Glass Jan. 31, 2014, 9 p.m. UTC | #1
Hi Patrice,

On 28 January 2014 01:17, Patrice B <pbfwdlist@gmail.com> wrote:
> Hello,
>
>   Here's the patch that enables lzmadec command in sandbox. Should I
> send it as a new thread or is it fine like that ?

Yes I think you should send it as a new thread when its own commit subject.

Regards,
Simon

>
>   Regards
>
>      Patrice
>
> ---
>  include/configs/sandbox.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
> index a6d5582..c995882 100644
> --- a/include/configs/sandbox.h
> +++ b/include/configs/sandbox.h
> @@ -131,4 +131,6 @@
>
>  #define CONFIG_TPM_TIS_SANDBOX
>
> +#define CONFIG_CMD_LZMADEC
> +
>  #endif
> --
>
>
>
> 2014-01-26 Simon Glass <sjg@chromium.org>:
>> Hi Patrice,
>>
>>
>> On 24 January 2014 14:39, Tom Rini <trini@ti.com> wrote:
>>>
>>> On Thu, Dec 19, 2013 at 11:10:24AM +0100, Patrice B wrote:
>>>
>>> > Hi,
>>> >
>>> >  I needed to be able to uncompress lzma files. I did this command
>>> > based on unzip command and propose it if it could help. Hopping the
>>> > patch is correctly done...
>>> >
>>> >   Best regards.
>>> >
>>> >        Patrice
>>> >
>>> >
>>> > Signed-off-by: Patrice Bouchand <pbfwdlist_gmail_com>
>>
>>
>>>
>>>
>>> The code looks fine, but we don't add code that isn't enabled anywhere.
>>> So unless Simon wants to pick this up for sandbox, I'm marking this as
>>> deferred in patchwork, thanks!
>>>
>>
>> It's fine to enable this in sandbox if you want to - just send a separate
>> patch to add the CONFIG to include/configs/sandbox.h, test it in sandbox
>> (make sandbox_config; make; ./u-boot) and Cc me. I will pick it up.
>>
>> Regards,
>> Simon
>>
>>>
>>> --
>>> Tom
>>
>>
diff mbox

Patch

diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
index a6d5582..c995882 100644
--- a/include/configs/sandbox.h
+++ b/include/configs/sandbox.h
@@ -131,4 +131,6 @@ 

 #define CONFIG_TPM_TIS_SANDBOX

+#define CONFIG_CMD_LZMADEC
+
 #endif