| Message ID | CABGWkvrvKiVA_yaDnHJcHEKwc+pEuLdz=i6HQEY0oJQvohCUsw@mail.gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Pull request for u-boot-nand-20230104 | expand |
On Thu, Jan 05, 2023 at 09:10:55AM +0100, Dario Binacchi wrote: > Hi Tom, > > The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: > > Merge branch '2023-01-02-platform-updates' into next (2023-01-02 > 18:07:41 -0500) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-nand-flash.git > tags/u-boot-nand-20230104 > > for you to fetch changes up to 48f219cb16f88cd2e392e2f438409a00d3ddff54: > > mtd: rawnand: omap_elm: u-boot driver model support (2023-01-04 > 17:24:30 +0100) > > Gitlab CI showed no issues: > https://source.denx.de/u-boot/custodians/u-boot-nand-flash/-/pipelines/14597 > NAK. This commit: commit 48f219cb16f88cd2e392e2f438409a00d3ddff54 Author: Roger Quadros <rogerq@kernel.org> Date: Tue Dec 20 12:22:03 2022 +0200 mtd: rawnand: omap_elm: u-boot driver model support Support u-boot driver model. We still retain support legacy way of doing things if ELM_BASE is defined in <asm/arch/hardware.h> We could completely get rid of that if all platforms defining ELM_BASE get rid of that definition and enable CONFIG_SYS_NAND_SELF_INIT and are verified to work. Signed-off-by: Roger Quadros <rogerq@kernel.org> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> Breaks am335x_evm thusly: U-Boot SPL 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) Trying to boot from MMC1 U-Boot 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) CPU : AM335X-GP rev 2.1 Model: TI AM335x EVM DRAM: 1 GiB Error binding driver 'omap-elm': -96 Some drivers failed to bind Error binding driver 'ti_sysc': -96 Some drivers failed to bind Error binding driver 'simple_bus': -96 Some drivers failed to bind Error binding driver 'simple_bus': -96 Some drivers failed to bind Error binding driver 'simple_bus': -96 Some drivers failed to bind initcall sequence bffdbbe0 failed at call 808155a9 (err=-96) ### ERROR ### Please RESET the board ###
Hi, On 06/01/2023 20:59, Tom Rini wrote: > On Thu, Jan 05, 2023 at 09:10:55AM +0100, Dario Binacchi wrote: > >> Hi Tom, >> >> The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: >> >> Merge branch '2023-01-02-platform-updates' into next (2023-01-02 >> 18:07:41 -0500) >> >> are available in the Git repository at: >> >> https://source.denx.de/u-boot/custodians/u-boot-nand-flash.git >> tags/u-boot-nand-20230104 >> >> for you to fetch changes up to 48f219cb16f88cd2e392e2f438409a00d3ddff54: >> >> mtd: rawnand: omap_elm: u-boot driver model support (2023-01-04 >> 17:24:30 +0100) >> >> Gitlab CI showed no issues: >> https://source.denx.de/u-boot/custodians/u-boot-nand-flash/-/pipelines/14597 >> > > NAK. This commit: > commit 48f219cb16f88cd2e392e2f438409a00d3ddff54 > Author: Roger Quadros <rogerq@kernel.org> > Date: Tue Dec 20 12:22:03 2022 +0200 > > mtd: rawnand: omap_elm: u-boot driver model support > > Support u-boot driver model. We still retain > support legacy way of doing things if ELM_BASE > is defined in <asm/arch/hardware.h> > > We could completely get rid of that if all > platforms defining ELM_BASE get rid of that definition > and enable CONFIG_SYS_NAND_SELF_INIT and are verified > to work. > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > > Breaks am335x_evm thusly: > U-Boot SPL 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > Trying to boot from MMC1 > > > U-Boot 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > > CPU : AM335X-GP rev 2.1 > Model: TI AM335x EVM > DRAM: 1 GiB > Error binding driver 'omap-elm': -96 > Some drivers failed to bind > Error binding driver 'ti_sysc': -96 > Some drivers failed to bind > Error binding driver 'simple_bus': -96 > Some drivers failed to bind > Error binding driver 'simple_bus': -96 > Some drivers failed to bind > Error binding driver 'simple_bus': -96 > Some drivers failed to bind > initcall sequence bffdbbe0 failed at call 808155a9 (err=-96) > ### ERROR ### Please RESET the board ### > Sorry about that. My broken am335x-evm has suddenly come alive. I will come up with a fix in a day or two. cheers, -roger
On 07/01/2023 16:19, Roger Quadros wrote: > Hi, > > On 06/01/2023 20:59, Tom Rini wrote: >> On Thu, Jan 05, 2023 at 09:10:55AM +0100, Dario Binacchi wrote: >> >>> Hi Tom, >>> >>> The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: >>> >>> Merge branch '2023-01-02-platform-updates' into next (2023-01-02 >>> 18:07:41 -0500) >>> >>> are available in the Git repository at: >>> >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash.git >>> tags/u-boot-nand-20230104 >>> >>> for you to fetch changes up to 48f219cb16f88cd2e392e2f438409a00d3ddff54: >>> >>> mtd: rawnand: omap_elm: u-boot driver model support (2023-01-04 >>> 17:24:30 +0100) >>> >>> Gitlab CI showed no issues: >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash/-/pipelines/14597 >>> >> >> NAK. This commit: >> commit 48f219cb16f88cd2e392e2f438409a00d3ddff54 >> Author: Roger Quadros <rogerq@kernel.org> >> Date: Tue Dec 20 12:22:03 2022 +0200 >> >> mtd: rawnand: omap_elm: u-boot driver model support >> >> Support u-boot driver model. We still retain >> support legacy way of doing things if ELM_BASE >> is defined in <asm/arch/hardware.h> >> >> We could completely get rid of that if all >> platforms defining ELM_BASE get rid of that definition >> and enable CONFIG_SYS_NAND_SELF_INIT and are verified >> to work. >> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> >> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> >> >> Breaks am335x_evm thusly: >> U-Boot SPL 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) >> Trying to boot from MMC1 >> >> >> U-Boot 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) >> >> CPU : AM335X-GP rev 2.1 >> Model: TI AM335x EVM >> DRAM: 1 GiB >> Error binding driver 'omap-elm': -96 >> Some drivers failed to bind >> Error binding driver 'ti_sysc': -96 >> Some drivers failed to bind >> Error binding driver 'simple_bus': -96 >> Some drivers failed to bind >> Error binding driver 'simple_bus': -96 >> Some drivers failed to bind >> Error binding driver 'simple_bus': -96 >> Some drivers failed to bind >> initcall sequence bffdbbe0 failed at call 808155a9 (err=-96) >> ### ERROR ### Please RESET the board ### >> > > Sorry about that. My broken am335x-evm has suddenly come alive. > I will come up with a fix in a day or two. The below patch fixes boot on am335x-evm for me. Does it look reasonable? From 06e2695f8420a1fa6eaf3fcf2e5dbbf28c73a34d Mon Sep 17 00:00:00 2001 From: Roger Quadros <rogerq@kernel.org> Date: Sat, 7 Jan 2023 16:40:52 +0200 Subject: [PATCH] mtd: rawnand: omap_elm: Fix boot on am335x-evm Prevent registering with Driver Model if CONFIG_SYS_NAND_SELF_INIT is not enabled. Legacy OMAP2+ systems do not use driver model yet for NAND/ELM and don't define CONFIG_SYS_NAND_SELF_INIT. Signed-off-by: Roger Quadros <rogerq@kernel.org> --- drivers/mtd/nand/raw/omap_elm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mtd/nand/raw/omap_elm.c b/drivers/mtd/nand/raw/omap_elm.c index e528a5348d5..56a2c39e4f6 100644 --- a/drivers/mtd/nand/raw/omap_elm.c +++ b/drivers/mtd/nand/raw/omap_elm.c @@ -199,6 +199,8 @@ void elm_init(void) } #endif +#if CONFIG_IS_ENABLED(SYS_NAND_SELF_INIT) + static int elm_probe(struct udevice *dev) { #ifndef ELM_BASE @@ -224,3 +226,4 @@ U_BOOT_DRIVER(gpmc_elm) = { .of_match = elm_ids, .probe = elm_probe, }; +#endif /* CONFIG_SYS_NAND_SELF_INIT */
On Sat, Jan 07, 2023 at 04:48:02PM +0200, Roger Quadros wrote: > > On 07/01/2023 16:19, Roger Quadros wrote: > > Hi, > > > > On 06/01/2023 20:59, Tom Rini wrote: > >> On Thu, Jan 05, 2023 at 09:10:55AM +0100, Dario Binacchi wrote: > >> > >>> Hi Tom, > >>> > >>> The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: > >>> > >>> Merge branch '2023-01-02-platform-updates' into next (2023-01-02 > >>> 18:07:41 -0500) > >>> > >>> are available in the Git repository at: > >>> > >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash.git > >>> tags/u-boot-nand-20230104 > >>> > >>> for you to fetch changes up to 48f219cb16f88cd2e392e2f438409a00d3ddff54: > >>> > >>> mtd: rawnand: omap_elm: u-boot driver model support (2023-01-04 > >>> 17:24:30 +0100) > >>> > >>> Gitlab CI showed no issues: > >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash/-/pipelines/14597 > >>> > >> > >> NAK. This commit: > >> commit 48f219cb16f88cd2e392e2f438409a00d3ddff54 > >> Author: Roger Quadros <rogerq@kernel.org> > >> Date: Tue Dec 20 12:22:03 2022 +0200 > >> > >> mtd: rawnand: omap_elm: u-boot driver model support > >> > >> Support u-boot driver model. We still retain > >> support legacy way of doing things if ELM_BASE > >> is defined in <asm/arch/hardware.h> > >> > >> We could completely get rid of that if all > >> platforms defining ELM_BASE get rid of that definition > >> and enable CONFIG_SYS_NAND_SELF_INIT and are verified > >> to work. > >> > >> Signed-off-by: Roger Quadros <rogerq@kernel.org> > >> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > >> > >> Breaks am335x_evm thusly: > >> U-Boot SPL 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > >> Trying to boot from MMC1 > >> > >> > >> U-Boot 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > >> > >> CPU : AM335X-GP rev 2.1 > >> Model: TI AM335x EVM > >> DRAM: 1 GiB > >> Error binding driver 'omap-elm': -96 > >> Some drivers failed to bind > >> Error binding driver 'ti_sysc': -96 > >> Some drivers failed to bind > >> Error binding driver 'simple_bus': -96 > >> Some drivers failed to bind > >> Error binding driver 'simple_bus': -96 > >> Some drivers failed to bind > >> Error binding driver 'simple_bus': -96 > >> Some drivers failed to bind > >> initcall sequence bffdbbe0 failed at call 808155a9 (err=-96) > >> ### ERROR ### Please RESET the board ### > >> > > > > Sorry about that. My broken am335x-evm has suddenly come alive. > > I will come up with a fix in a day or two. > > The below patch fixes boot on am335x-evm for me. > > Does it look reasonable? > > From 06e2695f8420a1fa6eaf3fcf2e5dbbf28c73a34d Mon Sep 17 00:00:00 2001 > From: Roger Quadros <rogerq@kernel.org> > Date: Sat, 7 Jan 2023 16:40:52 +0200 > Subject: [PATCH] mtd: rawnand: omap_elm: Fix boot on am335x-evm > > Prevent registering with Driver Model if CONFIG_SYS_NAND_SELF_INIT > is not enabled. > > Legacy OMAP2+ systems do not use driver model yet for > NAND/ELM and don't define CONFIG_SYS_NAND_SELF_INIT. > > Signed-off-by: Roger Quadros <rogerq@kernel.org> Reviewed-by: Tom Rini <trini@konsulko.com>
Hi, On Sat, Jan 7, 2023 at 6:30 PM Tom Rini <trini@konsulko.com> wrote: > > On Sat, Jan 07, 2023 at 04:48:02PM +0200, Roger Quadros wrote: > > > > > On 07/01/2023 16:19, Roger Quadros wrote: > > > Hi, > > > > > > On 06/01/2023 20:59, Tom Rini wrote: > > >> On Thu, Jan 05, 2023 at 09:10:55AM +0100, Dario Binacchi wrote: > > >> > > >>> Hi Tom, > > >>> > > >>> The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: > > >>> > > >>> Merge branch '2023-01-02-platform-updates' into next (2023-01-02 > > >>> 18:07:41 -0500) > > >>> > > >>> are available in the Git repository at: > > >>> > > >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash.git > > >>> tags/u-boot-nand-20230104 > > >>> > > >>> for you to fetch changes up to 48f219cb16f88cd2e392e2f438409a00d3ddff54: > > >>> > > >>> mtd: rawnand: omap_elm: u-boot driver model support (2023-01-04 > > >>> 17:24:30 +0100) > > >>> > > >>> Gitlab CI showed no issues: > > >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash/-/pipelines/14597 > > >>> > > >> > > >> NAK. This commit: > > >> commit 48f219cb16f88cd2e392e2f438409a00d3ddff54 > > >> Author: Roger Quadros <rogerq@kernel.org> > > >> Date: Tue Dec 20 12:22:03 2022 +0200 > > >> > > >> mtd: rawnand: omap_elm: u-boot driver model support > > >> > > >> Support u-boot driver model. We still retain > > >> support legacy way of doing things if ELM_BASE > > >> is defined in <asm/arch/hardware.h> > > >> > > >> We could completely get rid of that if all > > >> platforms defining ELM_BASE get rid of that definition > > >> and enable CONFIG_SYS_NAND_SELF_INIT and are verified > > >> to work. > > >> > > >> Signed-off-by: Roger Quadros <rogerq@kernel.org> > > >> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > > >> > > >> Breaks am335x_evm thusly: > > >> U-Boot SPL 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > > >> Trying to boot from MMC1 > > >> > > >> > > >> U-Boot 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > > >> > > >> CPU : AM335X-GP rev 2.1 > > >> Model: TI AM335x EVM > > >> DRAM: 1 GiB > > >> Error binding driver 'omap-elm': -96 > > >> Some drivers failed to bind > > >> Error binding driver 'ti_sysc': -96 > > >> Some drivers failed to bind > > >> Error binding driver 'simple_bus': -96 > > >> Some drivers failed to bind > > >> Error binding driver 'simple_bus': -96 > > >> Some drivers failed to bind > > >> Error binding driver 'simple_bus': -96 > > >> Some drivers failed to bind > > >> initcall sequence bffdbbe0 failed at call 808155a9 (err=-96) > > >> ### ERROR ### Please RESET the board ### > > >> > > > > > > Sorry about that. My broken am335x-evm has suddenly come alive. > > > I will come up with a fix in a day or two. > > > > The below patch fixes boot on am335x-evm for me. > > > > Does it look reasonable? > > > > From 06e2695f8420a1fa6eaf3fcf2e5dbbf28c73a34d Mon Sep 17 00:00:00 2001 > > From: Roger Quadros <rogerq@kernel.org> > > Date: Sat, 7 Jan 2023 16:40:52 +0200 > > Subject: [PATCH] mtd: rawnand: omap_elm: Fix boot on am335x-evm > > > > Prevent registering with Driver Model if CONFIG_SYS_NAND_SELF_INIT > > is not enabled. > > > > Legacy OMAP2+ systems do not use driver model yet for > > NAND/ELM and don't define CONFIG_SYS_NAND_SELF_INIT. > > > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > > Reviewed-by: Tom Rini <trini@konsulko.com> If Roger will submit this patch (I still don't see it with patchwork), tomorrow I will add to the other patches, I will run the tests and in case of success I will submit a new pull-request. Is this, Tom, the correct workflow? Thanks and regards, Dario > > -- > Tom
On Sat, Jan 07, 2023 at 07:32:51PM +0100, Dario Binacchi wrote: > Hi, > > On Sat, Jan 7, 2023 at 6:30 PM Tom Rini <trini@konsulko.com> wrote: > > > > On Sat, Jan 07, 2023 at 04:48:02PM +0200, Roger Quadros wrote: > > > > > > > > On 07/01/2023 16:19, Roger Quadros wrote: > > > > Hi, > > > > > > > > On 06/01/2023 20:59, Tom Rini wrote: > > > >> On Thu, Jan 05, 2023 at 09:10:55AM +0100, Dario Binacchi wrote: > > > >> > > > >>> Hi Tom, > > > >>> > > > >>> The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: > > > >>> > > > >>> Merge branch '2023-01-02-platform-updates' into next (2023-01-02 > > > >>> 18:07:41 -0500) > > > >>> > > > >>> are available in the Git repository at: > > > >>> > > > >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash.git > > > >>> tags/u-boot-nand-20230104 > > > >>> > > > >>> for you to fetch changes up to 48f219cb16f88cd2e392e2f438409a00d3ddff54: > > > >>> > > > >>> mtd: rawnand: omap_elm: u-boot driver model support (2023-01-04 > > > >>> 17:24:30 +0100) > > > >>> > > > >>> Gitlab CI showed no issues: > > > >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash/-/pipelines/14597 > > > >>> > > > >> > > > >> NAK. This commit: > > > >> commit 48f219cb16f88cd2e392e2f438409a00d3ddff54 > > > >> Author: Roger Quadros <rogerq@kernel.org> > > > >> Date: Tue Dec 20 12:22:03 2022 +0200 > > > >> > > > >> mtd: rawnand: omap_elm: u-boot driver model support > > > >> > > > >> Support u-boot driver model. We still retain > > > >> support legacy way of doing things if ELM_BASE > > > >> is defined in <asm/arch/hardware.h> > > > >> > > > >> We could completely get rid of that if all > > > >> platforms defining ELM_BASE get rid of that definition > > > >> and enable CONFIG_SYS_NAND_SELF_INIT and are verified > > > >> to work. > > > >> > > > >> Signed-off-by: Roger Quadros <rogerq@kernel.org> > > > >> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > > > >> > > > >> Breaks am335x_evm thusly: > > > >> U-Boot SPL 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > > > >> Trying to boot from MMC1 > > > >> > > > >> > > > >> U-Boot 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > > > >> > > > >> CPU : AM335X-GP rev 2.1 > > > >> Model: TI AM335x EVM > > > >> DRAM: 1 GiB > > > >> Error binding driver 'omap-elm': -96 > > > >> Some drivers failed to bind > > > >> Error binding driver 'ti_sysc': -96 > > > >> Some drivers failed to bind > > > >> Error binding driver 'simple_bus': -96 > > > >> Some drivers failed to bind > > > >> Error binding driver 'simple_bus': -96 > > > >> Some drivers failed to bind > > > >> Error binding driver 'simple_bus': -96 > > > >> Some drivers failed to bind > > > >> initcall sequence bffdbbe0 failed at call 808155a9 (err=-96) > > > >> ### ERROR ### Please RESET the board ### > > > >> > > > > > > > > Sorry about that. My broken am335x-evm has suddenly come alive. > > > > I will come up with a fix in a day or two. > > > > > > The below patch fixes boot on am335x-evm for me. > > > > > > Does it look reasonable? > > > > > > From 06e2695f8420a1fa6eaf3fcf2e5dbbf28c73a34d Mon Sep 17 00:00:00 2001 > > > From: Roger Quadros <rogerq@kernel.org> > > > Date: Sat, 7 Jan 2023 16:40:52 +0200 > > > Subject: [PATCH] mtd: rawnand: omap_elm: Fix boot on am335x-evm > > > > > > Prevent registering with Driver Model if CONFIG_SYS_NAND_SELF_INIT > > > is not enabled. > > > > > > Legacy OMAP2+ systems do not use driver model yet for > > > NAND/ELM and don't define CONFIG_SYS_NAND_SELF_INIT. > > > > > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > > > > Reviewed-by: Tom Rini <trini@konsulko.com> > > If Roger will submit this patch (I still don't see it with patchwork), tomorrow > I will add to the other patches, I will run the tests and in case of success > I will submit a new pull-request. > Is this, Tom, the correct workflow? Patchwork likely doesn't like a patch in reply to a pull request, and I'd assume this should get folded in to the patch in question, to prevent breaking bisectability.
Hi, On Sat, Jan 7, 2023 at 7:36 PM Tom Rini <trini@konsulko.com> wrote: > > On Sat, Jan 07, 2023 at 07:32:51PM +0100, Dario Binacchi wrote: > > Hi, > > > > On Sat, Jan 7, 2023 at 6:30 PM Tom Rini <trini@konsulko.com> wrote: > > > > > > On Sat, Jan 07, 2023 at 04:48:02PM +0200, Roger Quadros wrote: > > > > > > > > > > > On 07/01/2023 16:19, Roger Quadros wrote: > > > > > Hi, > > > > > > > > > > On 06/01/2023 20:59, Tom Rini wrote: > > > > >> On Thu, Jan 05, 2023 at 09:10:55AM +0100, Dario Binacchi wrote: > > > > >> > > > > >>> Hi Tom, > > > > >>> > > > > >>> The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: > > > > >>> > > > > >>> Merge branch '2023-01-02-platform-updates' into next (2023-01-02 > > > > >>> 18:07:41 -0500) > > > > >>> > > > > >>> are available in the Git repository at: > > > > >>> > > > > >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash.git > > > > >>> tags/u-boot-nand-20230104 > > > > >>> > > > > >>> for you to fetch changes up to 48f219cb16f88cd2e392e2f438409a00d3ddff54: > > > > >>> > > > > >>> mtd: rawnand: omap_elm: u-boot driver model support (2023-01-04 > > > > >>> 17:24:30 +0100) > > > > >>> > > > > >>> Gitlab CI showed no issues: > > > > >>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash/-/pipelines/14597 > > > > >>> > > > > >> > > > > >> NAK. This commit: > > > > >> commit 48f219cb16f88cd2e392e2f438409a00d3ddff54 > > > > >> Author: Roger Quadros <rogerq@kernel.org> > > > > >> Date: Tue Dec 20 12:22:03 2022 +0200 > > > > >> > > > > >> mtd: rawnand: omap_elm: u-boot driver model support > > > > >> > > > > >> Support u-boot driver model. We still retain > > > > >> support legacy way of doing things if ELM_BASE > > > > >> is defined in <asm/arch/hardware.h> > > > > >> > > > > >> We could completely get rid of that if all > > > > >> platforms defining ELM_BASE get rid of that definition > > > > >> and enable CONFIG_SYS_NAND_SELF_INIT and are verified > > > > >> to work. > > > > >> > > > > >> Signed-off-by: Roger Quadros <rogerq@kernel.org> > > > > >> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > > > > >> > > > > >> Breaks am335x_evm thusly: > > > > >> U-Boot SPL 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > > > > >> Trying to boot from MMC1 > > > > >> > > > > >> > > > > >> U-Boot 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) > > > > >> > > > > >> CPU : AM335X-GP rev 2.1 > > > > >> Model: TI AM335x EVM > > > > >> DRAM: 1 GiB > > > > >> Error binding driver 'omap-elm': -96 > > > > >> Some drivers failed to bind > > > > >> Error binding driver 'ti_sysc': -96 > > > > >> Some drivers failed to bind > > > > >> Error binding driver 'simple_bus': -96 > > > > >> Some drivers failed to bind > > > > >> Error binding driver 'simple_bus': -96 > > > > >> Some drivers failed to bind > > > > >> Error binding driver 'simple_bus': -96 > > > > >> Some drivers failed to bind > > > > >> initcall sequence bffdbbe0 failed at call 808155a9 (err=-96) > > > > >> ### ERROR ### Please RESET the board ### > > > > >> > > > > > > > > > > Sorry about that. My broken am335x-evm has suddenly come alive. > > > > > I will come up with a fix in a day or two. > > > > > > > > The below patch fixes boot on am335x-evm for me. > > > > > > > > Does it look reasonable? > > > > > > > > From 06e2695f8420a1fa6eaf3fcf2e5dbbf28c73a34d Mon Sep 17 00:00:00 2001 > > > > From: Roger Quadros <rogerq@kernel.org> > > > > Date: Sat, 7 Jan 2023 16:40:52 +0200 > > > > Subject: [PATCH] mtd: rawnand: omap_elm: Fix boot on am335x-evm > > > > > > > > Prevent registering with Driver Model if CONFIG_SYS_NAND_SELF_INIT > > > > is not enabled. > > > > > > > > Legacy OMAP2+ systems do not use driver model yet for > > > > NAND/ELM and don't define CONFIG_SYS_NAND_SELF_INIT. > > > > > > > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > > > > > > Reviewed-by: Tom Rini <trini@konsulko.com> > > > > If Roger will submit this patch (I still don't see it with patchwork), tomorrow > > I will add to the other patches, I will run the tests and in case of success > > I will submit a new pull-request. > > Is this, Tom, the correct workflow? > > Patchwork likely doesn't like a patch in reply to a pull request, and > I'd assume this should get folded in to the patch in question, to > prevent breaking bisectability. Ok, I will add the changes to the "mtd: rawnand: omap_elm: u-boot driver model support" patch, and after the tests I will submit another pull-request. Thanks and regards, Dario > > -- > Tom -- Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com
On 07/01/2023 20:46, Dario Binacchi wrote: > Hi, > > On Sat, Jan 7, 2023 at 7:36 PM Tom Rini <trini@konsulko.com> wrote: >> >> On Sat, Jan 07, 2023 at 07:32:51PM +0100, Dario Binacchi wrote: >>> Hi, >>> >>> On Sat, Jan 7, 2023 at 6:30 PM Tom Rini <trini@konsulko.com> wrote: >>>> >>>> On Sat, Jan 07, 2023 at 04:48:02PM +0200, Roger Quadros wrote: >>>> >>>>> >>>>> On 07/01/2023 16:19, Roger Quadros wrote: >>>>>> Hi, >>>>>> >>>>>> On 06/01/2023 20:59, Tom Rini wrote: >>>>>>> On Thu, Jan 05, 2023 at 09:10:55AM +0100, Dario Binacchi wrote: >>>>>>> >>>>>>>> Hi Tom, >>>>>>>> >>>>>>>> The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: >>>>>>>> >>>>>>>> Merge branch '2023-01-02-platform-updates' into next (2023-01-02 >>>>>>>> 18:07:41 -0500) >>>>>>>> >>>>>>>> are available in the Git repository at: >>>>>>>> >>>>>>>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash.git >>>>>>>> tags/u-boot-nand-20230104 >>>>>>>> >>>>>>>> for you to fetch changes up to 48f219cb16f88cd2e392e2f438409a00d3ddff54: >>>>>>>> >>>>>>>> mtd: rawnand: omap_elm: u-boot driver model support (2023-01-04 >>>>>>>> 17:24:30 +0100) >>>>>>>> >>>>>>>> Gitlab CI showed no issues: >>>>>>>> https://source.denx.de/u-boot/custodians/u-boot-nand-flash/-/pipelines/14597 >>>>>>>> >>>>>>> >>>>>>> NAK. This commit: >>>>>>> commit 48f219cb16f88cd2e392e2f438409a00d3ddff54 >>>>>>> Author: Roger Quadros <rogerq@kernel.org> >>>>>>> Date: Tue Dec 20 12:22:03 2022 +0200 >>>>>>> >>>>>>> mtd: rawnand: omap_elm: u-boot driver model support >>>>>>> >>>>>>> Support u-boot driver model. We still retain >>>>>>> support legacy way of doing things if ELM_BASE >>>>>>> is defined in <asm/arch/hardware.h> >>>>>>> >>>>>>> We could completely get rid of that if all >>>>>>> platforms defining ELM_BASE get rid of that definition >>>>>>> and enable CONFIG_SYS_NAND_SELF_INIT and are verified >>>>>>> to work. >>>>>>> >>>>>>> Signed-off-by: Roger Quadros <rogerq@kernel.org> >>>>>>> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> >>>>>>> >>>>>>> Breaks am335x_evm thusly: >>>>>>> U-Boot SPL 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) >>>>>>> Trying to boot from MMC1 >>>>>>> >>>>>>> >>>>>>> U-Boot 2023.01-rc4-00388-g48f219cb16f8-dirty (Jan 06 2023 - 13:56:52 -0500) >>>>>>> >>>>>>> CPU : AM335X-GP rev 2.1 >>>>>>> Model: TI AM335x EVM >>>>>>> DRAM: 1 GiB >>>>>>> Error binding driver 'omap-elm': -96 >>>>>>> Some drivers failed to bind >>>>>>> Error binding driver 'ti_sysc': -96 >>>>>>> Some drivers failed to bind >>>>>>> Error binding driver 'simple_bus': -96 >>>>>>> Some drivers failed to bind >>>>>>> Error binding driver 'simple_bus': -96 >>>>>>> Some drivers failed to bind >>>>>>> Error binding driver 'simple_bus': -96 >>>>>>> Some drivers failed to bind >>>>>>> initcall sequence bffdbbe0 failed at call 808155a9 (err=-96) >>>>>>> ### ERROR ### Please RESET the board ### >>>>>>> >>>>>> >>>>>> Sorry about that. My broken am335x-evm has suddenly come alive. >>>>>> I will come up with a fix in a day or two. >>>>> >>>>> The below patch fixes boot on am335x-evm for me. >>>>> >>>>> Does it look reasonable? >>>>> >>>>> From 06e2695f8420a1fa6eaf3fcf2e5dbbf28c73a34d Mon Sep 17 00:00:00 2001 >>>>> From: Roger Quadros <rogerq@kernel.org> >>>>> Date: Sat, 7 Jan 2023 16:40:52 +0200 >>>>> Subject: [PATCH] mtd: rawnand: omap_elm: Fix boot on am335x-evm >>>>> >>>>> Prevent registering with Driver Model if CONFIG_SYS_NAND_SELF_INIT >>>>> is not enabled. >>>>> >>>>> Legacy OMAP2+ systems do not use driver model yet for >>>>> NAND/ELM and don't define CONFIG_SYS_NAND_SELF_INIT. >>>>> >>>>> Signed-off-by: Roger Quadros <rogerq@kernel.org> >>>> >>>> Reviewed-by: Tom Rini <trini@konsulko.com> >>> >>> If Roger will submit this patch (I still don't see it with patchwork), tomorrow >>> I will add to the other patches, I will run the tests and in case of success >>> I will submit a new pull-request. >>> Is this, Tom, the correct workflow? >> >> Patchwork likely doesn't like a patch in reply to a pull request, and >> I'd assume this should get folded in to the patch in question, to >> prevent breaking bisectability. > > Ok, I will add the changes to the "mtd: rawnand: omap_elm: u-boot > driver model support" patch, > and after the tests I will submit another pull-request. > > Thanks and regards, > Dario Thank you Dario and Tom. cheers, -roger
Hi Tom, The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: Merge branch '2023-01-02-platform-updates' into next (2023-01-02 18:07:41 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-nand-flash.git tags/u-boot-nand-20230104 for you to fetch changes up to 48f219cb16f88cd2e392e2f438409a00d3ddff54: mtd: rawnand: omap_elm: u-boot driver model support (2023-01-04 17:24:30 +0100) Gitlab CI showed no issues: https://source.denx.de/u-boot/custodians/u-boot-nand-flash/-/pipelines/14597 ---------------------------------------------------------------- Pull request for u-boot-nand-20230104 - rawnand: omap_gpmc: driver model support ---------------------------------------------------------------- Roger Quadros (8): mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based correction mtd: rawnand: nand_base: Allow base driver to be used in SPL without nand_bbt dt-bindings: mtd: Add ti, gpmc-nand DT binding documentation mtd: rawnand: omap_gpmc: support u-boot driver model mtd: rawnand: omap_gpmc: Add SPL NAND support mtd: rawnand: omap_gpmc: Enable SYS_NAND_PAGE_COUNT for OMAP_GPMC dt-bindings: mtd: Add ti, elm DT binding documentation mtd: rawnand: omap_elm: u-boot driver model support doc/device-tree-bindings/mtd/ti,elm.yaml | 72 ++++++++++++++++ doc/device-tree-bindings/mtd/ti,gpmc-nand.yaml | 129 ++++++++++++++++++++++++++++ drivers/mtd/nand/raw/Kconfig | 9 +- drivers/mtd/nand/raw/Makefile | 2 +- drivers/mtd/nand/raw/nand_base.c | 18 +++- drivers/mtd/nand/raw/omap_elm.c | 35 +++++++- {include/linux/mtd => drivers/mtd/nand/raw}/omap_elm.h | 6 ++ drivers/mtd/nand/raw/omap_gpmc.c | 441 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------- 8 files changed, 604 insertions(+), 108 deletions(-) create mode 100644 doc/device-tree-bindings/mtd/ti,elm.yaml create mode 100644 doc/device-tree-bindings/mtd/ti,gpmc-nand.yaml rename {include/linux/mtd => drivers/mtd/nand/raw}/omap_elm.h (97%)