| Message ID | 9700c23ecb36ed17abdcb8c6c47ceb7b2cd99d77.1622706702.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | ca8bb0ccb752e38c49fc37e83af4857b04487ebb |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | gpio: pca953x: Add missing i2c dependency | expand |
čt 3. 6. 2021 v 9:51 odesílatel Michal Simek <michal.simek@xilinx.com> napsal: > > pca953x also depends on i2c that's why add dependency to Kconfig. > Where GPIO is enabled but I2C compilation error pops up. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/gpio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index d24884739bf2..de4dc51d4b48 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -396,7 +396,7 @@ config DM_74X164 > > config DM_PCA953X > bool "PCA95[357]x, PCA9698, TCA64xx, and MAX7310 I/O ports" > - depends on DM_GPIO > + depends on DM_GPIO && DM_I2C > help > Say yes here to provide access to several register-oriented > SMBus I/O expanders, made mostly by NXP or TI. Compatible > -- > 2.31.1 > Applied. M
Hello Michal, On 03.06.21 09:51, Michal Simek wrote: > pca953x also depends on i2c that's why add dependency to Kconfig. > Where GPIO is enabled but I2C compilation error pops up. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/gpio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index d24884739bf2..de4dc51d4b48 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -396,7 +396,7 @@ config DM_74X164 config DM_PCA953X bool "PCA95[357]x, PCA9698, TCA64xx, and MAX7310 I/O ports" - depends on DM_GPIO + depends on DM_GPIO && DM_I2C help Say yes here to provide access to several register-oriented SMBus I/O expanders, made mostly by NXP or TI. Compatible
pca953x also depends on i2c that's why add dependency to Kconfig. Where GPIO is enabled but I2C compilation error pops up. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)