diff mbox series

[v1,4/7] arm: dts: rockchip: rk3288: partial sync edp node

Message ID 889fd644-8576-5383-cb9a-d7ae2f26f541@gmail.com
State Superseded
Delegated to: Kever Yang
Headers show
Series [v1,1/7] arm: dts: rockchip: rk3288: move io-domains nodes | expand

Commit Message

Johan Jonker March 14, 2023, 6:16 p.m. UTC
The rk3288 edp node has a phy node in Linux with a clock
property while current U-boot driver expects this clock
on position index 1. Move U-boot specific DT clock properties
to rk3288-u-boot.dtsi and partially the sync edp node.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm/dts/rk3288-u-boot.dtsi |  5 +++++
 arch/arm/dts/rk3288.dtsi        | 17 +++++++++++------
 2 files changed, 16 insertions(+), 6 deletions(-)

--
2.20.1

Comments

Simon Glass March 15, 2023, 2:05 p.m. UTC | #1
On Tue, 14 Mar 2023 at 12:16, Johan Jonker <jbx6244@gmail.com> wrote:
>
> The rk3288 edp node has a phy node in Linux with a clock
> property while current U-boot driver expects this clock

U-Boot

> on position index 1. Move U-boot specific DT clock properties

U-Boot-specific

> to rk3288-u-boot.dtsi and partially the sync edp node.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  arch/arm/dts/rk3288-u-boot.dtsi |  5 +++++
>  arch/arm/dts/rk3288.dtsi        | 17 +++++++++++------
>  2 files changed, 16 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>  # chromebook-jerry
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3288-u-boot.dtsi b/arch/arm/dts/rk3288-u-boot.dtsi
index e411445e..ca229150 100644
--- a/arch/arm/dts/rk3288-u-boot.dtsi
+++ b/arch/arm/dts/rk3288-u-boot.dtsi
@@ -91,6 +91,11 @@ 
 	u-boot,dm-pre-reloc;
 };

+&edp {
+	clocks = <&cru SCLK_EDP>, <&cru SCLK_EDP_24M>, <&cru PCLK_EDP_CTRL>;
+	clock-names = "clk_edp", "clk_edp_24m", "pclk_edp";
+};
+
 &gpio7 {
 	u-boot,dm-pre-reloc;
 };
diff --git a/arch/arm/dts/rk3288.dtsi b/arch/arm/dts/rk3288.dtsi
index f06d1f5b..9f924466 100644
--- a/arch/arm/dts/rk3288.dtsi
+++ b/arch/arm/dts/rk3288.dtsi
@@ -1177,19 +1177,24 @@ 
 	};

 	edp: dp@ff970000 {
-		compatible = "rockchip,rk3288-edp";
+		compatible = "rockchip,rk3288-dp";
 		reg = <0xff970000 0x4000>;
 		interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
-		clocks = <&cru SCLK_EDP>, <&cru SCLK_EDP_24M>, <&cru PCLK_EDP_CTRL>;
-		clock-names = "clk_edp", "clk_edp_24m", "pclk_edp";
+		clocks = <&cru SCLK_EDP>, <&cru PCLK_EDP_CTRL>;
+		clock-names = "dp", "pclk";
+		phys = <&edp_phy>;
+		phy-names = "dp";
+		power-domains = <&power RK3288_PD_VIO>;
 		resets = <&cru SRST_EDP>;
-		reset-names = "edp";
+		reset-names = "dp";
 		rockchip,grf = <&grf>;
-		power-domains = <&power RK3288_PD_VIO>;
 		status = "disabled";

 		ports {
-			edp_in: port {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			edp_in: port@0 {
+				reg = <0>;
 				#address-cells = <1>;
 				#size-cells = <0>;
 				edp_in_vopb: endpoint@0 {