| Message ID | 86b78891f1d00c37db148fbea1b99403d31131fe.1597826658.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Incorrect Kconfig dependencies | expand |
On Wed, Aug 19, 2020 at 10:44:17AM +0200, Michal Simek wrote: > CMD_ADC selected DM_REGULATOR unconditionally without enabling DM. > That's why change select to depends on to cover it. > > Kconfig is showing this issue as: > WARNING: unmet direct dependencies detected for REGMAP > Depends on [n]: DM [=n] > Selected by [y]: > - DM_REGULATOR_PBIAS [=y] && DM_REGULATOR [=y] > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On Wed, Aug 19, 2020 at 10:44:17AM +0200, Michal Simek wrote: > CMD_ADC selected DM_REGULATOR unconditionally without enabling DM. > That's why change select to depends on to cover it. > > Kconfig is showing this issue as: > WARNING: unmet direct dependencies detected for REGMAP > Depends on [n]: DM [=n] > Selected by [y]: > - DM_REGULATOR_PBIAS [=y] && DM_REGULATOR [=y] > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/cmd/Kconfig b/cmd/Kconfig index 692fae5b8e89..bd3559ae6c12 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -854,7 +854,7 @@ config CMD_ARMFLASH config CMD_ADC bool "adc - Access Analog to Digital Converters info and data" select ADC - select DM_REGULATOR + depends on DM_REGULATOR help Shows ADC device info and permit printing one-shot analog converted data from a named Analog to Digital Converter.
CMD_ADC selected DM_REGULATOR unconditionally without enabling DM. That's why change select to depends on to cover it. Kconfig is showing this issue as: WARNING: unmet direct dependencies detected for REGMAP Depends on [n]: DM [=n] Selected by [y]: - DM_REGULATOR_PBIAS [=y] && DM_REGULATOR [=y] Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)