| Message ID | 856ada64-ba6e-4f32-bbf5-23030df85238@siemens.com |
|---|---|
| State | Accepted |
| Commit | 959a4a0838acf7ef733e000d1304cea6711b8945 |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | spi: cadence-quadspi: Fix error message on stuck busy state | expand |
On 10/30/23 17:20, Jan Kiszka wrote: > From: Jan Kiszka <jan.kiszka@siemens.com> > > We are not iterating CQSPI_REG_RETRY, we are waiting 'timeout' ms, since > day 1. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > > We are unfortunately seeing that message right now, rarely but then > prominently... > > drivers/spi/cadence_qspi_apb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c > index 9ce2c0f254f..d033184aa46 100644 > --- a/drivers/spi/cadence_qspi_apb.c > +++ b/drivers/spi/cadence_qspi_apb.c > @@ -171,8 +171,7 @@ static unsigned int cadence_qspi_wait_idle(void *reg_base) > } > > /* Timeout, still in busy mode. */ > - printf("QSPI: QSPI is still busy after poll for %d times.\n", > - CQSPI_REG_RETRY); > + printf("QSPI: QSPI is still busy after poll for %d ms.\n", timeout); > return 0; > } > Viele Grüße, Stefan Roese
On 31.10.23 08:14, Stefan Roese wrote: > On 10/30/23 17:20, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kiszka@siemens.com> >> >> We are not iterating CQSPI_REG_RETRY, we are waiting 'timeout' ms, since >> day 1. >> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > > Reviewed-by: Stefan Roese <sr@denx.de> > > Thanks, > Stefan > >> --- >> >> We are unfortunately seeing that message right now, rarely but then >> prominently... >> >> drivers/spi/cadence_qspi_apb.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/spi/cadence_qspi_apb.c >> b/drivers/spi/cadence_qspi_apb.c >> index 9ce2c0f254f..d033184aa46 100644 >> --- a/drivers/spi/cadence_qspi_apb.c >> +++ b/drivers/spi/cadence_qspi_apb.c >> @@ -171,8 +171,7 @@ static unsigned int cadence_qspi_wait_idle(void >> *reg_base) >> } >> /* Timeout, still in busy mode. */ >> - printf("QSPI: QSPI is still busy after poll for %d times.\n", >> - CQSPI_REG_RETRY); >> + printf("QSPI: QSPI is still busy after poll for %d ms.\n", timeout); >> return 0; >> } >> > > Viele Grüße, > Stefan Roese > Ping. Jan
On Thu, Dec 14, 2023 at 06:36:37PM +0100, Jan Kiszka wrote: > On 31.10.23 08:14, Stefan Roese wrote: > > On 10/30/23 17:20, Jan Kiszka wrote: > >> From: Jan Kiszka <jan.kiszka@siemens.com> > >> > >> We are not iterating CQSPI_REG_RETRY, we are waiting 'timeout' ms, since > >> day 1. > >> > >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > > > > Reviewed-by: Stefan Roese <sr@denx.de> > > > > Thanks, > > Stefan > > > >> --- > >> > >> We are unfortunately seeing that message right now, rarely but then > >> prominently... > >> > >> drivers/spi/cadence_qspi_apb.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/drivers/spi/cadence_qspi_apb.c > >> b/drivers/spi/cadence_qspi_apb.c > >> index 9ce2c0f254f..d033184aa46 100644 > >> --- a/drivers/spi/cadence_qspi_apb.c > >> +++ b/drivers/spi/cadence_qspi_apb.c > >> @@ -171,8 +171,7 @@ static unsigned int cadence_qspi_wait_idle(void > >> *reg_base) > >> } > >> /* Timeout, still in busy mode. */ > >> - printf("QSPI: QSPI is still busy after poll for %d times.\n", > >> - CQSPI_REG_RETRY); > >> + printf("QSPI: QSPI is still busy after poll for %d ms.\n", timeout); > >> return 0; > >> } > >> > > > > Viele Grüße, > > Stefan Roese > > > > Ping. Added to my dont-forget bundle.
On Mon, Oct 30, 2023 at 9:50 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: > > From: Jan Kiszka <jan.kiszka@siemens.com> > > We are not iterating CQSPI_REG_RETRY, we are waiting 'timeout' ms, since > day 1. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- Applied to u-boot-spi/master
diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c index 9ce2c0f254f..d033184aa46 100644 --- a/drivers/spi/cadence_qspi_apb.c +++ b/drivers/spi/cadence_qspi_apb.c @@ -171,8 +171,7 @@ static unsigned int cadence_qspi_wait_idle(void *reg_base) } /* Timeout, still in busy mode. */ - printf("QSPI: QSPI is still busy after poll for %d times.\n", - CQSPI_REG_RETRY); + printf("QSPI: QSPI is still busy after poll for %d ms.\n", timeout); return 0; }