diff mbox series

dwc_eth_qos: Revert regression handling fixed phy

Message ID 5cf38ecf-f02c-4219-90e8-aceccf558b43@gmx.de
State New
Delegated to: Ramon Fried
Headers show
Series dwc_eth_qos: Revert regression handling fixed phy | expand

Commit Message

Elmar Psilog April 17, 2024, 8:41 a.m. UTC 
Subject: [PATCH] dwc_eth_qos: Revert regression handling fixed phy

In imx8mp operation on eqos with fixed phy I get without that patch:
ERROR: no/invalid <fixed-link< property!
---
  drivers/net/dwc_eth_qos.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Marek Vasut April 17, 2024, 11:15 a.m. UTC | #1 
On 4/17/24 10:41 AM, Nicole Battenfeld wrote:
> Subject: [PATCH] dwc_eth_qos: Revert regression handling fixed phy
> 
> In imx8mp operation on eqos with fixed phy I get without that patch:
> ERROR: no/invalid <fixed-link< property!

Which commit is being reverted here ?
Elmar Psilog April 17, 2024, 4:40 p.m. UTC | #2 
On 4/17/24 13:15, Marek Vasut wrote:
> On 4/17/24 10:41 AM, Nicole Battenfeld wrote:
>> Subject: [PATCH] dwc_eth_qos: Revert regression handling fixed phy
>>
>> In imx8mp operation on eqos with fixed phy I get without that patch:
>> ERROR: no/invalid <fixed-link< property!
>
> Which commit is being reverted here ?

True. I just checked the mails last year and my confusion grows.

It was right here at the bottom:
https://lists.denx.de/pipermail/u-boot/2023-February/509156.html

But already in PATCH_v2 it seems that line was dropped, my fault.
diff mbox series

Patch

diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index 67d80d987f..8ca8adead9 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -801,8 +801,10 @@  static int eqos_start(struct udevice *dev)
  		if (IS_ENABLED(CONFIG_PHY_FIXED)) {
  			fixed_node = ofnode_find_subnode(dev_ofnode(dev),
  							 "fixed-link");
-			if (ofnode_valid(fixed_node))
+			if (ofnode_valid(fixed_node)) {
  				eqos->phy = fixed_phy_create(dev_ofnode(dev));
+				eqos->phy_of_node = fixed_node;
+			}
  		}

  		if (!eqos->phy) {