diff mbox

[U-Boot] Banan Pro (ahci-sunxi) SATA port stopped working after switching to U-Boot v2016.01

Message ID 56A237A4.7020201@redhat.com
State Accepted
Delegated to: Hans de Goede
Headers show

Commit Message

Hans de Goede Jan. 22, 2016, 2:07 p.m. UTC
Hi,

On 21-01-16 00:34, Markus Baier wrote:
> Am 19.01.2016 um 18:12 schrieb Tom Rini:
>  > On Sun, Jan 17, 2016 at 09:44:53PM +0100, Markus Baier wrote:
>  >
>  >> Hello,
>  >>
>  >> tonight I switched  to the new U-Boot v2016.01
>  >> on my Banana Pro system.
>  >> I compiled u-boot, like I did with all the working
>  >> versions before, with:
>  >> make Bananapro_defconfig
>  >> make
>  >>
>  >> But with the new U-Boot installed the SATA Port
>  >> did not work anymore.
>  >> The Kernel is the same 4.0.9-gentoo as I used before
>  >> with the last U-Boot Release v2015.10
>  >>
>  >> dmesg show me the following error in the kernel log:
>  >> [    1.925032] ahci-sunxi 1c18000.sata: PHY power up failed.
>  >> [    1.930661] ahci-sunxi: probe of 1c18000.sata failed with error -5
>  >>
>  >> I also see now SATA message at the U-Boot bootscreen,
>  >> the v2015.10 shows me that a SATA Port was recognized
>  >> by the U-Boot loader.
>  >
>  > Can you please use git bisect to determine which commit broke this?
>  > Thanks!
>
> Hi,
>
> thanks for the advice, I have found the bad commit,
> it is -> 02cc27c74f9b884b538bcd1b93342a4c05b5d608
> sunxi: power: Change axp209 LDO3 and LDO4 default to disabled
>
> after that I tried the v2016.01 release again, but changed
> the two lines in config AXP_ALDO3_VOLT and config AXP_ALDO4_VOLT
> back to their old values, now the SATA Port is working again.

Thanks for debugging this, according to the Bananapro schematic
VDD25-SATA either comes from a dedicated WL2003E25-5 linear regulator,
or it is connected to LDO4 via a 0 Ohm resistor.

So it would seem that in practice it seems that LDO4 is used, can you
give the attached patch a try ?

Regards,

Hans

Comments

Peter Korsgaard Jan. 22, 2016, 6:47 p.m. UTC | #1
>>>>> "Hans" == Hans de Goede <hdegoede@redhat.com> writes:

Hi,

 > Thanks for debugging this, according to the Bananapro schematic
 > VDD25-SATA either comes from a dedicated WL2003E25-5 linear regulator,
 > or it is connected to LDO4 via a 0 Ohm resistor.

 > So it would seem that in practice it seems that LDO4 is used, can you
 > give the attached patch a try ?

 >> From b931b7bd6ec02ffa32f155d381c16210819a16ea Mon Sep 17 00:00:00 2001
 > From: Hans de Goede <hdegoede@redhat.com>
 > Date: Fri, 22 Jan 2016 14:55:47 +0100
 > Subject: [PATCH] sunxi: Bananapro: Set LDO4 to 2.5V

 > According to the Bananapro VDD25-SATA either comes from a dedicated

You forgot 'schematics'.
Hans de Goede Jan. 26, 2016, 7:42 p.m. UTC | #2
Hi,

On 01/22/2016 03:07 PM, Hans de Goede wrote:
> Hi,
>
> On 21-01-16 00:34, Markus Baier wrote:
>> Am 19.01.2016 um 18:12 schrieb Tom Rini:
>>  > On Sun, Jan 17, 2016 at 09:44:53PM +0100, Markus Baier wrote:
>>  >
>>  >> Hello,
>>  >>
>>  >> tonight I switched  to the new U-Boot v2016.01
>>  >> on my Banana Pro system.
>>  >> I compiled u-boot, like I did with all the working
>>  >> versions before, with:
>>  >> make Bananapro_defconfig
>>  >> make
>>  >>
>>  >> But with the new U-Boot installed the SATA Port
>>  >> did not work anymore.
>>  >> The Kernel is the same 4.0.9-gentoo as I used before
>>  >> with the last U-Boot Release v2015.10
>>  >>
>>  >> dmesg show me the following error in the kernel log:
>>  >> [    1.925032] ahci-sunxi 1c18000.sata: PHY power up failed.
>>  >> [    1.930661] ahci-sunxi: probe of 1c18000.sata failed with error -5
>>  >>
>>  >> I also see now SATA message at the U-Boot bootscreen,
>>  >> the v2015.10 shows me that a SATA Port was recognized
>>  >> by the U-Boot loader.
>>  >
>>  > Can you please use git bisect to determine which commit broke this?
>>  > Thanks!
>>
>> Hi,
>>
>> thanks for the advice, I have found the bad commit,
>> it is -> 02cc27c74f9b884b538bcd1b93342a4c05b5d608
>> sunxi: power: Change axp209 LDO3 and LDO4 default to disabled
>>
>> after that I tried the v2016.01 release again, but changed
>> the two lines in config AXP_ALDO3_VOLT and config AXP_ALDO4_VOLT
>> back to their old values, now the SATA Port is working again.
>
> Thanks for debugging this, according to the Bananapro schematic
> VDD25-SATA either comes from a dedicated WL2003E25-5 linear regulator,
> or it is connected to LDO4 via a 0 Ohm resistor.
>
> So it would seem that in practice it seems that LDO4 is used, can you
> give the attached patch a try ?

I had access to a bananapro board myself today, and I can confirm that
the patch I wrote fixes this.

Regards,

Hans
diff mbox

Patch

From b931b7bd6ec02ffa32f155d381c16210819a16ea Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat.com>
Date: Fri, 22 Jan 2016 14:55:47 +0100
Subject: [PATCH] sunxi: Bananapro: Set LDO4 to 2.5V

According to the Bananapro VDD25-SATA either comes from a dedicated
WL2003E25-5 LTO, or it is connected to LDO4 via a 0 Ohm resistor.

In practice it seems that LDO4 is used, so enable it and set it to 2.5V.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 configs/Bananapro_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/Bananapro_defconfig b/configs/Bananapro_defconfig
index 40588b9..4f4a07b 100644
--- a/configs/Bananapro_defconfig
+++ b/configs/Bananapro_defconfig
@@ -17,3 +17,4 @@  CONFIG_CMD_GPIO=y
 CONFIG_NETCONSOLE=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_USB_EHCI_HCD=y
+CONFIG_AXP_ALDO4_VOLT=2500
-- 
2.5.0