diff mbox

[U-Boot] fix IDE_BUS(dev) macro

Message ID 4FCB7CB1.9080802@gmail.com
State Not Applicable
Headers show

Commit Message

Vágó Tibor June 3, 2012, 3:03 p.m. UTC 
Hi,

I've tested this IDE patch on my NAS6220 and it works.

U-boot detect both HDD correctly and boot from them.

Cheers,
Tibor


-------- Original message --------
IDE_BUS assumes that each bus has two devices and thus returns the first
bus even when the second one should be probed.

Signed-off-by: Simon Baatz <gmbnomis at gmail.com>
Tested-by: Luka Perkov <uboot at lukaperkov.net>
---

Simon discovered this while adding support for new board IB NAS6210.

More info can be found here:

http://lists.denx.de/pipermail/u-boot/2012-April/122525.html

When this is commited I will do a coding style cleanup. There are tabs
after few "#define" parts in include/ide.h.

  include/ide.h |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

(CONFIG_SYS_ATA_BASE_ADDR+ide_bus_offset[IDE_BUS(dev)])

Comments

Luka Perkov June 3, 2012, 9:24 p.m. UTC | #1 
Hi Tibor,

On Sun, Jun 03, 2012 at 05:03:13PM +0200, Vágó Tibor wrote:
> Hi,
> 
> I've tested this IDE patch on my NAS6220 and it works.
> 
> U-boot detect both HDD correctly and boot from them.

Thank you for testing.

Regards,
Luka
diff mbox

Patch

diff --git a/include/ide.h b/include/ide.h
index 8ecc9dd..385e909 100644
--- a/include/ide.h
+++ b/include/ide.h
@@ -24,7 +24,7 @@ 
  #ifndef	_IDE_H
  #define _IDE_H

-#define	IDE_BUS(dev)	(dev >> 1)
+#define IDE_BUS(dev)	(dev / (CONFIG_SYS_IDE_MAXDEVICE / 
CONFIG_SYS_IDE_MAXBUS))

  #define	ATA_CURR_BASE(dev)