| Message ID | 39571f1a-1e52-f29d-e89a-38585b70bc7e@samsung.com |
|---|---|
| State | Accepted |
| Commit | 2b77d9a3ee92604bc5ec98f95c6d453dd4e1493a |
| Delegated to: | Minkyu Kang |
| Headers | show |
| Series | [1/2] exynos78x0: pinctrl: set const to structs | expand |
On 11/4/21 4:13 PM, Minkyu Kang wrote: > to fix following checkpatch warings. > WARNING: struct should normally be const > > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > Cc: Dzmitry Sankouski <dsankouski@gmail.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/pinctrl/exynos/pinctrl-exynos78x0.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/exynos/pinctrl-exynos78x0.c b/drivers/pinctrl/exynos/pinctrl-exynos78x0.c > index 01e9a4f..1b696fd 100644 > --- a/drivers/pinctrl/exynos/pinctrl-exynos78x0.c > +++ b/drivers/pinctrl/exynos/pinctrl-exynos78x0.c > @@ -19,12 +19,12 @@ > #include <asm/arch/pinmux.h> > #include "pinctrl-exynos.h" > > -static struct pinctrl_ops exynos78x0_pinctrl_ops = { > +static const struct pinctrl_ops exynos78x0_pinctrl_ops = { > .set_state = exynos_pinctrl_set_state > }; > > /* pin banks of exynos78x0 pin-controller 0 (ALIVE) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks0[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks0[] = { > EXYNOS_PIN_BANK(6, 0x000, "etc0"), > EXYNOS_PIN_BANK(3, 0x020, "etc1"), > EXYNOS_PIN_BANK(8, 0x040, "gpa0"), > @@ -35,19 +35,19 @@ static struct samsung_pin_bank_data exynos78x0_pin_banks0[] = { > }; > > /* pin banks of exynos78x0 pin-controller 1 (CCORE) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks1[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks1[] = { > EXYNOS_PIN_BANK(2, 0x000, "gpm0"), > }; > > /* pin banks of exynos78x0 pin-controller 2 (DISPAUD) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks2[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks2[] = { > EXYNOS_PIN_BANK(4, 0x000, "gpz0"), > EXYNOS_PIN_BANK(6, 0x020, "gpz1"), > EXYNOS_PIN_BANK(4, 0x040, "gpz2"), > }; > > /* pin banks of exynos78x0 pin-controller 4 (FSYS) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks4[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks4[] = { > EXYNOS_PIN_BANK(3, 0x000, "gpr0"), > EXYNOS_PIN_BANK(8, 0x020, "gpr1"), > EXYNOS_PIN_BANK(2, 0x040, "gpr2"), > @@ -56,7 +56,7 @@ static struct samsung_pin_bank_data exynos78x0_pin_banks4[] = { > }; > > /* pin banks of exynos78x0 pin-controller 6 (TOP) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks6[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks6[] = { > EXYNOS_PIN_BANK(4, 0x000, "gpb0"), > EXYNOS_PIN_BANK(3, 0x020, "gpc0"), > EXYNOS_PIN_BANK(4, 0x040, "gpc1"), > @@ -78,7 +78,7 @@ static struct samsung_pin_bank_data exynos78x0_pin_banks6[] = { > EXYNOS_PIN_BANK(5, 0x240, "gpf4"), > }; > > -struct samsung_pin_ctrl exynos78x0_pin_ctrl[] = { > +const struct samsung_pin_ctrl exynos78x0_pin_ctrl[] = { > { > /* pin-controller instance 0 Alive data */ > .pin_banks = exynos78x0_pin_banks0, >
2021년 11월 4일 (목) 16:20, Minkyu Kang <mk7.kang@samsung.com>님이 작성: > to fix following checkpatch warings. > WARNING: struct should normally be const > > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > Cc: Dzmitry Sankouski <dsankouski@gmail.com> > --- > drivers/pinctrl/exynos/pinctrl-exynos78x0.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/exynos/pinctrl-exynos78x0.c > b/drivers/pinctrl/exynos/pinctrl-exynos78x0.c > index 01e9a4f..1b696fd 100644 > --- a/drivers/pinctrl/exynos/pinctrl-exynos78x0.c > +++ b/drivers/pinctrl/exynos/pinctrl-exynos78x0.c > @@ -19,12 +19,12 @@ > #include <asm/arch/pinmux.h> > #include "pinctrl-exynos.h" > > -static struct pinctrl_ops exynos78x0_pinctrl_ops = { > +static const struct pinctrl_ops exynos78x0_pinctrl_ops = { > .set_state = exynos_pinctrl_set_state > }; > > /* pin banks of exynos78x0 pin-controller 0 (ALIVE) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks0[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks0[] = { > EXYNOS_PIN_BANK(6, 0x000, "etc0"), > EXYNOS_PIN_BANK(3, 0x020, "etc1"), > EXYNOS_PIN_BANK(8, 0x040, "gpa0"), > @@ -35,19 +35,19 @@ static struct samsung_pin_bank_data > exynos78x0_pin_banks0[] = { > }; > > /* pin banks of exynos78x0 pin-controller 1 (CCORE) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks1[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks1[] = { > EXYNOS_PIN_BANK(2, 0x000, "gpm0"), > }; > > /* pin banks of exynos78x0 pin-controller 2 (DISPAUD) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks2[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks2[] = { > EXYNOS_PIN_BANK(4, 0x000, "gpz0"), > EXYNOS_PIN_BANK(6, 0x020, "gpz1"), > EXYNOS_PIN_BANK(4, 0x040, "gpz2"), > }; > > /* pin banks of exynos78x0 pin-controller 4 (FSYS) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks4[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks4[] = { > EXYNOS_PIN_BANK(3, 0x000, "gpr0"), > EXYNOS_PIN_BANK(8, 0x020, "gpr1"), > EXYNOS_PIN_BANK(2, 0x040, "gpr2"), > @@ -56,7 +56,7 @@ static struct samsung_pin_bank_data > exynos78x0_pin_banks4[] = { > }; > > /* pin banks of exynos78x0 pin-controller 6 (TOP) */ > -static struct samsung_pin_bank_data exynos78x0_pin_banks6[] = { > +static const struct samsung_pin_bank_data exynos78x0_pin_banks6[] = { > EXYNOS_PIN_BANK(4, 0x000, "gpb0"), > EXYNOS_PIN_BANK(3, 0x020, "gpc0"), > EXYNOS_PIN_BANK(4, 0x040, "gpc1"), > @@ -78,7 +78,7 @@ static struct samsung_pin_bank_data > exynos78x0_pin_banks6[] = { > EXYNOS_PIN_BANK(5, 0x240, "gpf4"), > }; > > -struct samsung_pin_ctrl exynos78x0_pin_ctrl[] = { > +const struct samsung_pin_ctrl exynos78x0_pin_ctrl[] = { > { > /* pin-controller instance 0 Alive data */ > .pin_banks = exynos78x0_pin_banks0, > -- > 1.9.1 > -- > Thanks, > Minkyu Kang. > applied to u-boot-samsung. Thanks.
diff --git a/drivers/pinctrl/exynos/pinctrl-exynos78x0.c b/drivers/pinctrl/exynos/pinctrl-exynos78x0.c index 01e9a4f..1b696fd 100644 --- a/drivers/pinctrl/exynos/pinctrl-exynos78x0.c +++ b/drivers/pinctrl/exynos/pinctrl-exynos78x0.c @@ -19,12 +19,12 @@ #include <asm/arch/pinmux.h> #include "pinctrl-exynos.h" -static struct pinctrl_ops exynos78x0_pinctrl_ops = { +static const struct pinctrl_ops exynos78x0_pinctrl_ops = { .set_state = exynos_pinctrl_set_state }; /* pin banks of exynos78x0 pin-controller 0 (ALIVE) */ -static struct samsung_pin_bank_data exynos78x0_pin_banks0[] = { +static const struct samsung_pin_bank_data exynos78x0_pin_banks0[] = { EXYNOS_PIN_BANK(6, 0x000, "etc0"), EXYNOS_PIN_BANK(3, 0x020, "etc1"), EXYNOS_PIN_BANK(8, 0x040, "gpa0"), @@ -35,19 +35,19 @@ static struct samsung_pin_bank_data exynos78x0_pin_banks0[] = { }; /* pin banks of exynos78x0 pin-controller 1 (CCORE) */ -static struct samsung_pin_bank_data exynos78x0_pin_banks1[] = { +static const struct samsung_pin_bank_data exynos78x0_pin_banks1[] = { EXYNOS_PIN_BANK(2, 0x000, "gpm0"), }; /* pin banks of exynos78x0 pin-controller 2 (DISPAUD) */ -static struct samsung_pin_bank_data exynos78x0_pin_banks2[] = { +static const struct samsung_pin_bank_data exynos78x0_pin_banks2[] = { EXYNOS_PIN_BANK(4, 0x000, "gpz0"), EXYNOS_PIN_BANK(6, 0x020, "gpz1"), EXYNOS_PIN_BANK(4, 0x040, "gpz2"), }; /* pin banks of exynos78x0 pin-controller 4 (FSYS) */ -static struct samsung_pin_bank_data exynos78x0_pin_banks4[] = { +static const struct samsung_pin_bank_data exynos78x0_pin_banks4[] = { EXYNOS_PIN_BANK(3, 0x000, "gpr0"), EXYNOS_PIN_BANK(8, 0x020, "gpr1"), EXYNOS_PIN_BANK(2, 0x040, "gpr2"), @@ -56,7 +56,7 @@ static struct samsung_pin_bank_data exynos78x0_pin_banks4[] = { }; /* pin banks of exynos78x0 pin-controller 6 (TOP) */ -static struct samsung_pin_bank_data exynos78x0_pin_banks6[] = { +static const struct samsung_pin_bank_data exynos78x0_pin_banks6[] = { EXYNOS_PIN_BANK(4, 0x000, "gpb0"), EXYNOS_PIN_BANK(3, 0x020, "gpc0"), EXYNOS_PIN_BANK(4, 0x040, "gpc1"), @@ -78,7 +78,7 @@ static struct samsung_pin_bank_data exynos78x0_pin_banks6[] = { EXYNOS_PIN_BANK(5, 0x240, "gpf4"), }; -struct samsung_pin_ctrl exynos78x0_pin_ctrl[] = { +const struct samsung_pin_ctrl exynos78x0_pin_ctrl[] = { { /* pin-controller instance 0 Alive data */ .pin_banks = exynos78x0_pin_banks0,
to fix following checkpatch warings. WARNING: struct should normally be const Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> Cc: Dzmitry Sankouski <dsankouski@gmail.com> --- drivers/pinctrl/exynos/pinctrl-exynos78x0.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)