diff mbox series

[09/24] qconfig: Move arg checking to the top of main()

Message ID 20240717155712.2913651-10-sjg@chromium.org
State Accepted
Commit 382c662c825416f875c082154e63a35532dab2e3
Delegated to: Simon Glass
Headers show
Series qconfig: Tidy up main() and add a small feature | expand

Commit Message

Simon Glass July 17, 2024, 3:56 p.m. UTC 
Check for 'test' as one of the possible operations for this tool,
moving the check above the implementation.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/qconfig.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Simon Glass July 26, 2024, 12:59 p.m. UTC | #1 
Check for 'test' as one of the possible operations for this tool,
moving the check above the implementation.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/qconfig.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Applied to u-boot-dm, thanks!
diff mbox series

Patch

diff --git a/tools/qconfig.py b/tools/qconfig.py
index 6d263ce30db..9052aedf57d 100755
--- a/tools/qconfig.py
+++ b/tools/qconfig.py
@@ -1524,6 +1524,10 @@  doc/develop/moveconfig.rst for documentation.'''
 def main():
     """Main program"""
     parser, args = parse_args()
+    if not any((args.force_sync, args.build_db, args.imply, args.find,
+                args.scan_source, args.test)):
+        parser.print_usage()
+        sys.exit(1)
     if args.test:
         sys.argv = [sys.argv[0]]
         fail, _ = doctest.testmod()
@@ -1534,11 +1538,6 @@  def main():
     col = terminal.Color(terminal.COLOR_NEVER if args.nocolour
                          else terminal.COLOR_IF_TERMINAL)
 
-    if not any((args.force_sync, args.build_db, args.imply, args.find,
-                args.scan_source)):
-        parser.print_usage()
-        sys.exit(1)
-
     if args.scan_source:
         do_scan_source(os.getcwd(), args.update)
         return 0