diff mbox series

[1/1] defconfig: disable VIDEO_COPY on the sandbox

Message ID 20240517160624.156962-1-heinrich.schuchardt@canonical.com
State New
Delegated to: Simon Glass
Headers show
Series [1/1] defconfig: disable VIDEO_COPY on the sandbox | expand

Commit Message

Heinrich Schuchardt May 17, 2024, 4:06 p.m. UTC
Since commit a75cf70d23ac ("efi: Correct handling of frame buffer") the EFI
block image transfer is broken on the sandbox.

To test build sandbox_defconfig with CONFIG_EFI_SELFTEST=y and execute

    setenv efi_selftest block image transfer
    bootefi selftest

Fixes: a75cf70d23ac ("efi: Correct handling of frame buffer")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 configs/sandbox_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Jiaxun Yang May 17, 2024, 4:35 p.m. UTC | #1
在2024年5月17日五月 下午5:06,Heinrich Schuchardt写道:
> Since commit a75cf70d23ac ("efi: Correct handling of frame buffer") the EFI
> block image transfer is broken on the sandbox.
>
> To test build sandbox_defconfig with CONFIG_EFI_SELFTEST=y and execute
>
>     setenv efi_selftest block image transfer
>     bootefi selftest
>
> Fixes: a75cf70d23ac ("efi: Correct handling of frame buffer")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

It turns out that texture copy is only required for 8bpc display, which
we don't care much anyway.

Thanks
- Jiaxun

> ---
>  configs/sandbox_defconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
> index 93b52f2de5c..80c310b8e82 100644
> --- a/configs/sandbox_defconfig
> +++ b/configs/sandbox_defconfig
> @@ -318,7 +318,6 @@ CONFIG_USB_ETHER=y
>  CONFIG_USB_ETH_CDC=y
>  CONFIG_VIDEO=y
>  CONFIG_VIDEO_FONT_SUN12X22=y
> -CONFIG_VIDEO_COPY=y
>  CONFIG_CONSOLE_ROTATION=y
>  CONFIG_CONSOLE_TRUETYPE=y
>  CONFIG_CONSOLE_TRUETYPE_CANTORAONE=y
> -- 
> 2.43.0
diff mbox series

Patch

diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index 93b52f2de5c..80c310b8e82 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -318,7 +318,6 @@  CONFIG_USB_ETHER=y
 CONFIG_USB_ETH_CDC=y
 CONFIG_VIDEO=y
 CONFIG_VIDEO_FONT_SUN12X22=y
-CONFIG_VIDEO_COPY=y
 CONFIG_CONSOLE_ROTATION=y
 CONFIG_CONSOLE_TRUETYPE=y
 CONFIG_CONSOLE_TRUETYPE_CANTORAONE=y