| Message ID | 20240408223134.165877-13-j-humphreys@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | EFI: ti: Enable EFI capsule updates | expand |
Hi Jonathan, Thank you for the patch. On lun., avril 08, 2024 at 17:31, Jonathan Humphreys <j-humphreys@ti.com> wrote: > Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com> Please consider adding a commit message body. On the TI vendor tree, there is a similar patch with a commit message: https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2023.04&id=c5296d943c2c84dd6dcb3b91305d006ac46f3157 Before patch: => reset resetting ... System reset not supported on this platform ### ERROR ### Please RESET the board ### With patch applied: => reset resetting ... Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on am62x sk evm Andrew also suggested to me that if we are interested by A53 reset only, we can PSCI reset instead for all k3 architecture: --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -784,6 +784,9 @@ config ARCH_K3 bool "Texas Instruments' K3 Architecture" select SPL select SUPPORT_SPL + select PSCI_RESET if ARM64 + select SYSRESET if ARM64 + select SYSRESET_PSCI if ARM64 select FIT select REGEX select FIT_SIGNATURE if ARM64 Has the above been considered? > --- > arch/arm/dts/k3-am625-sk-u-boot.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi > index fa778b0ff4c..35bfeae75a0 100644 > --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi > +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi > @@ -46,3 +46,12 @@ > &cpsw_port2 { > status = "disabled"; > }; > + > +&dmsc { > + bootph-pre-ram; > + > + k3_sysreset: sysreset-controller { > + compatible = "ti,sci-sysreset"; > + bootph-pre-ram; > + }; > +}; > -- > 2.34.1
Mattijs Korpershoek <mkorpershoek@baylibre.com> writes: > Hi Jonathan, > > Thank you for the patch. > > On lun., avril 08, 2024 at 17:31, Jonathan Humphreys <j-humphreys@ti.com> wrote: > >> Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com> > > Please consider adding a commit message body. Got it. thanks. BTW, the next version of this series will drop this patch as Andrew has submitted another patch removing the need for this one. See https://lore.kernel.org/r/20240402160908.508974-1-afd@ti.com. > > On the TI vendor tree, there is a similar patch with a commit message: > https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2023.04&id=c5296d943c2c84dd6dcb3b91305d006ac46f3157 > > Before patch: > => reset > resetting ... > System reset not supported on this platform > ### ERROR ### Please RESET the board ### > > With patch applied: > => reset > resetting ... > > Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on am62x sk evm > > Andrew also suggested to me that if we are interested by A53 reset only, > we can PSCI reset instead for all k3 architecture: > > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -784,6 +784,9 @@ config ARCH_K3 > bool "Texas Instruments' K3 Architecture" > select SPL > select SUPPORT_SPL > + select PSCI_RESET if ARM64 > + select SYSRESET if ARM64 > + select SYSRESET_PSCI if ARM64 > select FIT > select REGEX > select FIT_SIGNATURE if ARM64 > > Has the above been considered? I am not aware. I would think that you want full reset, unless you are thinking about specifying a reset level? Jon > > >> --- >> arch/arm/dts/k3-am625-sk-u-boot.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >> index fa778b0ff4c..35bfeae75a0 100644 >> --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi >> +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >> @@ -46,3 +46,12 @@ >> &cpsw_port2 { >> status = "disabled"; >> }; >> + >> +&dmsc { >> + bootph-pre-ram; >> + >> + k3_sysreset: sysreset-controller { >> + compatible = "ti,sci-sysreset"; >> + bootph-pre-ram; >> + }; >> +}; >> -- >> 2.34.1
Hi Jon, On jeu., avril 11, 2024 at 15:30, Jon Humphreys <j-humphreys@ti.com> wrote: > Mattijs Korpershoek <mkorpershoek@baylibre.com> writes: > >> Hi Jonathan, >> >> Thank you for the patch. >> >> On lun., avril 08, 2024 at 17:31, Jonathan Humphreys <j-humphreys@ti.com> wrote: >> >>> Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com> >> >> Please consider adding a commit message body. > > Got it. thanks. > > BTW, the next version of this series will drop this patch as Andrew has > submitted another patch removing the need for this one. See > https://lore.kernel.org/r/20240402160908.508974-1-afd@ti.com. I was not aware of that one. thank you for pointing it out. That seems indeed a better solution. > >> >> On the TI vendor tree, there is a similar patch with a commit message: >> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2023.04&id=c5296d943c2c84dd6dcb3b91305d006ac46f3157 >> >> Before patch: >> => reset >> resetting ... >> System reset not supported on this platform >> ### ERROR ### Please RESET the board ### >> >> With patch applied: >> => reset >> resetting ... >> >> Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on am62x sk evm >> >> Andrew also suggested to me that if we are interested by A53 reset only, >> we can PSCI reset instead for all k3 architecture: >> >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -784,6 +784,9 @@ config ARCH_K3 >> bool "Texas Instruments' K3 Architecture" >> select SPL >> select SUPPORT_SPL >> + select PSCI_RESET if ARM64 >> + select SYSRESET if ARM64 >> + select SYSRESET_PSCI if ARM64 >> select FIT >> select REGEX >> select FIT_SIGNATURE if ARM64 >> >> Has the above been considered? > > I am not aware. I would think that you want full reset, unless you are > thinking about specifying a reset level? On my end, I was mostly interested in resetting from the A53 core, but the solution you linked previously should work for me. > > Jon > >> >> >>> --- >>> arch/arm/dts/k3-am625-sk-u-boot.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>> index fa778b0ff4c..35bfeae75a0 100644 >>> --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>> +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi >>> @@ -46,3 +46,12 @@ >>> &cpsw_port2 { >>> status = "disabled"; >>> }; >>> + >>> +&dmsc { >>> + bootph-pre-ram; >>> + >>> + k3_sysreset: sysreset-controller { >>> + compatible = "ti,sci-sysreset"; >>> + bootph-pre-ram; >>> + }; >>> +}; >>> -- >>> 2.34.1
diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi index fa778b0ff4c..35bfeae75a0 100644 --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi @@ -46,3 +46,12 @@ &cpsw_port2 { status = "disabled"; }; + +&dmsc { + bootph-pre-ram; + + k3_sysreset: sysreset-controller { + compatible = "ti,sci-sysreset"; + bootph-pre-ram; + }; +};
Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com> --- arch/arm/dts/k3-am625-sk-u-boot.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)