| Message ID | 20240322131011.1029620-3-n-francis@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Cleanup K3 binman templating | expand |
diff --git a/tools/binman/control.py b/tools/binman/control.py index 2f00279232b..1c4e6a581f9 100644 --- a/tools/binman/control.py +++ b/tools/binman/control.py @@ -522,9 +522,13 @@ def _ProcessTemplates(parent): def _RemoveTemplates(parent): """Remove any templates in the binman description """ + del_nodes = [] for node in parent.subnodes: if node.name.startswith('template'): - node.Delete() + del_nodes.append(node) + + for node in del_nodes: + node.Delete() def PrepareImagesAndDtbs(dtb_fname, select_images, update_fdt, use_expanded): """Prepare the images to be processed and select the device tree
Dynamically going through the subnode array and deleting leads to templates being skipped from deletion when templates are consecutive in the subnode list. Prevent this from happening by first parsing the DT and then deleting the nodes. Signed-off-by: Neha Malcom Francis <n-francis@ti.com> --- tools/binman/control.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)