| Message ID | 20240307152302.2338472-1-parth105105@gmail.com |
|---|---|
| State | Accepted |
| Commit | 1fd4c5ad73793a9af70d2d3095c7cb8605758ddd |
| Delegated to: | Fabio Estevam |
| Headers | show |
| Series | [v1] configs: colibri-imx7: enable watchdog | expand |
Hi Parth, On Thu, Mar 7, 2024 at 12:23 PM Parth Pancholi <parth105105@gmail.com> wrote: > > From: Parth Pancholi <parth.pancholi@toradex.com> > > Enable watchdog functionality for Toradex's Colibri iMX7 (NAND/EMMC) > modules. You described what the patch does, but the reason is missing. Is the reason for this patch to fix the 'reset' command regression like you did at: https://gitlab.com/u-boot/u-boot/-/commit/be23b1331fb35b7d5a095ef2c0b522c1f241eee9 ? Please send a v2 with an improved commit log.
Hello Fabio, On Mon, Mar 11, 2024 at 07:44:02AM -0300, Fabio Estevam wrote: > On Thu, Mar 7, 2024 at 12:23 PM Parth Pancholi <parth105105@gmail.com> wrote: > > From: Parth Pancholi <parth.pancholi@toradex.com> > > > > Enable watchdog functionality for Toradex's Colibri iMX7 (NAND/EMMC) > > modules. > > You described what the patch does, but the reason is missing. > > Is the reason for this patch to fix the 'reset' command regression > like you did at: > https://gitlab.com/u-boot/u-boot/-/commit/be23b1331fb35b7d5a095ef2c0b522c1f241eee9 > ? > > Please send a v2 with an improved commit log. No, on colibri-imx7 the reset is already working, it uses the PMIC so it's not affected by the issue that was affecting most of our other boards. The reason for enabling the watchdog here is just an improvement to improve reliability, given we have it enabled on other boards with no drawback it seems nice and consistent to enable it. Francesco
Hi Francesco, On Mon, Mar 11, 2024 at 8:34 AM Francesco Dolcini <francesco@dolcini.it> wrote: > No, on colibri-imx7 the reset is already working, it uses the PMIC so > it's not affected by the issue that was affecting most of our other > boards. > > The reason for enabling the watchdog here is just an improvement to > improve reliability, given we have it enabled on other boards with no > drawback it seems nice and consistent to enable it. Thanks for the clarification. In this case, I will apply it to u-boot-imx next branch.
On Thu, Mar 7, 2024 at 12:23 PM Parth Pancholi <parth105105@gmail.com> wrote: > > From: Parth Pancholi <parth.pancholi@toradex.com> > > Enable watchdog functionality for Toradex's Colibri iMX7 (NAND/EMMC) > modules. > > Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com> Applied for u-boot-imx/next, thanks.
diff --git a/arch/arm/dts/imx7d-colibri-eval-v3-u-boot.dtsi b/arch/arm/dts/imx7d-colibri-eval-v3-u-boot.dtsi index 68142769d3..854bf2798a 100644 --- a/arch/arm/dts/imx7d-colibri-eval-v3-u-boot.dtsi +++ b/arch/arm/dts/imx7d-colibri-eval-v3-u-boot.dtsi @@ -51,3 +51,7 @@ }; }; }; + +&wdog1 { + bootph-pre-ram; +}; diff --git a/configs/colibri_imx7_defconfig b/configs/colibri_imx7_defconfig index 58eb431785..0c6a272ddf 100644 --- a/configs/colibri_imx7_defconfig +++ b/configs/colibri_imx7_defconfig @@ -98,10 +98,12 @@ CONFIG_DM_PMIC=y CONFIG_PMIC_RN5T567=y CONFIG_MXC_UART=y CONFIG_IMX_THERMAL=y +CONFIG_IMX_WATCHDOG=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="Toradex" CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 +CONFIG_WDT=y CONFIG_CI_UDC=y diff --git a/configs/colibri_imx7_emmc_defconfig b/configs/colibri_imx7_emmc_defconfig index 3382371d40..9d4423cd0d 100644 --- a/configs/colibri_imx7_emmc_defconfig +++ b/configs/colibri_imx7_emmc_defconfig @@ -85,10 +85,12 @@ CONFIG_DM_PMIC=y CONFIG_PMIC_RN5T567=y CONFIG_MXC_UART=y CONFIG_IMX_THERMAL=y +CONFIG_IMX_WATCHDOG=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="Toradex" CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 +CONFIG_WDT=y CONFIG_CI_UDC=y