diff mbox series

ARM: dts: stm32: Fix reset for usart1 in scmi configuration

Message ID 20240104123750.232991-1-patrice.chotard@foss.st.com
State Accepted
Commit ea5a4d69d84eb6fc0b5bda6a45cee2de255da256
Delegated to: Patrice Chotard
Headers show
Series ARM: dts: stm32: Fix reset for usart1 in scmi configuration | expand

Commit Message

Patrice CHOTARD Jan. 4, 2024, 12:37 p.m. UTC
In SCMI configuration, usart1 is secure, so all its resources are secured
(clock and reset) and can't be set/unset by non-secure world but by OP-TEE.

Fixes: 6cccc8d396bf ("ARM: dts: stm32: add SCMI version of STM32 boards (DK1/DK2/ED1/EV1)")

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---

 arch/arm/dts/stm32mp15-scmi-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Patrick Delaunay Jan. 4, 2024, 5:33 p.m. UTC | #1
Hi,

On 1/4/24 13:37, Patrice Chotard wrote:
> In SCMI configuration, usart1 is secure, so all its resources are secured
> (clock and reset) and can't be set/unset by non-secure world but by OP-TEE.
>
> Fixes: 6cccc8d396bf ("ARM: dts: stm32: add SCMI version of STM32 boards (DK1/DK2/ED1/EV1)")
>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>
>   arch/arm/dts/stm32mp15-scmi-u-boot.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi
> index 7c8fec6cbfb..79494ecad90 100644
> --- a/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi
> +++ b/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi
> @@ -135,7 +135,7 @@
>   };
>   
>   &usart1 {
> -	resets = <&rcc USART1_R>;
> +	resets = <&scmi_reset RST_SCMI_USART1>;
>   };
>   
>   &usart2 {


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick
Patrice CHOTARD Jan. 19, 2024, 1:05 p.m. UTC | #2
On 1/4/24 18:33, Patrick DELAUNAY wrote:
> Hi,
> 
> On 1/4/24 13:37, Patrice Chotard wrote:
>> In SCMI configuration, usart1 is secure, so all its resources are secured
>> (clock and reset) and can't be set/unset by non-secure world but by OP-TEE.
>>
>> Fixes: 6cccc8d396bf ("ARM: dts: stm32: add SCMI version of STM32 boards (DK1/DK2/ED1/EV1)")
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>
>>   arch/arm/dts/stm32mp15-scmi-u-boot.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi
>> index 7c8fec6cbfb..79494ecad90 100644
>> --- a/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi
>> @@ -135,7 +135,7 @@
>>   };
>>     &usart1 {
>> -    resets = <&rcc USART1_R>;
>> +    resets = <&scmi_reset RST_SCMI_USART1>;
>>   };
>>     &usart2 {
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 
> 


Applied to u-boot-stm32/master

Thanks
Patrice
diff mbox series

Patch

diff --git a/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi
index 7c8fec6cbfb..79494ecad90 100644
--- a/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp15-scmi-u-boot.dtsi
@@ -135,7 +135,7 @@ 
 };
 
 &usart1 {
-	resets = <&rcc USART1_R>;
+	resets = <&scmi_reset RST_SCMI_USART1>;
 };
 
 &usart2 {