[v1,10/12] fastboot: check device type for SPI NAND too

Message ID	20231228153922.84323-11-avromanov@salutedevices.com
State	Superseded
Delegated to:	Dario Binacchi
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Alexey Romanov <avromanov@salutedevices.com> To: <michal.simek@amd.com>, <marex@denx.de>, <michael@walle.cc>, <stcarlso@linux.microsoft.com>, <tobias@waldekranz.com>, <seanedmond@microsoft.com>, <abdellatif.elkhlifi@arm.com>, <neil.armstrong@linaro.org>, <n-jain1@ti.com>, <xypron.glpk@gmx.de>, <dario.binacchi@amarulasolutions.com>, <michael@amarulasolutions.com>, <frieder.schrempf@kontron.de>, <sjg@chromium.org>, <hs@denx.de>, <sean.anderson@seco.com>, <dimorinny@google.com>, <mkorpershoek@baylibre.com>, <patrick.delaunay@foss.st.com> CC: <u-boot@lists.denx.de>, <kernel@salutedevices.com>, Alexey Romanov <avromanov@salutedevices.com> Subject: [PATCH v1 10/12] fastboot: check device type for SPI NAND too Date: Thu, 28 Dec 2023 18:39:13 +0300 Message-ID: <20231228153922.84323-11-avromanov@salutedevices.com> In-Reply-To: <20231228153922.84323-1-avromanov@salutedevices.com> References: <20231228153922.84323-1-avromanov@salutedevices.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain FromAlignment: s, ApMailHostAddress: 100.64.160.123 bases: 2023/12/28 11:18:00 #22863388 Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	Support SPI NAND in fastboot protocol \| expand [v1,00/12] Support SPI NAND in fastboot protocol [v1,01/12] nand: move NAND initialization API to nand/core.c [v1,02/12] nand: don't overwrite mtd name in nand_register() [v1,03/12] nand: move nand_util.c to NAND core folder [v1,04/12] nand: move nand_erase_opts() to core NAND folder [v1,05/12] spi: add board_nand_init() function [v1,06/12] spi: use nand_register() instead of add_mtd_device() [v1,07/12] mtdparts: use negative error codes [v1,08/12] jffs2: use negative error codes [v1,09/12] cmd: allow to enable CMD_NAND for SPI NAND devices [v1,10/12] fastboot: check device type for SPI NAND too [v1,11/12] fastboot: enable FASTBOOT_FLASH option for SPI NAND devices [v1,12/12] fastboot: fb_nand: add missing newlines in pr_err() macro

Message ID

20231228153922.84323-11-avromanov@salutedevices.com

State

Superseded

Delegated to:

Dario Binacchi

Headers

From: Alexey Romanov <avromanov@salutedevices.com>
To: <michal.simek@amd.com>, <marex@denx.de>, <michael@walle.cc>,
 <stcarlso@linux.microsoft.com>, <tobias@waldekranz.com>,
 <seanedmond@microsoft.com>, <abdellatif.elkhlifi@arm.com>,
 <neil.armstrong@linaro.org>, <n-jain1@ti.com>, <xypron.glpk@gmx.de>,
 <dario.binacchi@amarulasolutions.com>, <michael@amarulasolutions.com>,
 <frieder.schrempf@kontron.de>, <sjg@chromium.org>, <hs@denx.de>,
 <sean.anderson@seco.com>, <dimorinny@google.com>,
 <mkorpershoek@baylibre.com>, <patrick.delaunay@foss.st.com>
CC: <u-boot@lists.denx.de>, <kernel@salutedevices.com>, Alexey Romanov
 <avromanov@salutedevices.com>
Subject: [PATCH v1 10/12] fastboot: check device type for SPI NAND too
Date: Thu, 28 Dec 2023 18:39:13 +0300
Message-ID: <20231228153922.84323-11-avromanov@salutedevices.com>
In-Reply-To: <20231228153922.84323-1-avromanov@salutedevices.com>
References: <20231228153922.84323-1-avromanov@salutedevices.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

Support SPI NAND in fastboot protocol | expand

SPI NAND devices also supports 'fastboot erase / flash' commands. Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> --- drivers/fastboot/fb_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sean Anderson Dec. 28, 2023, 4:54 p.m. UTC | #1

On 12/28/23 10:39, Alexey Romanov wrote:
> SPI NAND devices also supports 'fastboot erase / flash' commands.
> 
> Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
> ---
>  drivers/fastboot/fb_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
> index 6d3a900c77..39d888301f 100644
> --- a/drivers/fastboot/fb_nand.c
> +++ b/drivers/fastboot/fb_nand.c
> @@ -53,7 +53,7 @@ static int fb_nand_lookup(const char *partname,
>  		return ret;
>  	}
>  
> -	if (dev->id->type != MTD_DEV_TYPE_NAND) {
> +	if (dev->id->type != MTD_DEV_TYPE_NAND && dev->id->type != MTD_DEV_TYPE_SPINAND) {
>  		pr_err("partition '%s' is not stored on a NAND device",
>  		      partname);
>  		fastboot_fail("not a NAND device", response);

Reviewed-by: Sean Anderson <sean.anderson@seco.com>

Mattijs Korpershoek Jan. 2, 2024, 1 p.m. UTC | #2

Hi Alexey,

Thank you for the patch.

On Thu, Dec 28, 2023 at 18:39, Alexey Romanov <avromanov@salutedevices.com> wrote:

> SPI NAND devices also supports 'fastboot erase / flash' commands.
>
> Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  drivers/fastboot/fb_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
> index 6d3a900c77..39d888301f 100644
> --- a/drivers/fastboot/fb_nand.c
> +++ b/drivers/fastboot/fb_nand.c
> @@ -53,7 +53,7 @@ static int fb_nand_lookup(const char *partname,
>  		return ret;
>  	}
>  
> -	if (dev->id->type != MTD_DEV_TYPE_NAND) {
> +	if (dev->id->type != MTD_DEV_TYPE_NAND && dev->id->type != MTD_DEV_TYPE_SPINAND) {
>  		pr_err("partition '%s' is not stored on a NAND device",
>  		      partname);
>  		fastboot_fail("not a NAND device", response);
> -- 
> 2.30.1

diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
index 6d3a900c77..39d888301f 100644
--- a/drivers/fastboot/fb_nand.c
+++ b/drivers/fastboot/fb_nand.c
@@ -53,7 +53,7 @@  static int fb_nand_lookup(const char *partname,
 		return ret;
 	}
 
-	if (dev->id->type != MTD_DEV_TYPE_NAND) {
+	if (dev->id->type != MTD_DEV_TYPE_NAND && dev->id->type != MTD_DEV_TYPE_SPINAND) {
 		pr_err("partition '%s' is not stored on a NAND device",
 		      partname);
 		fastboot_fail("not a NAND device", response);

[v1,10/12] fastboot: check device type for SPI NAND too

Commit Message

Comments

Patch