| Message ID | 20231217163627.2339802-11-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | Make bootph tags transistive to parents | expand |
On Sun, Dec 17, 2023 at 09:36:23AM -0700, Simon Glass wrote: > Use this flag so that the bootph binding is obeyed correctly. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Fixes: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/12 First of all, yay, this will I believe unblock upstreaming of these properties. > --- > > scripts/Makefile.lib | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 8dc6ec82cd56..21b1f7daa72c 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -631,7 +631,7 @@ fdtgrep_props := -b bootph-all -b bootph-pre-ram $(migrate_spl) > endif > endif > quiet_cmd_fdtgrep = FDTGREP $@ > - cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \ > + cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -u -RT $< \ > -n /chosen -n /config -O dtb | \ > $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \ > -P bootph-all -P bootph-pre-ram -P bootph-pre-sram \ Maybe we need to expand / add some comment here? In practice right now I don't think we have an issue in that say "keep-power-in-suspend" is already not being included in these special subset trees, but we want to I think at least make it clear for future users what unexpected things might happen.
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 8dc6ec82cd56..21b1f7daa72c 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -631,7 +631,7 @@ fdtgrep_props := -b bootph-all -b bootph-pre-ram $(migrate_spl) endif endif quiet_cmd_fdtgrep = FDTGREP $@ - cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \ + cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -u -RT $< \ -n /chosen -n /config -O dtb | \ $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \ -P bootph-all -P bootph-pre-ram -P bootph-pre-sram \
Use this flag so that the bootph binding is obeyed correctly. Signed-off-by: Simon Glass <sjg@chromium.org> Fixes: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/12 --- scripts/Makefile.lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)