| Message ID | 20231116102251.53365-1-heinrich.schuchardt@canonical.com |
|---|---|
| State | Accepted |
| Commit | 3980baa41144b979da784cc83d9d3cc9126ca8c6 |
| Delegated to: | Andes |
| Headers | show |
| Series | [1/1] risc-v: qemu: imply NVME_PCI | expand |
> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > Date: Thu, 16 Nov 2023 11:22:51 +0100 > > CONFIG_NVME=y without CONFIG_NVME_PCI=y does not provide working NVMe > support. Instead of implying CONFIG_NVME we must imply CONFIG_NVME_PCI > which will select CONFIG_NVME. > > Fixes: e64db0d92e32 ("riscv: qemu: Enable e1000 and nvme support") > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > board/emulation/qemu-riscv/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed by: Mark Kettenis <kettenis@openbsd.org> > diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig > index 933b035991..32511b4e4e 100644 > --- a/board/emulation/qemu-riscv/Kconfig > +++ b/board/emulation/qemu-riscv/Kconfig > @@ -56,8 +56,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy > imply SCSI_AHCI > imply AHCI_PCI > imply E1000 > - imply NVME > imply PCI > + imply NVME_PCI > imply PCIE_ECAM_GENERIC > imply DM_RNG > imply SCSI > -- > 2.40.1 > >
diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig index 933b035991..32511b4e4e 100644 --- a/board/emulation/qemu-riscv/Kconfig +++ b/board/emulation/qemu-riscv/Kconfig @@ -56,8 +56,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy imply SCSI_AHCI imply AHCI_PCI imply E1000 - imply NVME imply PCI + imply NVME_PCI imply PCIE_ECAM_GENERIC imply DM_RNG imply SCSI
CONFIG_NVME=y without CONFIG_NVME_PCI=y does not provide working NVMe support. Instead of implying CONFIG_NVME we must imply CONFIG_NVME_PCI which will select CONFIG_NVME. Fixes: e64db0d92e32 ("riscv: qemu: Enable e1000 and nvme support") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> --- board/emulation/qemu-riscv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)