diff mbox series

[v2] net: eth-uclass: Improve error message when MAC is not found

Message ID 20231020124151.1968187-1-festevam@gmail.com
State Accepted
Commit 7907cf80049df56d7a8f66c91626154986fa59e2
Delegated to: Tom Rini
Headers show
Series [v2] net: eth-uclass: Improve error message when MAC is not found | expand

Commit Message

Fabio Estevam Oct. 20, 2023, 12:41 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

While bringinp up a new board without the MAC fuses programmed,
the following error message was observed:

Error: ethernet@30bf0000 address not set.

Improve the error message to make it clearer the reason of
the failure.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Reword the error message. (Lothar)

 net/eth-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Nov. 6, 2023, 4:32 p.m. UTC | #1 
On Fri, Oct 20, 2023 at 09:41:51AM -0300, Fabio Estevam wrote:

> From: Fabio Estevam <festevam@denx.de>
> 
> While bringinp up a new board without the MAC fuses programmed,
> the following error message was observed:
> 
> Error: ethernet@30bf0000 address not set.
> 
> Improve the error message to make it clearer the reason of
> the failure.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index 4311f3fe6e89..1f0985ec52ca 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -594,7 +594,7 @@  static int eth_post_probe(struct udevice *dev)
 		eth_env_set_enetaddr_by_index("eth", dev_seq(dev),
 					      pdata->enetaddr);
 #else
-		printf("\nError: %s address not set.\n",
+		printf("\nError: %s No valid MAC address found.\n",
 		       dev->name);
 		return -EINVAL;
 #endif