diff mbox series

[v1] drivers: don't compile Secure Monitor UCLASS unconditionally

Message ID 20231013130411.46569-1-avromanov@salutedevices.com
State Handled Elsewhere
Delegated to: Neil Armstrong
Headers show
Series [v1] drivers: don't compile Secure Monitor UCLASS unconditionally | expand

Commit Message

Alexey Romanov Oct. 13, 2023, 1:04 p.m. UTC
It makes no sense to compile Secure Monitor unconditionally.
For example, this break the SPL build on boards with a small
allowed SPL image size.

Fixes: 126fbbefd89e ("drivers: introduce Secure Monitor uclass")

Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
---
 drivers/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Oct. 14, 2023, 6:19 p.m. UTC | #1
On Fri, 13 Oct 2023 at 09:57, Alexey Romanov
<avromanov@salutedevices.com> wrote:
>
> It makes no sense to compile Secure Monitor unconditionally.
> For example, this break the SPL build on boards with a small
> allowed SPL image size.
>
> Fixes: 126fbbefd89e ("drivers: introduce Secure Monitor uclass")
>
> Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
> ---
>  drivers/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Neil Armstrong Oct. 15, 2023, 10:30 a.m. UTC | #2
Le 13/10/2023 à 15:04, Alexey Romanov a écrit :
> It makes no sense to compile Secure Monitor unconditionally.
> For example, this break the SPL build on boards with a small
> allowed SPL image size.
> 
> Fixes: 126fbbefd89e ("drivers: introduce Secure Monitor uclass")
> 
> Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
> ---
>   drivers/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/Makefile b/drivers/Makefile
> index b7bd3633b1..1a768fed2b 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -34,6 +34,7 @@ obj-$(CONFIG_$(SPL_TPL_)VIRTIO) += virtio/
>   obj-$(CONFIG_$(SPL_)DM_MAILBOX) += mailbox/
>   obj-$(CONFIG_$(SPL_)REMOTEPROC) += remoteproc/
>   obj-$(CONFIG_$(SPL_)SYSINFO) += sysinfo/
> +obj-$(CONFIG_$(SPL_TPL_)SM) += sm/
>   obj-$(CONFIG_$(SPL_TPL_)TPM) += tpm/
>   obj-$(CONFIG_XEN) += xen/
>   obj-$(CONFIG_$(SPL_)FPGA) += fpga/
> @@ -124,4 +125,3 @@ obj-$(CONFIG_DM_RNG) += rng/
>   endif
>   
>   obj-y += soc/
> -obj-y += sm/

Thanks, squashed into 126fbbefd89e ("drivers: introduce Secure Monitor uclass")

Neil
diff mbox series

Patch

diff --git a/drivers/Makefile b/drivers/Makefile
index b7bd3633b1..1a768fed2b 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -34,6 +34,7 @@  obj-$(CONFIG_$(SPL_TPL_)VIRTIO) += virtio/
 obj-$(CONFIG_$(SPL_)DM_MAILBOX) += mailbox/
 obj-$(CONFIG_$(SPL_)REMOTEPROC) += remoteproc/
 obj-$(CONFIG_$(SPL_)SYSINFO) += sysinfo/
+obj-$(CONFIG_$(SPL_TPL_)SM) += sm/
 obj-$(CONFIG_$(SPL_TPL_)TPM) += tpm/
 obj-$(CONFIG_XEN) += xen/
 obj-$(CONFIG_$(SPL_)FPGA) += fpga/
@@ -124,4 +125,3 @@  obj-$(CONFIG_DM_RNG) += rng/
 endif
 
 obj-y += soc/
-obj-y += sm/