| Message ID | 20230901084810.238594-1-marek.vasut+renesas@mailbox.org |
|---|---|
| State | Accepted |
| Commit | c807bdd0a973139c577893c18e044c3c86da0c40 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | .gitlab-ci: Test sandbox64 board in addition to sandbox | expand |
On Fri, Sep 01, 2023 at 10:48:10AM +0200, Marek Vasut wrote: > Test both 32bit and 64bit sandbox boards in CI. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > --- > Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Rini <trini@konsulko.com> > --- > DEPENDS: > - [v2] test: print: Fix hexdump test on 64bit systems > - test: dm: test-fdt: Use fdtdec_get_int() in dm_check_devices() > - configs: sandbox64: Enable legacy image format support Nice work. Reviewed-by: Tom Rini <trini@konsulko.com> > --- > .gitlab-ci.yml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 6d7ffdd1bbc..a7282be3181 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -291,6 +291,23 @@ sandbox without LTO test.py: > BUILD_ENV: "NO_LTO=1" > <<: *buildman_and_testpy_dfn > > +sandbox64 test.py: > + variables: > + TEST_PY_BD: "sandbox64" > + <<: *buildman_and_testpy_dfn > + > +sandbox64 with clang test.py: > + variables: > + TEST_PY_BD: "sandbox64" > + OVERRIDE: "-O clang-16" > + <<: *buildman_and_testpy_dfn > + > +sandbox64 without LTO test.py: > + variables: > + TEST_PY_BD: "sandbox64" > + BUILD_ENV: "NO_LTO=1" > + <<: *buildman_and_testpy_dfn I think this means it'll be time to split sandbox out in to its own stage on Azure as we can get 10 meaningful-but-long runs there and so it's best for overall job time to make that a stage. I'll go give that a spin shortly unless you want to.
On Fri, Sep 01, 2023 at 10:48:10AM +0200, Marek Vasut wrote: > Test both 32bit and 64bit sandbox boards in CI. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > --- > Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Rini <trini@konsulko.com> > --- > DEPENDS: > - [v2] test: print: Fix hexdump test on 64bit systems > - test: dm: test-fdt: Use fdtdec_get_int() in dm_check_devices() > - configs: sandbox64: Enable legacy image format support > --- > .gitlab-ci.yml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 6d7ffdd1bbc..a7282be3181 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -291,6 +291,23 @@ sandbox without LTO test.py: > BUILD_ENV: "NO_LTO=1" > <<: *buildman_and_testpy_dfn > > +sandbox64 test.py: > + variables: > + TEST_PY_BD: "sandbox64" > + <<: *buildman_and_testpy_dfn > + > +sandbox64 with clang test.py: > + variables: > + TEST_PY_BD: "sandbox64" > + OVERRIDE: "-O clang-16" > + <<: *buildman_and_testpy_dfn > + > +sandbox64 without LTO test.py: > + variables: > + TEST_PY_BD: "sandbox64" > + BUILD_ENV: "NO_LTO=1" > + <<: *buildman_and_testpy_dfn I'm not sure it's worth building and testing sandbox64 without LTO as well. The primary reason we do this here is to ensure that the NO_LTO flag keeps working, rather than specific outputs from the tests, and we should _probably_ change the current one to be a case where we just test that the version test runs and passes.
On 9/1/23 20:11, Tom Rini wrote: > On Fri, Sep 01, 2023 at 10:48:10AM +0200, Marek Vasut wrote: >> Test both 32bit and 64bit sandbox boards in CI. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> >> --- >> Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> >> Cc: Simon Glass <sjg@chromium.org> >> Cc: Tom Rini <trini@konsulko.com> >> --- >> DEPENDS: >> - [v2] test: print: Fix hexdump test on 64bit systems >> - test: dm: test-fdt: Use fdtdec_get_int() in dm_check_devices() >> - configs: sandbox64: Enable legacy image format support >> --- >> .gitlab-ci.yml | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> index 6d7ffdd1bbc..a7282be3181 100644 >> --- a/.gitlab-ci.yml >> +++ b/.gitlab-ci.yml >> @@ -291,6 +291,23 @@ sandbox without LTO test.py: >> BUILD_ENV: "NO_LTO=1" >> <<: *buildman_and_testpy_dfn >> >> +sandbox64 test.py: >> + variables: >> + TEST_PY_BD: "sandbox64" >> + <<: *buildman_and_testpy_dfn >> + >> +sandbox64 with clang test.py: >> + variables: >> + TEST_PY_BD: "sandbox64" >> + OVERRIDE: "-O clang-16" >> + <<: *buildman_and_testpy_dfn >> + >> +sandbox64 without LTO test.py: >> + variables: >> + TEST_PY_BD: "sandbox64" >> + BUILD_ENV: "NO_LTO=1" >> + <<: *buildman_and_testpy_dfn > > I'm not sure it's worth building and testing sandbox64 without LTO as > well. The primary reason we do this here is to ensure that the NO_LTO > flag keeps working, rather than specific outputs from the tests, and we > should _probably_ change the current one to be a case where we just test > that the version test runs and passes. It is faster to finish building if nothing else.
On 9/1/23 15:24, Tom Rini wrote: > On Fri, Sep 01, 2023 at 10:48:10AM +0200, Marek Vasut wrote: > >> Test both 32bit and 64bit sandbox boards in CI. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> >> --- >> Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> >> Cc: Simon Glass <sjg@chromium.org> >> Cc: Tom Rini <trini@konsulko.com> >> --- >> DEPENDS: >> - [v2] test: print: Fix hexdump test on 64bit systems >> - test: dm: test-fdt: Use fdtdec_get_int() in dm_check_devices() >> - configs: sandbox64: Enable legacy image format support > > Nice work. > > Reviewed-by: Tom Rini <trini@konsulko.com> > >> --- >> .gitlab-ci.yml | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> index 6d7ffdd1bbc..a7282be3181 100644 >> --- a/.gitlab-ci.yml >> +++ b/.gitlab-ci.yml >> @@ -291,6 +291,23 @@ sandbox without LTO test.py: >> BUILD_ENV: "NO_LTO=1" >> <<: *buildman_and_testpy_dfn >> >> +sandbox64 test.py: >> + variables: >> + TEST_PY_BD: "sandbox64" >> + <<: *buildman_and_testpy_dfn >> + >> +sandbox64 with clang test.py: >> + variables: >> + TEST_PY_BD: "sandbox64" >> + OVERRIDE: "-O clang-16" >> + <<: *buildman_and_testpy_dfn >> + >> +sandbox64 without LTO test.py: >> + variables: >> + TEST_PY_BD: "sandbox64" >> + BUILD_ENV: "NO_LTO=1" >> + <<: *buildman_and_testpy_dfn > > I think this means it'll be time to split sandbox out in to its own > stage on Azure as we can get 10 meaningful-but-long runs there and so > it's best for overall job time to make that a stage. I'll go give that a > spin shortly unless you want to. Sure
On Fri, Sep 01, 2023 at 10:48:10AM +0200, Marek Vasut wrote: > Test both 32bit and 64bit sandbox boards in CI. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/next, thanks!
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6d7ffdd1bbc..a7282be3181 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -291,6 +291,23 @@ sandbox without LTO test.py: BUILD_ENV: "NO_LTO=1" <<: *buildman_and_testpy_dfn +sandbox64 test.py: + variables: + TEST_PY_BD: "sandbox64" + <<: *buildman_and_testpy_dfn + +sandbox64 with clang test.py: + variables: + TEST_PY_BD: "sandbox64" + OVERRIDE: "-O clang-16" + <<: *buildman_and_testpy_dfn + +sandbox64 without LTO test.py: + variables: + TEST_PY_BD: "sandbox64" + BUILD_ENV: "NO_LTO=1" + <<: *buildman_and_testpy_dfn + sandbox_spl test.py: variables: TEST_PY_BD: "sandbox_spl"
Test both 32bit and 64bit sandbox boards in CI. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> --- Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@konsulko.com> --- DEPENDS: - [v2] test: print: Fix hexdump test on 64bit systems - test: dm: test-fdt: Use fdtdec_get_int() in dm_check_devices() - configs: sandbox64: Enable legacy image format support --- .gitlab-ci.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)