| Message ID | 20230830140349.10801-4-lists@steffen.cc |
|---|---|
| State | Changes Requested |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | board: xilinx: zyqmp: add Beckhoff CX8200 | expand |
On 8/30/23 16:03, Steffen Dirkwinkel wrote: > From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com> > > With the current config we'd put the fdt outside of memory. > > Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com> > --- > > include/configs/xilinx_zynqmp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h > index 74264b7bee..334fe95d66 100644 > --- a/include/configs/xilinx_zynqmp.h > +++ b/include/configs/xilinx_zynqmp.h > @@ -50,7 +50,7 @@ > #endif > > #define ENV_MEM_LAYOUT_SETTINGS \ > - "fdt_addr_r=0x40000000\0" \ > + "fdt_addr_r=0x28000000\0" \ > "fdt_size_r=0x400000\0" \ > "pxefile_addr_r=0x10000000\0" \ > "kernel_addr_r=0x18000000\0" \ This is not the right way to go. I have started to move these variables setting to DT. You can take a look at https://github.com/devicetree-org/dt-schema/commit/3815da51a138619f443abcf2f821ca0a6fd57949 And fdt_addr_r is the same case. It should be moved to DT and remove it from here. Thanks, Michal
diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h index 74264b7bee..334fe95d66 100644 --- a/include/configs/xilinx_zynqmp.h +++ b/include/configs/xilinx_zynqmp.h @@ -50,7 +50,7 @@ #endif #define ENV_MEM_LAYOUT_SETTINGS \ - "fdt_addr_r=0x40000000\0" \ + "fdt_addr_r=0x28000000\0" \ "fdt_size_r=0x400000\0" \ "pxefile_addr_r=0x10000000\0" \ "kernel_addr_r=0x18000000\0" \