| Message ID | 20230828215037.482278-1-marcel@ziswiler.com |
|---|---|
| State | Accepted |
| Commit | 7dee63faccbcea41c9c0c2d177391438d5725da2 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [v1] include: configs: verdin-am62: drop unused sdram address | expand |
Hi Marcel, Thank you for following up this quickly on this. On lun., août 28, 2023 at 23:50, Marcel Ziswiler <marcel@ziswiler.com> wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Drop unused macro. This was copied straight from the AM62x EVM but while > meant for a second region of DDR this is not even needed for the AM62x > EVM configurations and has meanwhile also been dropped there. > > Note that on the Verdin AM62, we do auto-detect the amount of SDRAM. > > While at it also update the comment noting that CFG_SYS_SDRAM_SIZE is > the maximum which is only used for such auto-detection. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > > --- > > include/configs/verdin-am62.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/configs/verdin-am62.h b/include/configs/verdin-am62.h > index 7990ea83102..e1a5f5ad44b 100644 > --- a/include/configs/verdin-am62.h > +++ b/include/configs/verdin-am62.h > @@ -13,8 +13,7 @@ > > /* DDR Configuration */ > #define CFG_SYS_SDRAM_BASE 0x80000000 > -#define CFG_SYS_SDRAM_BASE1 0x880000000 > -#define CFG_SYS_SDRAM_SIZE SZ_2G /* Maximum supported size */ > +#define CFG_SYS_SDRAM_SIZE SZ_2G /* Maximum supported size, auto-detection is used */ > > #define MEM_LAYOUT_ENV_SETTINGS \ > "fdt_addr_r=0x90200000\0" \ > -- > 2.36.1
On Mon, Aug 28, 2023 at 11:50:37PM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Drop unused macro. This was copied straight from the AM62x EVM but while > meant for a second region of DDR this is not even needed for the AM62x > EVM configurations and has meanwhile also been dropped there. > > Note that on the Verdin AM62, we do auto-detect the amount of SDRAM. > > While at it also update the comment noting that CFG_SYS_SDRAM_SIZE is > the maximum which is only used for such auto-detection. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Applied to u-boot/next, thanks!
diff --git a/include/configs/verdin-am62.h b/include/configs/verdin-am62.h index 7990ea83102..e1a5f5ad44b 100644 --- a/include/configs/verdin-am62.h +++ b/include/configs/verdin-am62.h @@ -13,8 +13,7 @@ /* DDR Configuration */ #define CFG_SYS_SDRAM_BASE 0x80000000 -#define CFG_SYS_SDRAM_BASE1 0x880000000 -#define CFG_SYS_SDRAM_SIZE SZ_2G /* Maximum supported size */ +#define CFG_SYS_SDRAM_SIZE SZ_2G /* Maximum supported size, auto-detection is used */ #define MEM_LAYOUT_ENV_SETTINGS \ "fdt_addr_r=0x90200000\0" \